chore(*): renaming components to directives where necessary

Author: ChronosSF

.travis.yml

@@ -20,10 +20,10 @@ before_script:
 - npm install -g gulp
 - npm install -g istanbul-combine
 script:
-# - npm run lint:lib
+- npm run lint:lib
 - ng build igniteui-angular --prod
 - npm run build:style
-- if [ -z "${TRAVIS_TAG}" ]; then npm run test:lib:perf; fi
+# - if [ -z "${TRAVIS_TAG}" ]; then npm run test:lib:perf; fi
 - if [ -z "${TRAVIS_TAG}" ]; then npm run test:lib:others; fi
 - if [ -z "${TRAVIS_TAG}" ]; then npm run test:lib:grid; fi
 - if [ -z "${TRAVIS_TAG}" ]; then npm run test:lib:tgrid; fi

projects/igniteui-angular/src/lib/combo/combo-dropdown.component.ts

@@ -7,7 +7,7 @@ import { IgxDropDownComponent } from '../drop-down/drop-down.component';
 import { DropDownActionKey } from '../drop-down/drop-down.common';
 import { IgxComboAddItemComponent } from './combo-add-item.component';
 import { IgxComboAPIService } from './combo.api';
-import { IgxDropDownItemBase } from '../drop-down/drop-down-item.base';
+import { IgxDropDownItemBaseDirective } from '../drop-down/drop-down-item.base';
 import { IgxSelectionAPIService } from '../core/selection';
 import { IgxComboItemComponent } from './combo-item.component';
 import { DisplayDensityToken, IDisplayDensityOptions } from '../core/density';
@@ -50,7 +50,7 @@ export class IgxComboDropDownComponent extends IgxDropDownComponent implements I
      * @internal
      */
     @ContentChildren(IgxComboItemComponent, { descendants: true })
-    public children: QueryList<IgxDropDownItemBase> = null;
+    public children: QueryList<IgxDropDownItemBaseDirective> = null;
 
     /**
      * @hidden @internal
@@ -107,7 +107,7 @@ export class IgxComboDropDownComponent extends IgxDropDownComponent implements I
     /**
      * @hidden @internal
      */
-    public selectItem(item: IgxDropDownItemBase) {
+    public selectItem(item: IgxDropDownItemBaseDirective) {
         if (item === null || item === undefined) {
             return;
         }
@@ -127,10 +127,10 @@ export class IgxComboDropDownComponent extends IgxDropDownComponent implements I
         this.comboAPI.disableTransitions = true;
     }
 
-    protected get sortedChildren(): IgxDropDownItemBase[] {
+    protected get sortedChildren(): IgxDropDownItemBaseDirective[] {
         if (this.children !== undefined) {
             return this.children.toArray()
-                .sort((a: IgxDropDownItemBase, b: IgxDropDownItemBase) => {
+                .sort((a: IgxDropDownItemBaseDirective, b: IgxDropDownItemBaseDirective) => {
                     return a.index - b.index;
                 });
         }

projects/igniteui-angular/src/lib/combo/combo.component.spec.ts

@@ -14,7 +14,7 @@ import { take } from 'rxjs/operators';
 import { UIInteractions, wait } from '../test-utils/ui-interactions.spec';
 import { DefaultSortingStrategy } from '../data-operations/sorting-strategy';
 import { configureTestSuite } from '../test-utils/configure-suite';
-import { IgxDropDownItemBase } from '../drop-down/drop-down-item.base';
+import { IgxDropDownItemBaseDirective } from '../drop-down/drop-down-item.base';
 import { DisplayDensity, DisplayDensityToken } from '../core/density';
 import { AbsoluteScrollStrategy, ConnectedPositioningStrategy } from '../services/index';
 import { IgxInputState } from '../directives/input/input.directive';
@@ -1009,8 +1009,8 @@ describe('igxCombo', () => {
             expect(combo.collapsed).toEqual(false);
             expect(combo.dropdown.items.length).toEqual(9); // Virtualization
 
-            let targetItem: IgxDropDownItemBase;
-            targetItem = combo.dropdown.items[5] as IgxDropDownItemBase;
+            let targetItem: IgxDropDownItemBaseDirective;
+            targetItem = combo.dropdown.items[5] as IgxDropDownItemBaseDirective;
             expect(targetItem).toBeDefined();
             expect(targetItem.itemIndex).toEqual(5);
 

projects/igniteui-angular/src/lib/drop-down/drop-down-item.base.ts

@@ -17,7 +17,7 @@ let warningShown = false;
 @Directive({
     selector: '[igxDropDownItemBase]'
 })
-export class IgxDropDownItemBase implements DoCheck {
+export class IgxDropDownItemBaseDirective implements DoCheck {
     /**
      * @hidden
      */
@@ -62,7 +62,7 @@ export class IgxDropDownItemBase implements DoCheck {
     public get index(): number {
         if (this._index === null) {
             warningShown = showMessage(
-                'IgxDropDownItemBase: Automatic index is deprecated.' +
+                'IgxDropDownItemBaseDirective: Automatic index is deprecated.' +
                 'Bind in the template instead using `<igx-drop-down-item [index]="i"` instead.`',
                 warningShown);
             return this.itemIndex;
@@ -156,7 +156,7 @@ export class IgxDropDownItemBase implements DoCheck {
      * @hidden @internal
      */
     @Input()
-    @DeprecateProperty(`IgxDropDownItemBase \`isSelected\` property is deprecated.\n` +
+    @DeprecateProperty(`IgxDropDownItemBaseDirective \`isSelected\` property is deprecated.\n` +
         `Use \`selected\` instead.`)
     get isSelected(): boolean {
         return this.selected;
@@ -197,7 +197,7 @@ export class IgxDropDownItemBase implements DoCheck {
     /**
      * @hidden @internal
      */
-    @DeprecateProperty(`IgxDropDownItemBase \`isFocused\` property is depracated.\n` +
+    @DeprecateProperty(`IgxDropDownItemBaseDirective \`isFocused\` property is depracated.\n` +
         `Use \`focused\` instead.`)
     get isFocused(): boolean {
         return this.focused;

projects/igniteui-angular/src/lib/drop-down/drop-down-item.component.ts

@@ -3,7 +3,7 @@ import {
     HostListener,
     HostBinding
 } from '@angular/core';
-import { IgxDropDownItemBase } from './drop-down-item.base';
+import { IgxDropDownItemBaseDirective } from './drop-down-item.base';
 
 /**
  * The `<igx-drop-down-item>` is a container intended for row items in
@@ -13,7 +13,7 @@ import { IgxDropDownItemBase } from './drop-down-item.base';
     selector: 'igx-drop-down-item',
     templateUrl: 'drop-down-item.component.html'
 })
-export class IgxDropDownItemComponent extends IgxDropDownItemBase {
+export class IgxDropDownItemComponent extends IgxDropDownItemBaseDirective {
     /**
      * @inheritdoc
      */

projects/igniteui-angular/src/lib/drop-down/drop-down-navigation.directive.ts

@@ -1,20 +1,20 @@
 import { Directive, Optional, Self, Input, HostListener, Inject } from '@angular/core';
 import { IGX_DROPDOWN_BASE } from './drop-down.common';
 import { IDropDownNavigationDirective } from './drop-down.common';
-import { IgxDropDownBase } from './drop-down.base';
+import { IgxDropDownBaseDirective } from './drop-down.base';
 import { DropDownActionKey } from './drop-down.common';
 
 /**
- * Navigation Directive that handles keyboard events on its host and controls a targeted IgxDropDownBase component
+ * Navigation Directive that handles keyboard events on its host and controls a targeted IgxDropDownBaseDirective component
  */
 @Directive({
     selector: '[igxDropDownItemNavigation]'
 })
 export class IgxDropDownItemNavigationDirective implements IDropDownNavigationDirective {
 
-    protected _target: IgxDropDownBase = null;
+    protected _target: IgxDropDownBaseDirective = null;
 
-    constructor(@Self() @Optional() @Inject(IGX_DROPDOWN_BASE) public dropdown: IgxDropDownBase) { }
+    constructor(@Self() @Optional() @Inject(IGX_DROPDOWN_BASE) public dropdown: IgxDropDownBaseDirective) { }
 
     /**
      * Gets the target of the navigation directive;
@@ -26,11 +26,11 @@ export class IgxDropDownItemNavigationDirective implements IDropDownNavigationDi
      *  @ContentChild(IgxDropDownNavigationDirective)
      *  navDirective: IgxDropDownNavigationDirective = null
      *  ...
-     *  const navTarget: IgxDropDownBase = navDirective.navTarget
+     *  const navTarget: IgxDropDownBaseDirective = navDirective.navTarget
      * }
      * ```
      */
-    get target(): IgxDropDownBase {
+    get target(): IgxDropDownBaseDirective {
         return this._target;
     }
 
@@ -48,7 +48,7 @@ export class IgxDropDownItemNavigationDirective implements IDropDownNavigationDi
      * ```
      */
     @Input('igxDropDownItemNavigation')
-    set target(target: IgxDropDownBase) {
+    set target(target: IgxDropDownBaseDirective) {
         this._target = target ? target : this.dropdown;
     }
 

projects/igniteui-angular/src/lib/drop-down/drop-down.base.ts

@@ -5,22 +5,22 @@ import {
 import { Navigate, ISelectionEventArgs } from './drop-down.common';
 import { IDropDownList } from './drop-down.common';
 import { DropDownActionKey } from './drop-down.common';
-import { IgxDropDownItemBase } from './drop-down-item.base';
+import { IgxDropDownItemBaseDirective } from './drop-down-item.base';
 import { DisplayDensityBase, DisplayDensityToken, IDisplayDensityOptions } from '../core/density';
 
 let NEXT_ID = 0;
 
 /**
  * An abstract class, defining a drop-down component, with:
  * Properties for display styles and classes
- * A collection items of type `IgxDropDownItemBase`
+ * A collection items of type `IgxDropDownItemBaseDirective`
  * Properties and methods for navigating (highlighting/focusing) items from the collection
  * Properties and methods for selecting items from the collection
  */
 @Directive({
     selector: '[igxDropDownBase]'
 })
-export class IgxDropDownBase extends DisplayDensityBase implements IDropDownList {
+export class IgxDropDownBaseDirective extends DisplayDensityBase implements IDropDownList {
     protected _width;
     protected _height;
     protected _focusedItem: any = null;
@@ -37,7 +37,7 @@ export class IgxDropDownBase extends DisplayDensityBase implements IDropDownList
      * @hidden
      * @internal
      */
-    public children: QueryList<IgxDropDownItemBase>;
+    public children: QueryList<IgxDropDownItemBaseDirective>;
 
     /**
      * Emitted when item selection is changing, before the selection completes
@@ -123,8 +123,8 @@ export class IgxDropDownBase extends DisplayDensityBase implements IDropDownList
      * let myDropDownItems = this.dropdown.items;
      * ```
      */
-    public get items(): IgxDropDownItemBase[] {
-        const items: IgxDropDownItemBase[] = [];
+    public get items(): IgxDropDownItemBaseDirective[] {
+        const items: IgxDropDownItemBaseDirective[] = [];
         if (this.children !== undefined) {
             for (const child of this.children.toArray()) {
                 if (!child.isHeader) {
@@ -143,8 +143,8 @@ export class IgxDropDownBase extends DisplayDensityBase implements IDropDownList
      * let myDropDownHeaderItems = this.dropdown.headers;
      * ```
      */
-    public get headers(): IgxDropDownItemBase[] {
-        const headers: IgxDropDownItemBase[] = [];
+    public get headers(): IgxDropDownItemBaseDirective[] {
+        const headers: IgxDropDownItemBaseDirective[] = [];
         if (this.children !== undefined) {
             for (const child of this.children.toArray()) {
                 if (child.isHeader) {
@@ -196,7 +196,7 @@ export class IgxDropDownBase extends DisplayDensityBase implements IDropDownList
      * @param newSelection the item selected
      * @param event the event that triggered the call
      */
-    public selectItem(newSelection?: IgxDropDownItemBase, event?: Event) {
+    public selectItem(newSelection?: IgxDropDownItemBaseDirective, event?: Event) {
         this.onSelection.emit({
             newSelection,
             oldSelection: null,
@@ -207,14 +207,14 @@ export class IgxDropDownBase extends DisplayDensityBase implements IDropDownList
     /**
      * @hidden @internal
      */
-    public get focusedItem(): IgxDropDownItemBase {
+    public get focusedItem(): IgxDropDownItemBaseDirective {
         return this._focusedItem;
     }
 
     /**
      * @hidden @internal
      */
-    public set focusedItem(item: IgxDropDownItemBase) {
+    public set focusedItem(item: IgxDropDownItemBaseDirective) {
         this._focusedItem = item;
     }
 
@@ -287,7 +287,7 @@ export class IgxDropDownBase extends DisplayDensityBase implements IDropDownList
         this.navigate(Navigate.Up);
     }
 
-    protected scrollToHiddenItem(newItem: IgxDropDownItemBase) {
+    protected scrollToHiddenItem(newItem: IgxDropDownItemBaseDirective) {
         const elementRect = newItem.element.nativeElement.getBoundingClientRect();
         const parentRect = this.scrollContainer.getBoundingClientRect();
         if (parentRect.top > elementRect.top) {

projects/igniteui-angular/src/lib/drop-down/drop-down.common.ts

@@ -1,5 +1,5 @@
 import { CancelableEventArgs, CancelableBrowserEventArgs, IBaseEventArgs } from '../core/utils';
-import { IgxDropDownItemBase } from './drop-down-item.base';
+import { IgxDropDownItemBaseDirective } from './drop-down-item.base';
 import { IToggleView } from '../core/navigation/IToggleView';
 import { EventEmitter, InjectionToken } from '@angular/core';
 import { DisplayDensityBase } from '../core/density';
@@ -22,8 +22,8 @@ export enum DropDownActionKey {
  * @export
  */
 export interface ISelectionEventArgs extends CancelableEventArgs, IBaseEventArgs {
-    oldSelection: IgxDropDownItemBase;
-    newSelection: IgxDropDownItemBase;
+    oldSelection: IgxDropDownItemBaseDirective;
+    newSelection: IgxDropDownItemBaseDirective;
 }
 
 /**
@@ -51,9 +51,9 @@ export interface IDropDownList extends DisplayDensityBase {
     id: string;
     maxHeight: string;
     collapsed: boolean;
-    items: IgxDropDownItemBase[];
-    headers: IgxDropDownItemBase[];
-    focusedItem: IgxDropDownItemBase;
+    items: IgxDropDownItemBaseDirective[];
+    headers: IgxDropDownItemBaseDirective[];
+    focusedItem: IgxDropDownItemBaseDirective;
     navigateFirst(): void;
     navigateLast(): void;
     navigateNext(): void;
@@ -73,6 +73,6 @@ export interface IDropDownBase extends IDropDownList, IToggleView {
     onClosed: EventEmitter<void>;
     allowItemsFocus?: boolean;
     setSelectedItem(index: number): void;
-    selectItem(item: IgxDropDownItemBase, event?: Event): void;
+    selectItem(item: IgxDropDownItemBaseDirective, event?: Event): void;
 }
 

projects/igniteui-angular/src/lib/drop-down/drop-down.component.spec.ts

@@ -13,7 +13,7 @@ import { configureTestSuite } from '../test-utils/configure-suite';
 import { take } from 'rxjs/operators';
 import { IgxDropDownGroupComponent } from './drop-down-group.component';
 import { IgxForOfDirective, IgxForOfModule } from '../directives/for-of/for_of.directive';
-import { IgxDropDownItemBase } from './drop-down-item.base';
+import { IgxDropDownItemBaseDirective } from './drop-down-item.base';
 import { DisplayDensityToken, DisplayDensity } from '../core/density';
 
 const CSS_CLASS_FOCUSED = 'igx-drop-down__item--focused';
@@ -1398,7 +1398,7 @@ describe('IgxDropDown ', () => {
         it('Should properly preserve selection when scrolled', (done) => {
             dropdown.toggle();
             expect(dropdown.selectedItem).toBe(null);
-            dropdown.selectItem({ value: fixture.componentInstance.items[5], index: 5 } as IgxDropDownItemBase);
+            dropdown.selectItem({ value: fixture.componentInstance.items[5], index: 5 } as IgxDropDownItemBaseDirective);
             fixture.detectChanges();
             expect(dropdown.selectedItem as any).toEqual({ value: fixture.componentInstance.items[5], index: 5 });
             expect(items.toArray()[5].selected).toEqual(true);
@@ -1419,12 +1419,12 @@ describe('IgxDropDown ', () => {
         it('Should properly select items both inside and outside of the virtual view', (done) => {
             dropdown.toggle();
             expect(dropdown.selectedItem).toBe(null);
-            let selectedItem = { value: fixture.componentInstance.items[5], index: 5 } as IgxDropDownItemBase;
+            let selectedItem = { value: fixture.componentInstance.items[5], index: 5 } as IgxDropDownItemBaseDirective;
             dropdown.selectItem(selectedItem);
             fixture.detectChanges();
             expect(dropdown.selectedItem as any).toEqual(selectedItem);
             expect(items.toArray()[5].selected).toEqual(true);
-            selectedItem = { value: fixture.componentInstance.items[412], index: 412 } as IgxDropDownItemBase;
+            selectedItem = { value: fixture.componentInstance.items[412], index: 412 } as IgxDropDownItemBaseDirective;
             dropdown.selectItem(selectedItem);
             fixture.detectChanges();
             expect(dropdown.selectedItem as any).toEqual(selectedItem);
@@ -1442,7 +1442,7 @@ describe('IgxDropDown ', () => {
             dropdown.toggle();
             expect(dropdown.selectedItem).toBe(null);
             const virtualScroll = fixture.componentInstance.virtualScroll;
-            const selectedItem = { value: fixture.componentInstance.items[1000], index: 1000 } as IgxDropDownItemBase;
+            const selectedItem = { value: fixture.componentInstance.items[1000], index: 1000 } as IgxDropDownItemBaseDirective;
             dropdown.selectItem(selectedItem);
             fixture.detectChanges();
             dropdown.toggle();