chore(*): Fixing tabs selectedIndex two-way binding

mpavlinov · mpavlinov · commit 5d7b056a04d6 · 2019-09-19T18:54:09.000+03:00
diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts
@@ -333,7 +333,7 @@ export class IgxGridComponent extends IgxGridBaseComponent implements IGridDataB
     set groupingExpansionState(value) {
         this._groupingExpandState = cloneArray(value);
         this.groupingExpansionStateChange.emit(this._groupingExpandState);
-        this.cdr.detectChanges();
+        this.notifyChanges();
     }
 
     /**
diff --git a/projects/igniteui-angular/src/lib/tabs/tabs.component.ts b/projects/igniteui-angular/src/lib/tabs/tabs.component.ts
@@ -82,7 +82,6 @@ export class IgxTabsComponent implements IgxTabsBase, AfterViewInit, OnDestroy {
             } else {
                 this._selectedIndex = newIndex;
             }
-            this.selectedIndexChange.emit(this._selectedIndex);
         }
     }
 
@@ -383,6 +382,7 @@ export class IgxTabsComponent implements IgxTabsBase, AfterViewInit, OnDestroy {
             // if there is no new selected tab hide the selection indicator
             this.hideIndicator();
         }
+        this.selectedIndexChange.emit(this._selectedIndex);
     }
 
     private performDeselection(oldTab: IgxTabItemBase): void {

Original file line number	Diff line number	Diff line change
`@@ -333,7 +333,7 @@ export class IgxGridComponent extends IgxGridBaseComponent implements IGridDataB`
`333`	`333`	`set groupingExpansionState(value) {`
`334`	`334`	`this._groupingExpandState = cloneArray(value);`
`335`	`335`	`this.groupingExpansionStateChange.emit(this._groupingExpandState);`
`336`		`- this.cdr.detectChanges();`
	`336`	`+ this.notifyChanges();`
`337`	`337`	`}`
`338`	`338`
`339`	`339`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,6 @@ export class IgxTabsComponent implements IgxTabsBase, AfterViewInit, OnDestroy {`
`82`	`82`	`} else {`
`83`	`83`	`this._selectedIndex = newIndex;`
`84`	`84`	`}`
`85`		`- this.selectedIndexChange.emit(this._selectedIndex);`
`86`	`85`	`}`
`87`	`86`	`}`
`88`	`87`
`@@ -383,6 +382,7 @@ export class IgxTabsComponent implements IgxTabsBase, AfterViewInit, OnDestroy {`
`383`	`382`	`// if there is no new selected tab hide the selection indicator`
`384`	`383`	`this.hideIndicator();`
`385`	`384`	`}`
	`385`	`+ this.selectedIndexChange.emit(this._selectedIndex);`
`386`	`386`	`}`
`387`	`387`
`388`	`388`	`private performDeselection(oldTab: IgxTabItemBase): void {`