fix(groupby): Makes newly introduced method name not so general #5643

3phase · 3phase · commit 764fbad1c5ce · 2019-10-09T14:24:13.000+03:00
diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts
@@ -592,7 +592,7 @@ export class IgxGridComponent extends IgxGridBaseComponent implements IGridDataB
 	 * @memberof IgxGridComponent
      */
     public groupBy(expression: IGroupingExpression | Array<IGroupingExpression>): void {
-        if (this.checkIfNoField(expression)) {
+        if (this.checkIfNoColumnField(expression)) {
             return;
         }
         this.endEdit(true);
@@ -996,7 +996,7 @@ export class IgxGridComponent extends IgxGridBaseComponent implements IGridDataB
         }
     }
 
-    public checkIfNoField(expression: IGroupingExpression | Array<IGroupingExpression> | any): boolean {
+    private checkIfNoColumnField(expression: IGroupingExpression | Array<IGroupingExpression> | any): boolean {
         if (expression instanceof Array) {
             for (const singleExpression of expression) {
                 if (!singleExpression.fieldName) {

Original file line number	Diff line number	Diff line change
`@@ -592,7 +592,7 @@ export class IgxGridComponent extends IgxGridBaseComponent implements IGridDataB`
`592`	`592`	`* @memberof IgxGridComponent`
`593`	`593`	`*/`
`594`	`594`	`public groupBy(expression: IGroupingExpression \| Array<IGroupingExpression>): void {`
`595`		`- if (this.checkIfNoField(expression)) {`
	`595`	`+ if (this.checkIfNoColumnField(expression)) {`
`596`	`596`	`return;`
`597`	`597`	`}`
`598`	`598`	`this.endEdit(true);`
`@@ -996,7 +996,7 @@ export class IgxGridComponent extends IgxGridBaseComponent implements IGridDataB`
`996`	`996`	`}`
`997`	`997`	`}`
`998`	`998`
`999`		`- public checkIfNoField(expression: IGroupingExpression \| Array<IGroupingExpression> \| any): boolean {`
	`999`	`+ private checkIfNoColumnField(expression: IGroupingExpression \| Array<IGroupingExpression> \| any): boolean {`
`1000`	`1000`	`if (expression instanceof Array) {`
`1001`	`1001`	`for (const singleExpression of expression) {`
`1002`	`1002`	`if (!singleExpression.fieldName) {`