Skip to content

Commit 818ee7f

Browse files
committed
test(hgrid): add rowSelection tests #5693
1 parent 4dc4821 commit 818ee7f

File tree

7 files changed

+583
-43
lines changed

7 files changed

+583
-43
lines changed

projects/igniteui-angular/src/lib/grids/grid/grid-cell-selection.spec.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,13 +144,12 @@ describe('IgxGrid - Cell selection #grid', () => {
144144
});
145145

146146
it('Should select correct cells with Ctrl key and mouse drag', () => {
147-
pending('Related to the bug 4084');
148147
const range = { rowStart: 3, rowEnd: 2, columnStart: 'Name', columnEnd: 'ParentID' };
149148
const firstCell = grid.getCellByColumn(1, 'ParentID');
150149
const secondCell = grid.getCellByColumn(1, 'ID');
151150
const thirdCell = grid.getCellByColumn(2, 'ParentID');
152151
const expectedData = [
153-
{ ParentID: 147, Name: 'Michael Langdon' },
152+
{ ParentID: 147, Name: 'Monica Reyes' },
154153
{ ParentID: 847, Name: 'Laurence Johnson' },
155154
{ ParentID: 147 }
156155
];

projects/igniteui-angular/src/lib/grids/grid/grid-row-selection.spec.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ describe('IgxGrid - Row Selection #grid', () => {
5555

5656
it('Should have checkbox on each row', (async () => {
5757
HelperUtils.verifyHeaderRowHasCheckbox(fix);
58-
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(fix, grid);
58+
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(grid);
5959

6060
for (const row of grid.rowList.toArray()) {
6161
HelperUtils.verifyRowHasCheckbox(row.nativeElement);
@@ -65,7 +65,7 @@ describe('IgxGrid - Row Selection #grid', () => {
6565
await wait(100);
6666
fix.detectChanges();
6767

68-
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(fix, grid);
68+
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(grid);
6969

7070
for (const row of grid.rowList.toArray()) {
7171
HelperUtils.verifyRowHasCheckbox(row.nativeElement);
@@ -104,19 +104,19 @@ describe('IgxGrid - Row Selection #grid', () => {
104104
it('Should have correct checkboxes position when scroll left', (async () => {
105105
grid.width = '300px';
106106
fix.detectChanges();
107-
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(fix, grid);
107+
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(grid);
108108

109109
GridFunctions.scrollLeft(grid, 1000);
110110
await wait(100);
111111
fix.detectChanges();
112112

113-
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(fix, grid);
113+
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(grid);
114114

115115
GridFunctions.scrollLeft(grid, 0);
116116
await wait(100);
117117
fix.detectChanges();
118118

119-
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(fix, grid);
119+
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(grid);
120120
}));
121121

122122
it('Header checkbox should select/deselect all rows', () => {
@@ -483,7 +483,7 @@ describe('IgxGrid - Row Selection #grid', () => {
483483
HelperUtils.verifyRowSelected(firstRow, false);
484484
HelperUtils.verifyHeaderRowHasCheckbox(fix, false);
485485
HelperUtils.verifyRowHasCheckbox(firstRow.nativeElement);
486-
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(fix, grid);
486+
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(grid);
487487

488488
// Click on a row
489489
UIInteractions.simulateClickEvent(firstRow.nativeElement);
@@ -658,7 +658,7 @@ describe('IgxGrid - Row Selection #grid', () => {
658658
grid.rowSelection = GridSelectionMode.multiple;
659659
fix.detectChanges();
660660

661-
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(fix, grid);
661+
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(grid);
662662
HelperUtils.verifyRowSelected(grid.getRowByIndex(0), false, false);
663663
HelperUtils.verifyHeaderRowCheckboxState(fix);
664664
HelperUtils.verifyHeaderRowHasCheckbox(fix);
@@ -678,7 +678,7 @@ describe('IgxGrid - Row Selection #grid', () => {
678678

679679
it('Should have checkbox on each row nd do not have header checkbox', (async () => {
680680
HelperUtils.verifyHeaderRowHasCheckbox(fix, false);
681-
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(fix, grid);
681+
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(grid);
682682

683683
for (const row of grid.rowList.toArray()) {
684684
HelperUtils.verifyRowHasCheckbox(row.nativeElement);
@@ -689,7 +689,7 @@ describe('IgxGrid - Row Selection #grid', () => {
689689
fix.detectChanges();
690690

691691
HelperUtils.verifyHeaderRowHasCheckbox(fix, false);
692-
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(fix, grid);
692+
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(grid);
693693

694694
for (const row of grid.rowList.toArray()) {
695695
HelperUtils.verifyRowHasCheckbox(row.nativeElement);
@@ -958,7 +958,7 @@ describe('IgxGrid - Row Selection #grid', () => {
958958
HelperUtils.verifyRowSelected(firstRow, false);
959959
HelperUtils.verifyHeaderRowHasCheckbox(fix);
960960
HelperUtils.verifyRowHasCheckbox(firstRow.nativeElement);
961-
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(fix, grid);
961+
HelperUtils.verifyHeaderAndRowCheckBoxesAlignment(grid);
962962

963963
// Click on a row
964964
UIInteractions.simulateClickEvent(firstRow.nativeElement);

projects/igniteui-angular/src/lib/grids/grid/grid.search.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,6 @@ describe('IgxGrid - search API #grid', () => {
528528
});
529529

530530
it('Highlight should be updated when a column is hidden and there are other hidden columns', () => {
531-
pending('Related to the bug 3691');
532531
grid.columns[1].hidden = true;
533532
fix.detectChanges();
534533

0 commit comments

Comments
 (0)