Skip to content

Commit b3b9bf3

Browse files
authored
Merge branch 'master' into nrobakova/fix-issue-5837
2 parents aded0db + 1bad52d commit b3b9bf3

File tree

8 files changed

+52
-15
lines changed

8 files changed

+52
-15
lines changed

projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -675,6 +675,7 @@
675675
%grid-thead-container {
676676
grid-row: 3;
677677
display: flex;
678+
overflow: hidden;
678679

679680
%igx-grid__drag-indicator {
680681
cursor: default;
@@ -823,6 +824,7 @@
823824
position: relative;
824825
display: flex;
825826
grid-row: 4;
827+
overflow: hidden;
826828
}
827829

828830
%grid-tbody-message {
@@ -853,6 +855,7 @@
853855
width: 100%;
854856
background: --var($theme, 'header-background');
855857
z-index: 10001;
858+
overflow: hidden;
856859
}
857860

858861
%grid-thead-thumb {
@@ -867,6 +870,7 @@
867870

868871
%grid-tbody-scrollbar {
869872
border-left: 1px solid igx-color($palette, 'grays', 300);
873+
position: relative;
870874
}
871875

872876
%grid-scroll-start {
@@ -1788,6 +1792,7 @@
17881792
padding: map-get($grouparea-padding, 'comfortable');
17891793
z-index: 2;
17901794
height: 100%;
1795+
overflow: hidden;
17911796

17921797
&:focus {
17931798
outline-style: none;

projects/igniteui-angular/src/lib/core/styles/components/input/_input-group-theme.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -841,6 +841,7 @@
841841
font-size: inherit;
842842
vertical-align: top;
843843
margin-left: $required-symbol-margin; /* 2px base is 16px */
844+
display: inline-block;
844845
}
845846
}
846847

projects/igniteui-angular/src/lib/grids/grid-base.component.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2898,8 +2898,12 @@ export abstract class IgxGridBaseComponent extends DisplayDensityBase implements
28982898
}
28992899
});
29002900

2901-
this.resizeNotify.pipe(destructor, filter(() => !this._init), throttleTime(40))
2902-
.subscribe(() => this.notifyChanges(true));
2901+
this.resizeNotify.pipe(destructor, filter(() => !this._init), throttleTime(100))
2902+
.subscribe(() => {
2903+
this.zone.run(() => {
2904+
this.notifyChanges(true);
2905+
});
2906+
});
29032907

29042908
this.onPagingDone.pipe(destructor).subscribe(() => {
29052909
this.endEdit(true);

projects/igniteui-angular/src/lib/grids/grid/grid.component.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
<igx-grid-toolbar [style.width.px]="outerWidth" role="rowgroup" *ngIf="showToolbar" [gridID]="id"
1+
<igx-grid-toolbar [style.flex-basis.px]="outerWidth" role="rowgroup" *ngIf="showToolbar" [gridID]="id"
22
[displayDensity]="displayDensity" #toolbar>
33
</igx-grid-toolbar>
44

5-
<div [style.width.px]='outerWidth' class="igx-grid__grouparea"
5+
<div [style.flex-basis.px]='outerWidth' class="igx-grid__grouparea"
66
*ngIf="groupingExpressions.length > 0 || hasGroupableColumns" #groupArea>
77
<igx-chips-area (onReorder)="chipsOrderChanged($event)" (onMoveEnd)="chipsMovingEnded()">
88
<ng-container *ngFor="let expr of chipsGoupingExpressions; let last = last;">
@@ -29,7 +29,7 @@
2929

3030
<div class="igx-grid__thead">
3131
<div class="igx-grid__thead-wrapper" [class.igx-grid__tr--mrl]='hasColumnLayouts' role="rowgroup"
32-
[style.width.px]='calcWidth' #theadRow>
32+
[style.width.px]='calcWidth' #theadRow>
3333
<div class="igx-grid__tr" role="row" [style.width.px]='calcWidth'>
3434
<span *ngIf="hasMovableColumns && draggedColumn && pinnedColumns.length <= 0"
3535
[igxColumnMovingDrop]="parentVirtDir" [attr.droppable]="true" id="left"

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<igx-grid-toolbar role="rowgroup" [style.width.px]="outerWidth" *ngIf="showToolbar" [gridID]="id"
1+
<igx-grid-toolbar role="rowgroup" [style.flex-basis.px]="outerWidth" *ngIf="showToolbar" [gridID]="id"
22
[displayDensity]="displayDensity" #toolbar>
33
</igx-grid-toolbar>
44

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<igx-grid-toolbar role="rowgroup" [style.width.px]='outerWidth' *ngIf="showToolbar" [gridID]="id"
1+
<igx-grid-toolbar role="rowgroup" [style.flex-basis.px]='outerWidth' *ngIf="showToolbar" [gridID]="id"
22
[displayDensity]="displayDensity" #toolbar>
33
</igx-grid-toolbar>
44

@@ -109,7 +109,7 @@
109109
</div>
110110
</div>
111111

112-
<div class="igx-grid__tfoot" [style.width.px]='outerWidth' role="rowgroup" [style.height.px]='summariesHeight' #tfoot>
112+
<div class="igx-grid__tfoot" role="rowgroup" [style.height.px]='summariesHeight' #tfoot>
113113
<igx-grid-summary-row [style.width.px]='calcWidth' [style.height.px]='summariesHeight'
114114
*ngIf="hasSummarizedColumns && rootSummariesEnabled" [gridID]="id"
115115
[summaries]="id | igxGridSummaryDataPipe:summaryService.retriggerRootPipe" [index]="0"

src/app/grid-flex-layout/grid-flex.sample.html

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,16 @@
22
<div igxFlex igxLayout igxLayoutDir="column">
33
<div igxFlex>
44
<h4 class="sample-title">Grid1</h4>
5-
<igx-grid #grid1 [data]="localData" [autoGenerate]="true">
5+
<igx-grid #grid1 [columnPinning]='true' [paging]='true' [data]="localData" [showToolbar]='true' [autoGenerate]="false">
6+
<igx-column *ngFor="let c of columns" [field]="c.field"
7+
[header]="c.field"
8+
[resizable]="true"
9+
[width]="c.width"
10+
[groupable] = 'true'
11+
[hasSummary] = 'true'
12+
[minWidth]="c.minWidth"
13+
[maxWidth]="c.maxWidth" [editable]='true'>
14+
</igx-column>
615
</igx-grid>
716

817
</div>
@@ -11,5 +20,19 @@ <h4 class="sample-title">Grid2</h4>
1120
<igx-grid #grid2 [data]="localData" [autoGenerate]="true">
1221
</igx-grid>
1322
</div>
23+
24+
<div igxFlex>
25+
<h4 class="sample-title">HGrid</h4>
26+
<igx-hierarchical-grid [showToolbar]='true' [data]="localData" [autoGenerate]="true" #hGrid2>
27+
<igx-row-island [key]="'childData'" [autoGenerate]="true" [allowFiltering]='true' >
28+
</igx-row-island>
29+
</igx-hierarchical-grid>
30+
</div>
31+
32+
<div igxFlex>
33+
<h4 class="sample-title">TreeGrid</h4>
34+
<igx-tree-grid childDataKey="Child" [data]="localData" [autoGenerate]="true">
35+
</igx-tree-grid>
36+
</div>
1437
</div>
1538
</div>

src/app/grid-flex-layout/grid-flex.sample.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,21 @@ export class GridFlexSampleComponent implements OnInit, AfterViewInit {
1313
public localData;
1414
@ViewChild('grid1', { static: true })
1515
grid1: IgxGridComponent;
16+
columns;
1617

1718
constructor(){
1819
}
1920

2021
ngOnInit() {
21-
this.localData = [
22-
{ ID: 1, Name: 'A' },
23-
{ ID: 2, Name: 'B' },
24-
{ ID: 3, Name: 'C' },
25-
{ ID: 4, Name: 'D' },
26-
{ ID: 5, Name: 'E' }
22+
const data = [];
23+
for (let i = 0; i < 20; i++) {
24+
data.push( { ID: i, Name: 'A' + i });
25+
}
26+
this.localData = data;
27+
28+
this.columns = [
29+
{ field: 'ID', width: 800, resizable: true, maxWidth: 1000, minWidth: 70 },
30+
{ field: 'Name', width: 800, resizable: true, maxWidth: 1000, minWidth: 70 }
2731
];
2832
}
2933
ngAfterViewInit() {

0 commit comments

Comments
 (0)