Skip to content

Commit e706d0e

Browse files
committed
chore(*): merge conflicts
2 parents aded0db + e36abe9 commit e706d0e

28 files changed

+397
-77
lines changed

projects/igniteui-angular/src/lib/carousel/carousel.component.ts

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ export class IgxCarouselComponent implements OnDestroy {
107107
* Sets the time `interval` in milliseconds before the slide changes.
108108
* If not set, the carousel will not change `slides` automatically.
109109
* ```html
110-
* <igx-carousel [interval] = "1000"></carousel>
110+
* <igx-carousel [interval] = "1000"></igx-carousel>
111111
* ```
112112
* @memberof IgxCarouselComponent
113113
*/
@@ -512,12 +512,12 @@ export class IgxCarouselComponent implements OnDestroy {
512512
})
513513

514514
export class IgxSlideComponent implements OnInit, OnDestroy {
515-
515+
private _active;
516516
/**
517517
* Gets/sets the `index` of the slide inside the carousel.
518518
* ```html
519519
* <igx-carousel>
520-
* <igx-slide index = "1"</igx-slide>
520+
* <igx-slide index = "1"></igx-slide>
521521
* <igx-carousel>
522522
* ```
523523
* @memberOf IgxSlideComponent
@@ -528,7 +528,7 @@ export class IgxSlideComponent implements OnInit, OnDestroy {
528528
* Gets/sets the target `direction` for the slide.
529529
* ```html
530530
* <igx-carousel>
531-
* <igx-slide direction="NEXT"</igx-slide>
531+
* <igx-slide direction="NEXT"></igx-slide>
532532
* <igx-carousel>
533533
* ```
534534
* @memberOf IgxSlideComponent
@@ -538,13 +538,31 @@ export class IgxSlideComponent implements OnInit, OnDestroy {
538538
* Gets/sets the `active` state of the slide.
539539
* ```html
540540
* <igx-carousel>
541-
* <igx-slide [active] ="false"</igx-slide>
541+
* <igx-slide [active] ="false"></igx-slide>
542+
* <igx-carousel>
543+
* ```
544+
*
545+
* Two-way data binding.
546+
* ```html
547+
* <igx-carousel>
548+
* <igx-slide [(active)] ="model.isActive"></igx-slide>
542549
* <igx-carousel>
543550
* ```
544551
* @memberof IgxSlideComponent
545552
*/
546553
@HostBinding('class.active')
547-
@Input() public active: boolean;
554+
@Input()
555+
public get active(): boolean {
556+
return this._active;
557+
}
558+
public set active(value) {
559+
this._active = value;
560+
this.activeChange.emit(this._active);
561+
}
562+
/**
563+
*@hidden
564+
*/
565+
@Output() public activeChange = new EventEmitter<boolean>();
548566

549567
constructor(private carousel: IgxCarouselComponent) { }
550568
/**

projects/igniteui-angular/src/lib/chips/chip.component.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,12 +165,23 @@ export class IgxChipComponent extends DisplayDensityBase {
165165
* ```html
166166
* <igx-chip #myChip [id]="'igx-chip-1'" [selectable]="true" [selected]="true">
167167
* ```
168+
*
169+
* Two-way data binding:
170+
* ```html
171+
* <igx-chip #myChip [id]="'igx-chip-1'" [selectable]="true" [(selected)]="model.isSelected">
172+
* ```
168173
*/
169174
@Input()
170175
public set selected(newValue: boolean) {
171176
this.changeSelection(newValue);
172177
}
173178

179+
/**
180+
*@hidden
181+
*/
182+
@Output()
183+
public selectedChange = new EventEmitter<boolean>();
184+
174185
/**
175186
* Returns if the `IgxChipComponent` is selected.
176187
* ```typescript
@@ -438,13 +449,15 @@ export class IgxChipComponent extends DisplayDensityBase {
438449
if (!onSelectArgs.cancel) {
439450
this.renderer.addClass(this.chipArea.nativeElement, this._selectedItemClass);
440451
this._selected = newValue;
452+
this.selectedChange.emit(this._selected);
441453
}
442454
} else if (!newValue && this._selected) {
443455
this.onSelection.emit(onSelectArgs);
444456

445457
if (!onSelectArgs.cancel) {
446458
this.renderer.removeClass(this.chipArea.nativeElement, this._selectedItemClass);
447459
this._selected = newValue;
460+
this.selectedChange.emit(this._selected);
448461
}
449462
}
450463
}

projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -675,6 +675,7 @@
675675
%grid-thead-container {
676676
grid-row: 3;
677677
display: flex;
678+
overflow: hidden;
678679

679680
%igx-grid__drag-indicator {
680681
cursor: default;
@@ -823,6 +824,7 @@
823824
position: relative;
824825
display: flex;
825826
grid-row: 4;
827+
overflow: hidden;
826828
}
827829

828830
%grid-tbody-message {
@@ -853,6 +855,7 @@
853855
width: 100%;
854856
background: --var($theme, 'header-background');
855857
z-index: 10001;
858+
overflow: hidden;
856859
}
857860

858861
%grid-thead-thumb {
@@ -867,6 +870,7 @@
867870

868871
%grid-tbody-scrollbar {
869872
border-left: 1px solid igx-color($palette, 'grays', 300);
873+
position: relative;
870874
}
871875

872876
%grid-scroll-start {
@@ -1788,6 +1792,7 @@
17881792
padding: map-get($grouparea-padding, 'comfortable');
17891793
z-index: 2;
17901794
height: 100%;
1795+
overflow: hidden;
17911796

17921797
&:focus {
17931798
outline-style: none;

projects/igniteui-angular/src/lib/core/styles/components/input/_input-group-theme.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -841,6 +841,7 @@
841841
font-size: inherit;
842842
vertical-align: top;
843843
margin-left: $required-symbol-margin; /* 2px base is 16px */
844+
display: inline-block;
844845
}
845846
}
846847

projects/igniteui-angular/src/lib/drop-down/drop-down-item.base.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { IDropDownBase, IGX_DROPDOWN_BASE } from './drop-down.common';
2-
import { Input, HostBinding, HostListener, ElementRef, Optional, Inject, DoCheck } from '@angular/core';
2+
import { Input, HostBinding, HostListener, ElementRef, Optional, Inject, DoCheck, Output, EventEmitter } from '@angular/core';
33
import { IgxSelectionAPIService } from '../core/selection';
44
import { DeprecateProperty, showMessage } from '../core/deprecateDecorators';
55
import { IgxDropDownGroupComponent } from './drop-down-group.component';
@@ -122,6 +122,11 @@ export abstract class IgxDropDownItemBase implements DoCheck {
122122
* let mySelectedItem = this.dropdown.selectedItem;
123123
* let isMyItemSelected = mySelectedItem.selected; // true
124124
* ```
125+
*
126+
* Two-way data binding
127+
* ```html
128+
* <igx-drop-down-item [(selected)]='model.isSelected'></igx-drop-down-item>
129+
* ```
125130
*/
126131
@Input()
127132
@HostBinding('attr.aria-selected')
@@ -135,8 +140,15 @@ export abstract class IgxDropDownItemBase implements DoCheck {
135140
return;
136141
}
137142
this._selected = value;
143+
this.selectedChange.emit(this._selected);
138144
}
139145

146+
/**
147+
*@hidden
148+
*/
149+
@Output()
150+
public selectedChange = new EventEmitter<boolean>();
151+
140152
/**
141153
* @hidden @internal
142154
*/

projects/igniteui-angular/src/lib/drop-down/drop-down-item.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ export class IgxDropDownItemComponent extends IgxDropDownItemBase implements DoC
5353
return;
5454
}
5555
this._selected = value;
56+
this.selectedChange.emit(this._selected);
5657
}
5758
/**
5859
* @hidden @internal

projects/igniteui-angular/src/lib/expansion-panel/expansion-panel.component.ts

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ export interface AnimationSettings {
2727
providers: [{ provide: IGX_EXPANSION_PANEL_COMPONENT, useExisting: IgxExpansionPanelComponent }]
2828
})
2929
export class IgxExpansionPanelComponent implements IgxExpansionPanelBase, AfterContentInit {
30+
private _collapsed = true;
3031
/**
3132
* Sets/gets the animation settings of the expansion panel component
3233
* Open and Close animation should be passed
@@ -95,9 +96,26 @@ export class IgxExpansionPanelComponent implements IgxExpansionPanelBase, AfterC
9596
* ```html
9697
* this.panel.collapsed = true;
9798
* ```
99+
*
100+
* Two-way data binding:
101+
* ```html
102+
* <igx-expansion-panel [(collapsed)]="model.isCollapsed"></igx-expansion-panel>
103+
* ```
98104
*/
99105
@Input()
100-
public collapsed = true;
106+
public get collapsed(): boolean {
107+
return this._collapsed;
108+
}
109+
public set collapsed(value) {
110+
this._collapsed = value;
111+
this.collapsedChange.emit(this._collapsed);
112+
}
113+
114+
/**
115+
*@hidden
116+
*/
117+
@Output()
118+
public collapsedChange = new EventEmitter<boolean>();
101119

102120
/**
103121
* Emitted when the expansion panel finishes collapsing

projects/igniteui-angular/src/lib/grids/column.component.ts

Lines changed: 57 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ import {
99
QueryList,
1010
TemplateRef,
1111
forwardRef,
12-
OnDestroy
12+
OnDestroy,
13+
Output,
14+
EventEmitter
1315
} from '@angular/core';
1416
import { DataType } from '../data-operations/data-util';
1517
import { GridBaseAPIService } from './api.service';
@@ -218,14 +220,20 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy {
218220
/**
219221
* Sets the column hidden property.
220222
* Default value is `false`.
221-
* ```typescript
223+
* ```html
222224
* <igx-column [hidden] = "true"></igx-column>
223225
* ```
226+
*
227+
* Two-way data binding.
228+
* ```html
229+
* <igx-column [(hidden)] = "model.isHidden"></igx-column>
230+
* ```
224231
* @memberof IgxColumnComponent
225232
*/
226233
set hidden(value: boolean) {
227234
if (this._hidden !== value) {
228235
this._hidden = value;
236+
this.hiddenChange.emit(this._hidden);
229237
if (this.columnLayoutChild && this.parent.hidden !== value) {
230238
this.parent.hidden = value;
231239
return;
@@ -239,6 +247,12 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy {
239247
}
240248
}
241249
}
250+
251+
/**
252+
*@hidden
253+
*/
254+
@Output()
255+
public hiddenChange = new EventEmitter<boolean>();
242256
/**
243257
* Gets whether the hiding is disabled.
244258
* ```typescript
@@ -290,6 +304,11 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy {
290304
* ```html
291305
* <igx-column [width] = "'25%'"></igx-column>
292306
* ```
307+
*
308+
* Two-way data binding.
309+
* ```html
310+
* <igx-column [(width)]="model.columns[0].width"></igx-column>
311+
* ```
293312
* @memberof IgxColumnComponent
294313
*/
295314
public set width(value: string) {
@@ -301,9 +320,16 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy {
301320
if (this.grid) {
302321
this.cacheCalcWidth();
303322
}
323+
this.widthChange.emit(this._width);
304324
}
305325
}
306326

327+
/**
328+
*@hidden
329+
*/
330+
@Output()
331+
public widthChange = new EventEmitter<string>();
332+
307333
/**
308334
* @hidden
309335
*/
@@ -483,6 +509,11 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy {
483509
* ```html
484510
* <igx-column [pinned] = "true"></igx-column>
485511
* ```
512+
*
513+
* Two-way data binding.
514+
* ```html
515+
* <igx-column [(pinned)] = "model.columns[0].isPinned"></igx-column>
516+
* ```
486517
* @memberof IgxColumnComponent
487518
*/
488519
public set pinned(value: boolean) {
@@ -495,8 +526,16 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy {
495526
will re-init the group (if present)
496527
*/
497528
this._pinned = value;
529+
this.pinnedChange.emit(this._pinned);
498530
}
499531
}
532+
533+
/**
534+
*@hidden
535+
*/
536+
@Output()
537+
public pinnedChange = new EventEmitter<boolean>();
538+
500539
/**
501540
* @deprecated
502541
* Gets/Sets the `id` of the `igx-grid`.
@@ -1356,6 +1395,7 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy {
13561395
}
13571396

13581397
this._pinned = true;
1398+
this.pinnedChange.emit(this._pinned);
13591399
this._unpinnedIndex = grid._unpinnedColumns.indexOf(this);
13601400
index = index !== undefined ? index : grid._pinnedColumns.length;
13611401
const targetColumn = grid._pinnedColumns[index];
@@ -1420,6 +1460,7 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy {
14201460
index = (index !== undefined ? index :
14211461
this._unpinnedIndex !== undefined ? this._unpinnedIndex : this.index);
14221462
this._pinned = false;
1463+
this.pinnedChange.emit(this._pinned);
14231464

14241465
const targetColumn = grid._unpinnedColumns[index];
14251466

@@ -1769,15 +1810,28 @@ export class IgxColumnGroupComponent extends IgxColumnComponent implements After
17691810
}
17701811
/**
17711812
* Sets the column group hidden property.
1772-
* ```typescript
1813+
* ```html
17731814
* <igx-column [hidden] = "true"></igx-column>
17741815
* ```
1816+
*
1817+
* Two-way data binding
1818+
* ```html
1819+
* <igx-column [(hidden)] = "model.columns[0].isHidden"></igx-column>
1820+
* ```
17751821
* @memberof IgxColumnGroupComponent
17761822
*/
17771823
set hidden(value: boolean) {
17781824
this._hidden = value;
1825+
this.hiddenChange.emit(this._hidden);
17791826
this.children.forEach(child => child.hidden = value);
17801827
}
1828+
1829+
/**
1830+
*@hidden
1831+
*/
1832+
@Output()
1833+
public hiddenChange = new EventEmitter<boolean>();
1834+
17811835
/**
17821836
*@hidden
17831837
*/

0 commit comments

Comments
 (0)