fix(GridSelection): emit correctly new selection when select all rows #5699

ddincheva · ddincheva · commit fb69818e53ba · 2019-08-28T08:48:17.000+03:00
diff --git a/projects/igniteui-angular/src/lib/core/grid-selection.ts b/projects/igniteui-angular/src/lib/core/grid-selection.ts
@@ -559,7 +559,7 @@ export class IgxGridSelectionService {
     selectAllRows(event?) {
         const allRowIDs = this.getRowIDs(this.allData);
         const addedRows =  allRowIDs.filter((rID) => !this.isRowSelected(rID));
-        const newSelection = this.rowSelection.size ? allRowIDs.concat(this.getSelectedRows()) : addedRows;
+        const newSelection = this.rowSelection.size ? this.getSelectedRows().concat(addedRows) : addedRows;
 
         this.emitRowSelectionEvent(newSelection, addedRows, [], event);
     }

Original file line number	Diff line number	Diff line change
`@@ -559,7 +559,7 @@ export class IgxGridSelectionService {`
`559`	`559`	`selectAllRows(event?) {`
`560`	`560`	`const allRowIDs = this.getRowIDs(this.allData);`
`561`	`561`	`const addedRows = allRowIDs.filter((rID) => !this.isRowSelected(rID));`
`562`		`- const newSelection = this.rowSelection.size ? allRowIDs.concat(this.getSelectedRows()) : addedRows;`
	`562`	`+ const newSelection = this.rowSelection.size ? this.getSelectedRows().concat(addedRows) : addedRows;`
`563`	`563`
`564`	`564`	`this.emitRowSelectionEvent(newSelection, addedRows, [], event);`
`565`	`565`	`}`