Handle sleepSteps internally in motionController

Renamed to ignoreSteps in motionController, gets rid of the
`settingsController.sleepSteps` variable

Author: JustScott

src/components/motion/MotionController.cpp

@@ -67,7 +67,7 @@ void MotionController::Update(int16_t x, int16_t y, int16_t z, uint32_t nbSteps)
 
   if (settingsController.isSleepOptionOn(Settings::SleepOption::IgnoreSteps) &&
       settingsController.GetNotificationStatus() == Pinetime::Controllers::Settings::Notification::Sleep) {
-    settingsController.sleepSteps += deltaSteps;
+    ignoreSteps += deltaSteps;
   }
 }
 

src/components/motion/MotionController.h

@@ -36,8 +36,8 @@ namespace Pinetime {
       }
 
       uint32_t NbSteps() const {
-        if (nbSteps > settingsController.sleepSteps) {
-          return nbSteps - settingsController.sleepSteps;
+        if (nbSteps > ignoreSteps) {
+          return nbSteps - ignoreSteps;
         }
         return 0;
       }
@@ -46,6 +46,10 @@ namespace Pinetime {
         currentTripSteps = 0;
       }
 
+      void ResetIgnoreSteps() {
+        ignoreSteps = 0;
+      }
+
       uint32_t GetTripSteps() const {
         return currentTripSteps;
       }
@@ -75,6 +79,7 @@ namespace Pinetime {
     private:
       uint32_t nbSteps = 0;
       uint32_t currentTripSteps = 0;
+      uint32_t ignoreSteps = 0;
 
       TickType_t lastTime = 0;
       TickType_t time = 0;

src/components/settings/Settings.h

@@ -270,7 +270,6 @@ namespace Pinetime {
       }
 
       bool sleepDisabledBle = false;
-      uint32_t sleepSteps = 0;
 
       void setSleepOption(SleepOption option, bool enabled) {
         if (enabled != isSleepOptionOn(option)) {

src/systemtask/SystemTask.cpp

@@ -321,7 +321,6 @@ void SystemTask::Work() {
           // We might be sleeping (with TWI device disabled.
           // Remember we'll have to reset the counter next time we're awake
           stepCounterMustBeReset = true;
-          settingsController.sleepSteps = 0;
           break;
         case Messages::OnNewHour:
         case Messages::OnNewHalfHour:
@@ -447,6 +446,7 @@ void SystemTask::UpdateMotion() {
 
   if (stepCounterMustBeReset) {
     motionSensor.ResetStepCounter();
+    motionController.ResetIgnoreSteps();
     stepCounterMustBeReset = false;
   }