Skip to content

CI DFU upload fails on PRs based on branches with / in them #2126

@NeroBurner

Description

@NeroBurner

Verification

  • I searched for similar issues (including closed issues) and found none was relevant.

Introduce the issue

The Upload DFU artifacts job fails on branches containing /

Found in #2077

Run actions/upload-artifact@v3
/usr/bin/docker exec  8929a36ab468da80dae43387a0c9bb4bf9dcabe29646a93654a36d48575c83ed sh -c "cat /etc/*release | grep ^ID"
With the provided path, there will be 3 files uploaded
Starting artifact upload
For more detailed logs during the artifact upload process, enable step-debugging: https://docs.github.com/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging#enabling-step-debug-logging
Error: Artifact name is not valid: InfiniTime DFU fix/eol-on-windows. Contains the following character:  Forward slash /
          
Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n, Backslash \, Forward slash /
          
These characters are not allowed in the artifact name due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems.

Preferred solution

update actions/upload-artifact@v3 or somehow replace the invalid characters with _ or something like that

Version

main

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions