Commit 37a852d
Removed use of CODE_COVERAGE environment variable
CODE_COVERAGE was used to influence whether the backend SyclInterface library
was built in debug mode with coverage over dpctp-capi/ test suite collected or not.
It was also influencing how Cython extensions were built. It would pass linetrace=true
option to cythonize, and define CYTHON_TRACE preprocessor variable when compiling
Cython-generated C++ source files with compiler.
This change removes use CODE_COVERAGE all together. Instead:
1. Custom setuptools command 'build_ext' is implemented which auto-adds
'CYTHON_TRACE' to the list of defines received by downstream build_ext
command if develop command received --coverage=True
cythonize call was removed from extensions() function, allowing
``python setup.py develop --help` execute cleanly without running
cythonize.
Consequentially, linetrace Cython directive will need to be added to
each .pyx file in a separate commit. This is safe to do per
https://cython.readthedocs.io/en/latest/src/tutorial/profiling_tutorial.html#enabling-line-tracing
since it is a no-op unless CYTHON_TRACE preprocessor variable is also set,
which is only done when --coverage=True is used
2. install setuptools command removed support for `--coverage` option, and always
builds backend without coverage.
This is to avoid inadvertent installation of debug build of library in Python prefix.1 parent 56a8235 commit 37a852d
1 file changed
+28
-37
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | | - | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
42 | 45 | | |
43 | 46 | | |
44 | 47 | | |
| |||
123 | 126 | | |
124 | 127 | | |
125 | 128 | | |
126 | | - | |
127 | 129 | | |
128 | 130 | | |
129 | 131 | | |
| |||
160 | 162 | | |
161 | 163 | | |
162 | 164 | | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | 165 | | |
173 | 166 | | |
174 | 167 | | |
| |||
253 | 246 | | |
254 | 247 | | |
255 | 248 | | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
265 | 268 | | |
266 | 269 | | |
267 | 270 | | |
| |||
279 | 282 | | |
280 | 283 | | |
281 | 284 | | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | 285 | | |
289 | 286 | | |
290 | 287 | | |
291 | 288 | | |
292 | 289 | | |
293 | | - | |
294 | 290 | | |
295 | 291 | | |
296 | 292 | | |
| |||
302 | 298 | | |
303 | 299 | | |
304 | 300 | | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | 301 | | |
312 | 302 | | |
313 | 303 | | |
| |||
326 | 316 | | |
327 | 317 | | |
328 | 318 | | |
329 | | - | |
330 | | - | |
331 | | - | |
| 319 | + | |
332 | 320 | | |
333 | 321 | | |
334 | 322 | | |
| |||
358 | 346 | | |
359 | 347 | | |
360 | 348 | | |
361 | | - | |
| 349 | + | |
362 | 350 | | |
363 | 351 | | |
364 | 352 | | |
| |||
374 | 362 | | |
375 | 363 | | |
376 | 364 | | |
| 365 | + | |
| 366 | + | |
377 | 367 | | |
378 | 368 | | |
379 | 369 | | |
| |||
404 | 394 | | |
405 | 395 | | |
406 | 396 | | |
| 397 | + | |
407 | 398 | | |
408 | 399 | | |
409 | 400 | | |
| |||
0 commit comments