get_minmax_offsets should always return data relative to data ptr

oleksandr-pavlyk · oleksandr-pavlyk · commit a727866d4fb1 · 2023-03-02T06:44:23.000-06:00
This means that it should not be making call to UsmNDArray_GetOffset.
This restores correctness to checks for array region overlapping.
diff --git a/dpctl/apis/include/dpctl4pybind11.hpp b/dpctl/apis/include/dpctl4pybind11.hpp
@@ -943,8 +943,6 @@ class usm_ndarray : public py::object
             }
         }
         else {
-            offset_min = api.UsmNDArray_GetOffset_(raw_ar);
-            offset_max = offset_min;
             for (int i = 0; i < nd; ++i) {
                 py::ssize_t delta = strides[i] * (shape[i] - 1);
                 if (strides[i] > 0) {

Original file line number	Diff line number	Diff line change
`@@ -943,8 +943,6 @@ class usm_ndarray : public py::object`
`943`	`943`	`}`
`944`	`944`	`}`
`945`	`945`	`else {`
`946`		`- offset_min = api.UsmNDArray_GetOffset_(raw_ar);`
`947`		`- offset_max = offset_min;`
`948`	`946`	`for (int i = 0; i < nd; ++i) {`
`949`	`947`	`py::ssize_t delta = strides[i] * (shape[i] - 1);`
`950`	`948`	`if (strides[i] > 0) {`