Skip to content

Commit a7d4737

Browse files
oleksandr-pavlykoleksandr-pavlyk
committed
Pass sycl::queue by reference, instead of by value per Coverity issues
`sycl::queue` stored shared pointer and copying that involves use of atomics. Passing queue by reference ensures no copy.
1 parent 0a11646 commit a7d4737

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

75 files changed

+239
-390
lines changed

‎dpctl/tensor/libtensor/include/kernels/accumulators.hpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ template <typename inputT,
103103
size_t n_wi,
104104
typename IndexerT,
105105
typename TransformerT>
106-
sycl::event inclusive_scan_rec(sycl::queue exec_q,
106+
sycl::event inclusive_scan_rec(sycl::queue &exec_q,
107107
size_t n_elems,
108108
size_t wg_size,
109109
const inputT *input,
@@ -214,14 +214,14 @@ sycl::event inclusive_scan_rec(sycl::queue exec_q,
214214
}
215215

216216
typedef size_t (*accumulate_contig_impl_fn_ptr_t)(
217-
sycl::queue,
217+
sycl::queue &,
218218
size_t,
219219
const char *,
220220
char *,
221221
std::vector<sycl::event> const &);
222222

223223
template <typename maskT, typename cumsumT, typename transformerT>
224-
size_t accumulate_contig_impl(sycl::queue q,
224+
size_t accumulate_contig_impl(sycl::queue &q,
225225
size_t n_elems,
226226
const char *mask,
227227
char *cumsum,
@@ -296,7 +296,7 @@ template <typename fnT, typename T> struct Cumsum1DContigFactory
296296
};
297297

298298
typedef size_t (*accumulate_strided_impl_fn_ptr_t)(
299-
sycl::queue,
299+
sycl::queue &,
300300
size_t,
301301
const char *,
302302
int,
@@ -305,7 +305,7 @@ typedef size_t (*accumulate_strided_impl_fn_ptr_t)(
305305
std::vector<sycl::event> const &);
306306

307307
template <typename maskT, typename cumsumT, typename transformerT>
308-
size_t accumulate_strided_impl(sycl::queue q,
308+
size_t accumulate_strided_impl(sycl::queue &q,
309309
size_t n_elems,
310310
const char *mask,
311311
int nd,

‎dpctl/tensor/libtensor/include/kernels/boolean_advanced_indexing.hpp‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ template <typename OrthoIndexerT,
198198
class masked_extract_all_slices_strided_impl_krn;
199199

200200
typedef sycl::event (*masked_extract_all_slices_strided_impl_fn_ptr_t)(
201-
sycl::queue,
201+
sycl::queue &,
202202
py::ssize_t,
203203
const char *,
204204
const char *,
@@ -211,7 +211,7 @@ typedef sycl::event (*masked_extract_all_slices_strided_impl_fn_ptr_t)(
211211

212212
template <typename dataT, typename indT>
213213
sycl::event masked_extract_all_slices_strided_impl(
214-
sycl::queue exec_q,
214+
sycl::queue &exec_q,
215215
py::ssize_t iteration_size,
216216
const char *src_p,
217217
const char *cumsum_p,
@@ -253,7 +253,7 @@ sycl::event masked_extract_all_slices_strided_impl(
253253
}
254254

255255
typedef sycl::event (*masked_extract_some_slices_strided_impl_fn_ptr_t)(
256-
sycl::queue,
256+
sycl::queue &,
257257
py::ssize_t,
258258
py::ssize_t,
259259
const char *,
@@ -278,7 +278,7 @@ class masked_extract_some_slices_strided_impl_krn;
278278

279279
template <typename dataT, typename indT>
280280
sycl::event masked_extract_some_slices_strided_impl(
281-
sycl::queue exec_q,
281+
sycl::queue &exec_q,
282282
py::ssize_t orthog_nelems,
283283
py::ssize_t masked_nelems,
284284
const char *src_p,
@@ -380,7 +380,7 @@ template <typename OrthoIndexerT,
380380
class masked_place_all_slices_strided_impl_krn;
381381

382382
typedef sycl::event (*masked_place_all_slices_strided_impl_fn_ptr_t)(
383-
sycl::queue,
383+
sycl::queue &,
384384
py::ssize_t,
385385
char *,
386386
const char *,
@@ -393,7 +393,7 @@ typedef sycl::event (*masked_place_all_slices_strided_impl_fn_ptr_t)(
393393

394394
template <typename dataT, typename indT>
395395
sycl::event masked_place_all_slices_strided_impl(
396-
sycl::queue exec_q,
396+
sycl::queue &exec_q,
397397
py::ssize_t iteration_size,
398398
char *dst_p,
399399
const char *cumsum_p,
@@ -430,7 +430,7 @@ sycl::event masked_place_all_slices_strided_impl(
430430
}
431431

432432
typedef sycl::event (*masked_place_some_slices_strided_impl_fn_ptr_t)(
433-
sycl::queue,
433+
sycl::queue &,
434434
py::ssize_t,
435435
py::ssize_t,
436436
char *,
@@ -455,7 +455,7 @@ class masked_place_some_slices_strided_impl_krn;
455455

456456
template <typename dataT, typename indT>
457457
sycl::event masked_place_some_slices_strided_impl(
458-
sycl::queue exec_q,
458+
sycl::queue &exec_q,
459459
py::ssize_t orthog_nelems,
460460
py::ssize_t masked_nelems,
461461
char *dst_p,
@@ -549,7 +549,7 @@ struct MaskPlaceSomeSlicesStridedFactoryForInt64
549549
template <typename T1, typename T2> class non_zero_indexes_krn;
550550

551551
typedef sycl::event (*non_zero_indexes_fn_ptr_t)(
552-
sycl::queue,
552+
sycl::queue &,
553553
py::ssize_t,
554554
py::ssize_t,
555555
int,
@@ -559,7 +559,7 @@ typedef sycl::event (*non_zero_indexes_fn_ptr_t)(
559559
std::vector<sycl::event> const &);
560560

561561
template <typename indT1, typename indT2>
562-
sycl::event non_zero_indexes_impl(sycl::queue exec_q,
562+
sycl::event non_zero_indexes_impl(sycl::queue &exec_q,
563563
py::ssize_t iter_size,
564564
py::ssize_t nz_elems,
565565
int nd,

‎dpctl/tensor/libtensor/include/kernels/boolean_reductions.hpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ struct ContigBooleanReduction
244244
};
245245

246246
typedef sycl::event (*boolean_reduction_contig_impl_fn_ptr)(
247-
sycl::queue,
247+
sycl::queue &,
248248
size_t,
249249
size_t,
250250
const char *,
@@ -264,7 +264,7 @@ using dpctl::tensor::sycl_utils::choose_workgroup_size;
264264

265265
template <typename argTy, typename resTy, typename RedOpT, typename GroupOpT>
266266
sycl::event
267-
boolean_reduction_axis1_contig_impl(sycl::queue exec_q,
267+
boolean_reduction_axis1_contig_impl(sycl::queue &exec_q,
268268
size_t iter_nelems,
269269
size_t reduction_nelems,
270270
const char *arg_cp,
@@ -463,7 +463,7 @@ class boolean_reduction_axis0_contig_krn;
463463

464464
template <typename argTy, typename resTy, typename RedOpT, typename GroupOpT>
465465
sycl::event
466-
boolean_reduction_axis0_contig_impl(sycl::queue exec_q,
466+
boolean_reduction_axis0_contig_impl(sycl::queue &exec_q,
467467
size_t iter_nelems,
468468
size_t reduction_nelems,
469469
const char *arg_cp,
@@ -572,7 +572,7 @@ template <typename T1, typename T2, typename T3, typename T4, typename T5>
572572
class boolean_reduction_seq_strided_krn;
573573

574574
typedef sycl::event (*boolean_reduction_strided_impl_fn_ptr)(
575-
sycl::queue,
575+
sycl::queue &,
576576
size_t,
577577
size_t,
578578
const char *,
@@ -588,7 +588,7 @@ typedef sycl::event (*boolean_reduction_strided_impl_fn_ptr)(
588588

589589
template <typename argTy, typename resTy, typename RedOpT, typename GroupOpT>
590590
sycl::event
591-
boolean_reduction_strided_impl(sycl::queue exec_q,
591+
boolean_reduction_strided_impl(sycl::queue &exec_q,
592592
size_t iter_nelems,
593593
size_t reduction_nelems,
594594
const char *arg_cp,

‎dpctl/tensor/libtensor/include/kernels/constructors.hpp‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ template <> inline sycl::half unbox_py_scalar<sycl::half>(const py::object &o)
7272
// start and step data
7373

7474
typedef sycl::event (*lin_space_step_fn_ptr_t)(
75-
sycl::queue,
75+
sycl::queue &,
7676
size_t, // num_elements
7777
const py::object &start,
7878
const py::object &step,
@@ -124,7 +124,7 @@ template <typename Ty> class LinearSequenceStepFunctor
124124
* @defgroup CtorKernels
125125
*/
126126
template <typename Ty>
127-
sycl::event lin_space_step_impl(sycl::queue exec_q,
127+
sycl::event lin_space_step_impl(sycl::queue &exec_q,
128128
size_t nelems,
129129
Ty start_v,
130130
Ty step_v,
@@ -162,7 +162,7 @@ sycl::event lin_space_step_impl(sycl::queue exec_q,
162162
* @defgroup CtorKernels
163163
*/
164164
template <typename Ty>
165-
sycl::event lin_space_step_impl(sycl::queue exec_q,
165+
sycl::event lin_space_step_impl(sycl::queue &exec_q,
166166
size_t nelems,
167167
const py::object &start,
168168
const py::object &step,
@@ -202,7 +202,7 @@ template <typename fnT, typename Ty> struct LinSpaceStepFactory
202202
// start and and data
203203

204204
typedef sycl::event (*lin_space_affine_fn_ptr_t)(
205-
sycl::queue,
205+
sycl::queue &,
206206
size_t, // num_elements
207207
const py::object &start,
208208
const py::object &end,
@@ -280,7 +280,7 @@ template <typename Ty, typename wTy> class LinearSequenceAffineFunctor
280280
* @defgroup CtorKernels
281281
*/
282282
template <typename Ty>
283-
sycl::event lin_space_affine_impl(sycl::queue exec_q,
283+
sycl::event lin_space_affine_impl(sycl::queue &exec_q,
284284
size_t nelems,
285285
Ty start_v,
286286
Ty end_v,
@@ -333,7 +333,7 @@ sycl::event lin_space_affine_impl(sycl::queue exec_q,
333333
* @defgroup CtorKernels
334334
*/
335335
template <typename Ty>
336-
sycl::event lin_space_affine_impl(sycl::queue exec_q,
336+
sycl::event lin_space_affine_impl(sycl::queue &exec_q,
337337
size_t nelems,
338338
const py::object &start,
339339
const py::object &end,
@@ -370,7 +370,7 @@ template <typename fnT, typename Ty> struct LinSpaceAffineFactory
370370

371371
/* ================ Full ================== */
372372

373-
typedef sycl::event (*full_contig_fn_ptr_t)(sycl::queue,
373+
typedef sycl::event (*full_contig_fn_ptr_t)(sycl::queue &,
374374
size_t,
375375
const py::object &,
376376
char *,
@@ -392,7 +392,7 @@ typedef sycl::event (*full_contig_fn_ptr_t)(sycl::queue,
392392
* @defgroup CtorKernels
393393
*/
394394
template <typename dstTy>
395-
sycl::event full_contig_impl(sycl::queue q,
395+
sycl::event full_contig_impl(sycl::queue &q,
396396
size_t nelems,
397397
dstTy fill_v,
398398
char *dst_p,
@@ -425,7 +425,7 @@ sycl::event full_contig_impl(sycl::queue q,
425425
* @defgroup CtorKernels
426426
*/
427427
template <typename dstTy>
428-
sycl::event full_contig_impl(sycl::queue exec_q,
428+
sycl::event full_contig_impl(sycl::queue &exec_q,
429429
size_t nelems,
430430
const py::object &py_value,
431431
char *dst_p,
@@ -455,7 +455,7 @@ template <typename fnT, typename Ty> struct FullContigFactory
455455

456456
/* ================ Eye ================== */
457457

458-
typedef sycl::event (*eye_fn_ptr_t)(sycl::queue,
458+
typedef sycl::event (*eye_fn_ptr_t)(sycl::queue &,
459459
size_t nelems, // num_elements
460460
py::ssize_t start,
461461
py::ssize_t end,
@@ -509,7 +509,7 @@ template <typename Ty> class EyeFunctor
509509
* @defgroup CtorKernels
510510
*/
511511
template <typename Ty>
512-
sycl::event eye_impl(sycl::queue exec_q,
512+
sycl::event eye_impl(sycl::queue &exec_q,
513513
size_t nelems,
514514
const py::ssize_t start,
515515
const py::ssize_t end,
@@ -544,7 +544,7 @@ template <typename fnT, typename Ty> struct EyeFactory
544544
/* =========================== Tril and triu ============================== */
545545

546546
// define function type
547-
typedef sycl::event (*tri_fn_ptr_t)(sycl::queue,
547+
typedef sycl::event (*tri_fn_ptr_t)(sycl::queue &,
548548
py::ssize_t, // inner_range //py::ssize_t
549549
py::ssize_t, // outer_range
550550
char *, // src_data_ptr
@@ -579,7 +579,7 @@ typedef sycl::event (*tri_fn_ptr_t)(sycl::queue,
579579
*/
580580
template <typename Ty, bool> class tri_kernel;
581581
template <typename Ty, bool upper>
582-
sycl::event tri_impl(sycl::queue exec_q,
582+
sycl::event tri_impl(sycl::queue &exec_q,
583583
py::ssize_t inner_range,
584584
py::ssize_t outer_range,
585585
char *src_p,

0 commit comments

Comments
 (0)