add mutation tests

Author: IonBazan

.github/workflows/test.yml

@@ -49,3 +49,11 @@ jobs:
         run: vendor/bin/simple-phpunit --coverage-clover coverage.xml
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v1
+      - name: Run mutation tests
+        if: ${{ matrix.php-versions == 7.4 && matrix.operating-system == 'ubuntu-latest' }}
+        env:
+          STRYKER_DASHBOARD_API_KEY: ${{ secrets.STRYKER_DASHBOARD_API_KEY }}
+        run: |
+          composer req infection/infection
+          vendor/bin/infection --ignore-msi-with-no-mutations --min-covered-msi=100 --min-msi=100 -s -j4
+

.gitignore

@@ -7,3 +7,5 @@
 /coverage/
 /clover.xml
 /.phpunit.result.cache
+/infection.log
+/infection.json

README.md

@@ -4,6 +4,7 @@
 [![GitHub Workflow Status](https://img.shields.io/github/workflow/status/IonBazan/composer-diff/Tests)](https://github.com/IonBazan/composer-diff/actions)
 [![PHP version](https://img.shields.io/packagist/php-v/ion-bazan/composer-diff.svg)](https://packagist.org/packages/ion-bazan/composer-diff)
 [![Codecov](https://img.shields.io/codecov/c/gh/IonBazan/composer-diff)](https://codecov.io/gh/IonBazan/composer-diff)
+[![Mutation testing badge](https://img.shields.io/endpoint?style=flat&url=https%3A%2F%2Fbadge-api.stryker-mutator.io%2Fgithub.com%2FIonBazan%2Fcomposer-diff%2Fmaster)](https://dashboard.stryker-mutator.io/reports/github.com/IonBazan/composer-diff/master)
 [![Downloads](https://img.shields.io/packagist/dt/ion-bazan/composer-diff.svg)](https://packagist.org/packages/ion-bazan/composer-diff)
 [![License](https://img.shields.io/packagist/l/ion-bazan/composer-diff.svg)](https://packagist.org/packages/ion-bazan/composer-diff)
 

composer.json

@@ -34,9 +34,6 @@
         "symfony/console": "To use the binary without composer runtime"
     },
     "config": {
-        "platform": {
-            "php": "5.3.9"
-        },
         "platform-check": false
     },
     "extra": {

infection.json.dist

@@ -0,0 +1,16 @@
+{
+    "source": {
+        "directories": [
+            "src"
+        ]
+    },
+    "logs": {
+        "text": "infection.log",
+        "badge": {
+            "branch": "master"
+        }
+    },
+    "mutators": {
+        "@default": true
+    }
+}

src/Formatter/Helper/MarkdownTable.php

@@ -29,7 +29,7 @@ public function __construct(OutputInterface $output)
 
     public function setHeaders(array $headers)
     {
-        $this->headers = array_values($headers);
+        $this->headers = $headers;
 
         return $this;
     }
@@ -39,7 +39,7 @@ public function setRows(array $rows)
         $this->rows = array();
 
         foreach ($rows as $row) {
-            $this->rows[] = array_values($row);
+            $this->rows[] = $row;
         }
 
         return $this;

src/Formatter/MarkdownListFormatter.php

@@ -43,7 +43,7 @@ public function render(array $operations, $title)
     /**
      * @return string
      */
-    protected function getRow(OperationInterface $operation)
+    private function getRow(OperationInterface $operation)
     {
         if ($operation instanceof InstallOperation) {
             return sprintf(

src/Formatter/MarkdownTableFormatter.php

@@ -41,7 +41,7 @@ public function render(array $operations, $title)
         $this->output->writeln('');
     }
 
-    protected function getTableRow(OperationInterface $operation)
+    private function getTableRow(OperationInterface $operation)
     {
         if ($operation instanceof InstallOperation) {
             return array(

src/PackageDiff.php

@@ -22,7 +22,7 @@ class PackageDiff
      *
      * @return OperationInterface[]
      */
-    public function getPackageDiff($from, $to, $dev = false, $withPlatform = true)
+    public function getPackageDiff($from, $to, $dev, $withPlatform)
     {
         $oldPackages = $this->loadPackages($from, $dev, $withPlatform);
         $targetPackages = $this->loadPackages($to, $dev, $withPlatform);
@@ -57,7 +57,7 @@ public function getPackageDiff($from, $to, $dev = false, $withPlatform = true)
      *
      * @return ArrayRepository
      */
-    private function loadPackages($path, $dev, $withPlatform = true)
+    private function loadPackages($path, $dev, $withPlatform)
     {
         $data = \json_decode($this->getFileContents($path), true);
         $loader = new ArrayLoader();
@@ -91,15 +91,15 @@ private function getFileContents($path)
         }
 
         if (filter_var($path, FILTER_VALIDATE_URL, FILTER_FLAG_PATH_REQUIRED) || file_exists($path)) {
-            return (string) file_get_contents($path);
+            return file_get_contents($path);
         }
 
         if (false === strpos($originalPath, ':')) {
             $path .= ':'.self::LOCKFILE;
         }
 
         $output = array();
-        @exec('git show '.escapeshellarg($path), $output, $exit);
+        @exec(sprintf('git show %s 2>&1', escapeshellarg($path)), $output, $exit);
 
         if (0 !== $exit) {
             throw new \RuntimeException(sprintf('Could not open file %s or find it in git as %s', $originalPath, $path));

tests/PackageDiffTest.php

@@ -64,7 +64,7 @@ public function testInvalidGitRef()
         $diff = new PackageDiff();
         $this->prepareGit();
         $this->setExpectedException('RuntimeException');
-        $diff->getPackageDiff('invalid-ref', '');
+        $diff->getPackageDiff('invalid-ref', '', true, true);
     }
 
     public function operationsProvider()