Enable some float construction tests (#971)

* Enable some float construction tests

* Update after review

Author: BCSharp

Src/IronPython/Runtime/LiteralParser.cs

@@ -617,7 +617,7 @@ public static double ParseFloat(string text) {
         }
 
         private static double ParseFloatNoCatch(string text) {
-            string s = ReplaceUnicodeDigits(text);
+            string s = ReplaceUnicodeCharacters(text);
             switch (s.ToLowerAsciiTriggered().lstrip()) {
                 case "nan":
                 case "+nan":
@@ -635,12 +635,18 @@ private static double ParseFloatNoCatch(string text) {
             }
         }
 
-        private static string ReplaceUnicodeDigits(string text) {
+        private static string ReplaceUnicodeCharacters(string text) {
             StringBuilder replacement = null;
             for (int i = 0; i < text.Length; i++) {
-                if (text[i] >= '\x660' && text[i] <= '\x669') {
+                char ch = text[i];
+                if (ch >= '\x660' && ch <= '\x669') {
+                    // replace unicode digits
                     if (replacement == null) replacement = new StringBuilder(text);
-                    replacement[i] = (char)(text[i] - '\x660' + '0');
+                    replacement[i] = (char)(ch - '\x660' + '0');
+                } else if (ch >= '\x80' && char.IsWhiteSpace(ch)) {
+                    // replace unicode whitespace
+                    if (replacement == null) replacement = new StringBuilder(text);
+                    replacement[i] = ' ';
                 }
             }
             if (replacement != null) {

Src/IronPython/Runtime/Operations/FloatOps.cs

@@ -354,7 +354,7 @@ private static double ParseFloat(string x) {
                 }
                 return LiteralParser.ParseFloat(x);
             } catch (FormatException) {
-                throw PythonOps.ValueError("invalid literal for float(): {0}", x);
+                throw PythonOps.ValueError("could not convert string to float: '{0}'", x);
             }
         }
 

Src/StdLib/Lib/test/test_float.py

@@ -51,7 +51,10 @@ def test_float(self):
         self.assertRaises(TypeError, float, {})
         self.assertRaisesRegex(TypeError, "not 'dict'", float, {})
         # Lone surrogate
-        self.assertRaises(UnicodeEncodeError, float, '\uD8F0')
+        if sys.version_info >= (3,7) or sys.implementation.name == 'ironpython':
+            self.assertRaises(ValueError, float, '\uD8F0')
+        else:
+            self.assertRaises(UnicodeEncodeError, float, '\uD8F0')
         # check that we don't accept alternate exponent markers
         self.assertRaises(ValueError, float, "-1.7d29")
         self.assertRaises(ValueError, float, "3D-14")

Tests/test_float_stdlib.py

@@ -22,7 +22,7 @@ def load_tests(loader, standard_tests, pattern):
         #suite.addTest(test.test_float.FormatTestCase('test_format_testfile'))
         #suite.addTest(test.test_float.FormatTestCase('test_issue5864'))
         suite.addTest(test.test_float.GeneralFloatCases('test_error_message'))
-        #suite.addTest(test.test_float.GeneralFloatCases('test_float'))
+        suite.addTest(test.test_float.GeneralFloatCases('test_float'))
         suite.addTest(test.test_float.GeneralFloatCases('test_float_containment'))
         suite.addTest(test.test_float.GeneralFloatCases('test_float_memoryview'))
         suite.addTest(test.test_float.GeneralFloatCases('test_float_mod'))
@@ -31,7 +31,7 @@ def load_tests(loader, standard_tests, pattern):
         suite.addTest(test.test_float.GeneralFloatCases('test_floatasratio'))
         suite.addTest(test.test_float.GeneralFloatCases('test_floatconversion'))
         suite.addTest(test.test_float.GeneralFloatCases('test_is_integer'))
-        #suite.addTest(test.test_float.GeneralFloatCases('test_non_numeric_input_types'))
+        suite.addTest(test.test_float.GeneralFloatCases('test_non_numeric_input_types'))
         suite.addTest(test.test_float.HexFloatTestCase('test_ends'))
         suite.addTest(test.test_float.HexFloatTestCase('test_from_hex'))
         suite.addTest(test.test_float.HexFloatTestCase('test_invalid_inputs'))