Skip to content

Commit c8b4ab5

Browse files
authored
Merge pull request #33 from IvanMurzak/32-build-is-getting-failed-after-the-last-update
Compilation error fix in player build
2 parents 3a56ede + 7078a47 commit c8b4ab5

File tree

7 files changed

+28
-17
lines changed

7 files changed

+28
-17
lines changed

Assets/_PackageRoot/Tests/Base/Extensions.Unity.ImageLoader.Tests.asmdef

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,14 @@
88
"includePlatforms": [],
99
"excludePlatforms": [],
1010
"allowUnsafeCode": false,
11-
"overrideReferences": false,
11+
"overrideReferences": true,
1212
"precompiledReferences": [
13-
"NSubstitute.dll"
13+
"nunit.framework.dll"
14+
],
15+
"autoReferenced": false,
16+
"defineConstraints": [
17+
"UNITY_INCLUDE_TESTS"
1418
],
15-
"autoReferenced": true,
16-
"defineConstraints": [],
1719
"versionDefines": [],
1820
"noEngineReferences": false
1921
}

Assets/_PackageRoot/Tests/Base/Utils/TestUtils.LoadFail.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,10 @@ public static IEnumerator LoadFail(string url, FutureLoadingFrom? expectedLoadin
2828
futureListener.Assert_Events_Contains(expectedLoadingFrom.Value.ToEventName());
2929

3030
var task1 = future.AsTask();
31+
3132
if (expectedLoadingFrom.HasValue && expectedLoadingFrom.Value == FutureLoadingFrom.Source) // exception should be thrown only if ONLY loading from Source
32-
LogAssert.Expect(LogType.Error, $"[ImageLoader] Future[id={future.Id}] Timeout ({timeout}): {url}");
33+
LogAssert.Expect(LogType.Error, $"[ImageLoader] Future[id={future.Id}] Timeout ({timeout}): {url}"); // compilation error in player build
34+
3335
yield return TestUtils.WaitWhile(() => future.IsInProgress, TimeSpan.FromSeconds(10));
3436
var task2 = future.AsTask();
3537

Assets/_PackageRoot/Tests/Base/Utils/TestUtils.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,17 @@ public static IEnumerator ClearEverything(string message)
3232
{
3333
if (message != null)
3434
Debug.Log(message.PadRight(50, '-'));
35-
LogAssert.ignoreFailingMessages = true;
35+
36+
LogAssert.ignoreFailingMessages = true; // compilation error in player build
37+
3638
UniTaskScheduler.UnobservedExceptionWriteLogType = LogType.Exception;
3739
ImageLoader.ClearSpriteRef();
3840
ImageLoader.ClearTextureRef();
3941
yield return ImageLoader.ClearCacheAll().TimeoutCoroutine(TimeSpan.FromSeconds(10));
4042

4143
WaitForGCFast();
42-
LogAssert.ignoreFailingMessages = false;
44+
45+
LogAssert.ignoreFailingMessages = false; // compilation error in player build
4346
}
4447
public static void WaitForGCFast()
4548
{

Assets/_PackageRoot/Tests/Editor/Extensions.Unity.ImageLoader.Tests.Editor.asmdef

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,14 @@
1212
],
1313
"excludePlatforms": [],
1414
"allowUnsafeCode": false,
15-
"overrideReferences": false,
15+
"overrideReferences": true,
1616
"precompiledReferences": [
17-
"NSubstitute.dll"
17+
"nunit.framework.dll"
18+
],
19+
"autoReferenced": false,
20+
"defineConstraints": [
21+
"UNITY_INCLUDE_TESTS"
1822
],
19-
"autoReferenced": true,
20-
"defineConstraints": [],
2123
"versionDefines": [],
2224
"noEngineReferences": false
2325
}

Assets/_PackageRoot/Tests/Runtime/Extensions.Unity.ImageLoader.Tests.Runtime.asmdef

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,14 @@
99
"includePlatforms": [],
1010
"excludePlatforms": [],
1111
"allowUnsafeCode": false,
12-
"overrideReferences": false,
12+
"overrideReferences": true,
1313
"precompiledReferences": [
14-
"NSubstitute.dll"
14+
"nunit.framework.dll"
15+
],
16+
"autoReferenced": false,
17+
"defineConstraints": [
18+
"UNITY_INCLUDE_TESTS"
1519
],
16-
"autoReferenced": true,
17-
"defineConstraints": [],
1820
"versionDefines": [],
1921
"noEngineReferences": false
2022
}

Assets/_PackageRoot/Tests/Runtime/TestConcurrency.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
using System.Collections;
44
using NUnit.Framework;
55
using Cysharp.Threading.Tasks;
6-
using UnityEngine.TestTools;
76
using UnityEngine;
87
using System.Threading.Tasks;
98
using Extensions.Unity.ImageLoader.Tests.Utils;
9+
using UnityEngine.TestTools;
1010

1111
namespace Extensions.Unity.ImageLoader.Tests
1212
{

Assets/_PackageRoot/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"url": "https://github.com/IvanMurzak"
88
},
99
"license": "MIT",
10-
"version": "7.0.0",
10+
"version": "7.0.1",
1111
"unity": "2019.4",
1212
"description": "Asynchronous image loading from remote or local destination. It has two layers of configurable Memory and Disk cache systems.",
1313
"keywords": [

0 commit comments

Comments
 (0)