checkstyle source check included. configuration done

Author: wumpz

pom.xml

@@ -374,9 +374,7 @@
 						<configuration>
 							<logViolationsToConsole>true</logViolationsToConsole>
 							<includeTestSourceDirectory>true</includeTestSourceDirectory>
-							<sourceDirectories>
-								<sourceDirectory>./src/java</sourceDirectory>
-							</sourceDirectories>
+                            <sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
 							<checkstyleRules>
 								<module name="Checker">
 									<module name="FileTabCharacter" />
@@ -387,10 +385,21 @@
 									</module>
 									-->
 									<module name="TreeWalker">
+                                        <module name="AvoidNestedBlocks"/>
 										<module name="ConstantName" />
+                                        <module name="EmptyCatchBlock" />
 										<module name="EmptyStatement" />
+                                        <module name="MissingOverride"/>
+                                        <module name="MultipleVariableDeclarations"/>
+                                        <module name="ParameterAssignment"/>
+                                        <module name="StringLiteralEquality"/>
+                                        <module name="RedundantImport"/>
+                                        <module name="UnusedImports"/>
+                                        
 										<module name="NeedBraces" />
 										<module name="UnnecessaryParentheses" />
+                                        <module name="LeftCurly"/>
+                                        <module name="RightCurly"/>
 									</module>
 								</module>
 							</checkstyleRules>

src/main/java/net/sf/jsqlparser/statement/select/PlainSelect.java

@@ -443,7 +443,7 @@ public static String getStringList(List<?> list, boolean useComma, boolean useBr
             }
 
             for (int i = 0; i < list.size(); i++) {
-                ans.append(list.get(i)).append(((i < list.size() - 1) ? comma + " " : ""));
+                ans.append(list.get(i)).append((i < list.size() - 1) ? comma + " " : "");
 //                ans += "" + list.get(i) + ((i < list.size() - 1) ? comma + " " : "");
             }
 

src/test/java/net/sf/jsqlparser/expression/LongValueTest.java

@@ -70,7 +70,7 @@ public void testLargeNumber() {
             value.getValue();
             fail("should not work");
         } catch (Exception e) {
-
+            //expected to fail
         }
         assertEquals(new BigInteger(largeNumber), value.getBigIntegerValue());
     }

src/test/java/net/sf/jsqlparser/test/merge/MergeTest.java

@@ -167,7 +167,7 @@ public void testMergeUpdateInsertOrderIssue401_3() throws JSQLParserException {
             assertSqlCanBeParsedAndDeparsed("MERGE INTO a USING dual ON (col3 = ? AND col1 = ? AND col2 = ?) WHEN MATCHED THEN UPDATE SET col4 = col4 + ? WHEN NOT MATCHED THEN INSERT (col1, col2, col3, col4) VALUES (?, ?, ?, ?) WHEN MATCHED THEN UPDATE SET col4 = col4 + ?");
             fail("syntaxerror parsed");
         } catch (JSQLParserException ex) {
-
+            //expected to fail
         }
     }
 }

src/test/java/net/sf/jsqlparser/test/select/SelectTest.java

@@ -825,6 +825,7 @@ public void testDistinctTop2() {
             parserManager.parse(new StringReader(statement));
             fail("sould not work");
         } catch (JSQLParserException ex) {
+            //expected to fail
         }
     }
 
@@ -2418,7 +2419,7 @@ public void testWhereIssue240_notBoolean() {
             CCJSqlParserUtil.parse("SELECT count(*) FROM mytable WHERE 5");
             fail("should not be parsed");
         } catch (JSQLParserException ex) {
-
+            //expected to fail
         }
     }