more sonar issues corrected

Author: wumpz

src/main/java/net/sf/jsqlparser/expression/AnalyticExpression.java

@@ -89,6 +89,24 @@ public String toString() {
 			b.append("*");
 		}
 		b.append(") OVER (");
+		
+		toStringPartitionBy(b);
+		toStringOrderByElements(b);
+
+		b.append(")");
+
+		return b.toString();
+	}
+
+	public boolean isAllColumns() {
+		return allColumns;
+	}
+
+	public void setAllColumns(boolean allColumns) {
+		this.allColumns = allColumns;
+	}
+
+	private void toStringPartitionBy(StringBuilder b) {
 		if (partitionByColumns != null && !partitionByColumns.isEmpty()) {
 			b.append("PARTITION BY ");
 			for (int i = 0; i < partitionByColumns.size(); i++) {
@@ -99,7 +117,9 @@ public String toString() {
 			}
 			b.append(" ");
 		}
+	}
 
+	private void toStringOrderByElements(StringBuilder b) {
 		if (orderByElements != null && !orderByElements.isEmpty()) {
 			b.append("ORDER BY ");
 			for (int i = 0; i < orderByElements.size(); i++) {
@@ -109,17 +129,5 @@ public String toString() {
 				b.append(orderByElements.get(i).toString());
 			}
 		}
-
-		b.append(")");
-
-		return b.toString();
-	}
-
-	public boolean isAllColumns() {
-		return allColumns;
-	}
-
-	public void setAllColumns(boolean allColumns) {
-		this.allColumns = allColumns;
 	}
 }

src/main/java/net/sf/jsqlparser/expression/operators/relational/MultiExpressionList.java

@@ -51,10 +51,9 @@ public List<ExpressionList> getExprList() {
 	}
 
 	public void addExpressionList(ExpressionList el) {
-		if (!exprList.isEmpty()) {
-			if (exprList.get(0).getExpressions().size() != el.getExpressions().size()) {
-				throw new IllegalArgumentException("different count of parameters");
-			}
+		if (!exprList.isEmpty()
+				&& exprList.get(0).getExpressions().size() != el.getExpressions().size()) {
+			throw new IllegalArgumentException("different count of parameters");
 		}
 		exprList.add(el);
 	}

src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java

@@ -227,10 +227,9 @@ public void visit(PlainSelect plainSelect) {
 	@Override
 	public void visit(Table tableName) {
 		String tableWholeName = tableName.getWholeTableName();
-		if (!otherItemNames.contains(tableWholeName.toLowerCase())) {
-			if (!tables.contains(tableWholeName)) {
-				tables.add(tableWholeName);
-			}
+		if (!otherItemNames.contains(tableWholeName.toLowerCase())
+				&& !tables.contains(tableWholeName)) {
+			tables.add(tableWholeName);
 		}
 	}