Skip to content

Commit c7a8601

Browse files
committed
introduced some more checkstyle rules
1 parent e2cc221 commit c7a8601

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

pom.xml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@
375375
<logViolationsToConsole>true</logViolationsToConsole>
376376
<includeTestSourceDirectory>true</includeTestSourceDirectory>
377377
<sourceDirectories>
378-
<sourceDirectory>src</sourceDirectory>
378+
<sourceDirectory>./src/java</sourceDirectory>
379379
</sourceDirectories>
380380
<checkstyleRules>
381381
<module name="Checker">
@@ -384,9 +384,21 @@
384384
<property name="format" value="(?s:(\r\n|\r).*)"/>
385385
<property name="message" value="CRLF and CR line endings are prohibited, but this file uses them."/>
386386
</module>
387+
<module name="TreeWalker">
388+
<module name="ConstantName" />
389+
<module name="EmptyStatement" />
390+
<module name="NeedBraces" />
391+
</module>
387392
</module>
388393
</checkstyleRules>
389394
</configuration>
395+
<dependencies>
396+
<dependency>
397+
<groupId>com.puppycrawl.tools</groupId>
398+
<artifactId>checkstyle</artifactId>
399+
<version>7.6.1</version>
400+
</dependency>
401+
</dependencies>
390402
</plugin>
391403
</plugins>
392404
</build>

src/test/java/net/sf/jsqlparser/test/replace/ReplaceTest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@
1818

1919
public class ReplaceTest {
2020

21-
private static final CCJSqlParserManager parserManager = new CCJSqlParserManager();
21+
private static final CCJSqlParserManager PARSER_MANAGER = new CCJSqlParserManager();
2222

2323
@Test
2424
public void testReplaceSyntax1() throws JSQLParserException {
2525
String statement = "REPLACE mytable SET col1='as', col2=?, col3=565";
26-
Replace replace = (Replace) parserManager.parse(new StringReader(statement));
26+
Replace replace = (Replace) PARSER_MANAGER.parse(new StringReader(statement));
2727
assertEquals("mytable", replace.getTable().getName());
2828
assertEquals(3, replace.getColumns().size());
2929
assertEquals("col1", ((Column) replace.getColumns().get(0)).getColumnName());
@@ -39,7 +39,7 @@ public void testReplaceSyntax1() throws JSQLParserException {
3939
@Test
4040
public void testReplaceSyntax2() throws JSQLParserException {
4141
String statement = "REPLACE mytable (col1, col2, col3) VALUES ('as', ?, 565)";
42-
Replace replace = (Replace) parserManager.parse(new StringReader(statement));
42+
Replace replace = (Replace) PARSER_MANAGER.parse(new StringReader(statement));
4343
assertEquals("mytable", replace.getTable().getName());
4444
assertEquals(3, replace.getColumns().size());
4545
assertEquals("col1", ((Column) replace.getColumns().get(0)).getColumnName());
@@ -56,15 +56,13 @@ public void testReplaceSyntax2() throws JSQLParserException {
5656
@Test
5757
public void testReplaceSyntax3() throws JSQLParserException {
5858
String statement = "REPLACE mytable (col1, col2, col3) SELECT * FROM mytable3";
59-
Replace replace = (Replace) parserManager.parse(new StringReader(statement));
59+
Replace replace = (Replace) PARSER_MANAGER.parse(new StringReader(statement));
6060
assertEquals("mytable", replace.getTable().getName());
6161
assertEquals(3, replace.getColumns().size());
6262
assertEquals("col1", ((Column) replace.getColumns().get(0)).getColumnName());
6363
assertEquals("col2", ((Column) replace.getColumns().get(1)).getColumnName());
6464
assertEquals("col3", ((Column) replace.getColumns().get(2)).getColumnName());
6565
assertTrue(replace.getItemsList() instanceof SubSelect);
66-
// TODO:
67-
// assertEquals(statement, ""+replace);
6866
}
6967

7068
@Test

0 commit comments

Comments
 (0)