- corrected TableNamesFinder to work properly on update statements

Author: wumpz

src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java

@@ -185,6 +185,17 @@ public List<String> getTableList(Update update) {
 				expression.accept(this);
 			}
 		}
+
+		if (update.getFromItem() != null) {
+			update.getFromItem().accept(this);
+		}
+
+		if (update.getJoins() != null) {
+			for (Join join : update.getJoins()) {
+				join.getRightItem().accept(this);
+			}
+		}
+
 		if (update.getWhere() != null) {
 			update.getWhere().accept(this);
 		}
@@ -217,7 +228,9 @@ public void visit(PlainSelect plainSelect) {
 	public void visit(Table tableName) {
 		String tableWholeName = tableName.getWholeTableName();
 		if (!otherItemNames.contains(tableWholeName.toLowerCase())) {
-			tables.add(tableWholeName);
+			if (!tables.contains(tableWholeName)) {
+				tables.add(tableWholeName);
+			}
 		}
 	}
 

src/test/java/net/sf/jsqlparser/util/TablesNamesFinderTest.java

@@ -235,6 +235,19 @@ public void testGetTableListFromUpdate2() throws Exception {
 		assertTrue(tableList.contains("MY_TABLE1"));
 		assertTrue(tableList.contains("MY_TABLE3"));
 	}
+	
+	public void testGetTableListFromUpdate3() throws Exception {
+		String sql = "UPDATE MY_TABLE1 SET a = 5 FROM MY_TABLE1 INNER JOIN MY_TABLE2 on MY_TABLE1.C = MY_TABLE2.D WHERE 0 < (SELECT COUNT(b) FROM MY_TABLE3)";
+		net.sf.jsqlparser.statement.Statement statement = pm.parse(new StringReader(sql));
+
+		Update updateStatement = (Update) statement;
+		TablesNamesFinder tablesNamesFinder = new TablesNamesFinder();
+		List<String> tableList = tablesNamesFinder.getTableList(updateStatement);
+		assertEquals(3, tableList.size());
+		assertTrue(tableList.contains("MY_TABLE1"));
+		assertTrue(tableList.contains("MY_TABLE2"));
+		assertTrue(tableList.contains("MY_TABLE3"));
+	}
 
 	private String getLine(BufferedReader in) throws Exception {
 		return CCJSqlParserManagerTest.getLine(in);