Use of StringBuilders instead of StringBuffers

Author: Florent Bécart

src/net/sf/jsqlparser/expression/StringValue.java

@@ -38,7 +38,7 @@ public String getValue() {
 	}
 
 	public String getNotExcapedValue() {
-		StringBuffer buffer = new StringBuffer(value);
+		StringBuilder buffer = new StringBuilder(value);
 		int index = 0;
 		int deletesNum = 0;
 		while ((index = value.indexOf("''", index)) != -1) {

src/net/sf/jsqlparser/parser/JSqlParserCC.jj

@@ -1670,7 +1670,7 @@ String CreateParameter():
 
 String AList():
 {
-	StringBuffer retval = new StringBuffer("(");
+	StringBuilder retval = new StringBuilder("(");
 	Token tk = null;
 }
 {

src/net/sf/jsqlparser/statement/select/Select.java

@@ -45,7 +45,7 @@ public void setSelectBody(SelectBody body) {
 	}
 
 	public String toString() {
-		StringBuffer retval = new StringBuffer();
+		StringBuilder retval = new StringBuilder();
 		if (withItemsList != null && !withItemsList.isEmpty()) {
 			retval.append("WITH ");
 			for (Iterator<WithItem> iter = withItemsList.iterator(); iter.hasNext();) {

src/net/sf/jsqlparser/util/deparser/CreateTableDeParser.java

@@ -11,13 +11,13 @@
  * {@link net.sf.jsqlparser.statement.create.table.CreateTable}
  */
 public class CreateTableDeParser {
-	protected StringBuffer buffer;
+	protected StringBuilder buffer;
 
 	/**
 	 * @param buffer
 	 *            the buffer that will be filled with the select
 	 */
-	public CreateTableDeParser(StringBuffer buffer) {
+	public CreateTableDeParser(StringBuilder buffer) {
 		this.buffer = buffer;
 	}
 
@@ -70,11 +70,11 @@ public void deParse(CreateTable createTable) {
 		}
 	}
 
-	public StringBuffer getBuffer() {
+	public StringBuilder getBuffer() {
 		return buffer;
 	}
 
-	public void setBuffer(StringBuffer buffer) {
+	public void setBuffer(StringBuilder buffer) {
 		this.buffer = buffer;
 	}
 

src/net/sf/jsqlparser/util/deparser/DeleteDeParser.java

@@ -8,7 +8,7 @@
  * {@link net.sf.jsqlparser.statement.delete.Delete}
  */
 public class DeleteDeParser {
-	protected StringBuffer buffer;
+	protected StringBuilder buffer;
 	protected ExpressionVisitor expressionVisitor;
 
 	public DeleteDeParser() {
@@ -17,20 +17,20 @@ public DeleteDeParser() {
 	/**
 	 * @param expressionVisitor
 	 *            a {@link ExpressionVisitor} to de-parse expressions. It has to share the same<br>
-	 *            StringBuffer (buffer parameter) as this object in order to work
+	 *            StringBuilder (buffer parameter) as this object in order to work
 	 * @param buffer
 	 *            the buffer that will be filled with the select
 	 */
-	public DeleteDeParser(ExpressionVisitor expressionVisitor, StringBuffer buffer) {
+	public DeleteDeParser(ExpressionVisitor expressionVisitor, StringBuilder buffer) {
 		this.buffer = buffer;
 		this.expressionVisitor = expressionVisitor;
 	}
 
-	public StringBuffer getBuffer() {
+	public StringBuilder getBuffer() {
 		return buffer;
 	}
 
-	public void setBuffer(StringBuffer buffer) {
+	public void setBuffer(StringBuilder buffer) {
 		this.buffer = buffer;
 	}
 

src/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java

@@ -55,7 +55,7 @@
  */
 public class ExpressionDeParser implements ExpressionVisitor, ItemsListVisitor {
 
-	protected StringBuffer buffer;
+	protected StringBuilder buffer;
 	protected SelectVisitor selectVisitor;
 	protected boolean useBracketsInExprList = true;
 
@@ -65,11 +65,11 @@ public ExpressionDeParser() {
 	/**
 	 * @param selectVisitor
 	 *            a SelectVisitor to de-parse SubSelects. It has to share the same<br>
-	 *            StringBuffer as this object in order to work, as:
+	 *            StringBuilder as this object in order to work, as:
 	 * 
 	 *            <pre>
 	 * <code>
-	 * StringBuffer myBuf = new StringBuffer();
+	 * StringBuilder myBuf = new StringBuilder();
 	 * MySelectDeparser selectDeparser = new  MySelectDeparser();
 	 * selectDeparser.setBuffer(myBuf);
 	 * ExpressionDeParser expressionDeParser = new ExpressionDeParser(selectDeparser, myBuf);
@@ -78,16 +78,16 @@ public ExpressionDeParser() {
 	 * @param buffer
 	 *            the buffer that will be filled with the expression
 	 */
-	public ExpressionDeParser(SelectVisitor selectVisitor, StringBuffer buffer) {
+	public ExpressionDeParser(SelectVisitor selectVisitor, StringBuilder buffer) {
 		this.selectVisitor = selectVisitor;
 		this.buffer = buffer;
 	}
 
-	public StringBuffer getBuffer() {
+	public StringBuilder getBuffer() {
 		return buffer;
 	}
 
-	public void setBuffer(StringBuffer buffer) {
+	public void setBuffer(StringBuilder buffer) {
 		this.buffer = buffer;
 	}
 

src/net/sf/jsqlparser/util/deparser/InsertDeParser.java

@@ -16,7 +16,7 @@
  * {@link net.sf.jsqlparser.statement.insert.Insert}
  */
 public class InsertDeParser implements ItemsListVisitor {
-	protected StringBuffer buffer;
+	protected StringBuilder buffer;
 	protected ExpressionVisitor expressionVisitor;
 	protected SelectVisitor selectVisitor;
 
@@ -27,25 +27,25 @@ public InsertDeParser() {
 	 * @param expressionVisitor
 	 *            a {@link ExpressionVisitor} to de-parse {@link net.sf.jsqlparser.expression.Expression}s. It has to
 	 *            share the same<br>
-	 *            StringBuffer (buffer parameter) as this object in order to work
+	 *            StringBuilder (buffer parameter) as this object in order to work
 	 * @param selectVisitor
 	 *            a {@link SelectVisitor} to de-parse {@link net.sf.jsqlparser.statement.select.Select}s. It has to
 	 *            share the same<br>
-	 *            StringBuffer (buffer parameter) as this object in order to work
+	 *            StringBuilder (buffer parameter) as this object in order to work
 	 * @param buffer
 	 *            the buffer that will be filled with the insert
 	 */
-	public InsertDeParser(ExpressionVisitor expressionVisitor, SelectVisitor selectVisitor, StringBuffer buffer) {
+	public InsertDeParser(ExpressionVisitor expressionVisitor, SelectVisitor selectVisitor, StringBuilder buffer) {
 		this.buffer = buffer;
 		this.expressionVisitor = expressionVisitor;
 		this.selectVisitor = selectVisitor;
 	}
 
-	public StringBuffer getBuffer() {
+	public StringBuilder getBuffer() {
 		return buffer;
 	}
 
-	public void setBuffer(StringBuffer buffer) {
+	public void setBuffer(StringBuilder buffer) {
 		this.buffer = buffer;
 	}
 

src/net/sf/jsqlparser/util/deparser/ReplaceDeParser.java

@@ -16,7 +16,7 @@
  * {@link net.sf.jsqlparser.statement.replace.Replace}
  */
 public class ReplaceDeParser implements ItemsListVisitor {
-	protected StringBuffer buffer;
+	protected StringBuilder buffer;
 	protected ExpressionVisitor expressionVisitor;
 	protected SelectVisitor selectVisitor;
 
@@ -26,25 +26,25 @@ public ReplaceDeParser() {
 	/**
 	 * @param expressionVisitor
 	 *            a {@link ExpressionVisitor} to de-parse expressions. It has to share the same<br>
-	 *            StringBuffer (buffer parameter) as this object in order to work
+	 *            StringBuilder (buffer parameter) as this object in order to work
 	 * @param selectVisitor
 	 *            a {@link SelectVisitor} to de-parse {@link net.sf.jsqlparser.statement.select.Select}s. It has to
 	 *            share the same<br>
-	 *            StringBuffer (buffer parameter) as this object in order to work
+	 *            StringBuilder (buffer parameter) as this object in order to work
 	 * @param buffer
 	 *            the buffer that will be filled with the select
 	 */
-	public ReplaceDeParser(ExpressionVisitor expressionVisitor, SelectVisitor selectVisitor, StringBuffer buffer) {
+	public ReplaceDeParser(ExpressionVisitor expressionVisitor, SelectVisitor selectVisitor, StringBuilder buffer) {
 		this.buffer = buffer;
 		this.expressionVisitor = expressionVisitor;
 		this.selectVisitor = selectVisitor;
 	}
 
-	public StringBuffer getBuffer() {
+	public StringBuilder getBuffer() {
 		return buffer;
 	}
 
-	public void setBuffer(StringBuffer buffer) {
+	public void setBuffer(StringBuilder buffer) {
 		this.buffer = buffer;
 	}
 

src/net/sf/jsqlparser/util/deparser/SelectDeParser.java

@@ -30,7 +30,7 @@
  * {@link net.sf.jsqlparser.statement.select.Select}
  */
 public class SelectDeParser implements SelectVisitor, OrderByVisitor, SelectItemVisitor, FromItemVisitor {
-	protected StringBuffer buffer;
+	protected StringBuilder buffer;
 	protected ExpressionVisitor expressionVisitor;
 
 	public SelectDeParser() {
@@ -39,11 +39,11 @@ public SelectDeParser() {
 	/**
 	 * @param expressionVisitor
 	 *            a {@link ExpressionVisitor} to de-parse expressions. It has to share the same<br>
-	 *            StringBuffer (buffer parameter) as this object in order to work
+	 *            StringBuilder (buffer parameter) as this object in order to work
 	 * @param buffer
 	 *            the buffer that will be filled with the select
 	 */
-	public SelectDeParser(ExpressionVisitor expressionVisitor, StringBuffer buffer) {
+	public SelectDeParser(ExpressionVisitor expressionVisitor, StringBuilder buffer) {
 		this.buffer = buffer;
 		this.expressionVisitor = expressionVisitor;
 	}
@@ -221,11 +221,11 @@ public void deparseLimit(Limit limit) {
 
 	}
 
-	public StringBuffer getBuffer() {
+	public StringBuilder getBuffer() {
 		return buffer;
 	}
 
-	public void setBuffer(StringBuffer buffer) {
+	public void setBuffer(StringBuilder buffer) {
 		this.buffer = buffer;
 	}
 

src/net/sf/jsqlparser/util/deparser/StatementDeParser.java

@@ -14,9 +14,9 @@
 import net.sf.jsqlparser.statement.update.Update;
 
 public class StatementDeParser implements StatementVisitor {
-	protected StringBuffer buffer;
+	protected StringBuilder buffer;
 
-	public StatementDeParser(StringBuffer buffer) {
+	public StatementDeParser(StringBuilder buffer) {
 		this.buffer = buffer;
 	}
 
@@ -92,11 +92,11 @@ public void visit(Update update) {
 
 	}
 
-	public StringBuffer getBuffer() {
+	public StringBuilder getBuffer() {
 		return buffer;
 	}
 
-	public void setBuffer(StringBuffer buffer) {
+	public void setBuffer(StringBuilder buffer) {
 		this.buffer = buffer;
 	}