Skip to content

Commit 6876292

Browse files
committed
perf (SEO): heading tags
1 parent 0f0d21c commit 6876292

File tree

2 files changed

+61
-29
lines changed

2 files changed

+61
-29
lines changed

index.html

Lines changed: 28 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@
3636
<section id="type" class="visible">
3737

3838
<details>
39-
<summary>Type</summary>
39+
<summary><h2>Type</h2></summary>
4040
<ul>
41-
<li>Must communicate the intention of the change</li>
42-
<li>The essentials are feat and fix</li>
41+
<li><h3>Must communicate the intention of the change</h3></li>
42+
<li><h3>The essentials are feat and fix</h3></li>
4343
</ul>
4444
</details>
4545

@@ -99,10 +99,10 @@
9999
<section id="scope">
100100

101101
<details>
102-
<summary>Scope</summary>
102+
<summary><h2>Scope</h2></summary>
103103
<ul>
104-
<li>It must be something that intuitively specifies the location of the change</li>
105-
<li>It should aim to provide additional contextual information</li>
104+
<li><h3>It must be something that intuitively specifies the location of the change</h3></li>
105+
<li><h3>It should aim to provide additional contextual information</h3></li>
106106
</ul>
107107
</details>
108108

@@ -128,11 +128,12 @@
128128
<section id="summary">
129129

130130
<details>
131-
<summary>Summary</summary>
131+
<summary><h2>Summary</h2></summary>
132132
<ul>
133-
<li>Use the imperative, present: "change" not "changed" nor "changes"</li>
134-
<li>Don't capitalize the first letter</li>
135-
<li>No dot (.) at the end</li>
133+
<li><h3>Use the imperative, present: "change" not "changed" nor "changes"</h3></li>
134+
<li><h3>Don't capitalize the first letter</h3></li>
135+
<li><h3>No dot (.) at the end</h3></li>
136+
<li><h3>Commits must be atomic!</h3></li>
136137
</ul>
137138
</details>
138139

@@ -159,11 +160,11 @@
159160
<section id="body">
160161

161162
<details>
162-
<summary>Body</summary>
163+
<summary><h2>Body</h2></summary>
163164
<ul>
164-
<li>Use the imperative, present: "change" not "changed" nor "changes"</li>
165-
<li>Describe and justify in detail the change</li>
166-
<li>It should include the motivation and, if possible, a comparison with previous behavior</li>
165+
<li><h3>Use the imperative, present: "change" not "changed" nor "changes"</h3></li>
166+
<li><h3>Describe and justify in detail the change</h3></li>
167+
<li><h3>It should include the motivation and, if possible, a comparison with previous behavior</h3></li>
167168
</ul>
168169
</details>
169170

@@ -189,9 +190,9 @@
189190
<section id="footer">
190191

191192
<details>
192-
<summary>Footer</summary>
193+
<summary><h2>Footer</h2></summary>
193194
<ul>
194-
<li>It must contain all necessary references and relevant information about changes that break compatibility, if any</li>
195+
<li><h3>It must contain all necessary references and relevant information about changes that break compatibility, if any</h3></li>
195196
</ul>
196197
</details>
197198

@@ -242,9 +243,9 @@
242243
<section id="significantChange">
243244

244245
<details>
245-
<summary>Significant Change</summary>
246+
<summary><h2>Significant Change</h2></summary>
246247
<ul>
247-
<li>It is possible to inform if the commit makes a significant change or breaks the compatibility, this inserts the identifier "!" after type/scope</li>
248+
<li><h3>It is possible to inform if the commit makes a significant change or breaks the compatibility, this inserts the identifier "!" after type/scope</h3></li>
248249
</ul>
249250
</details>
250251

@@ -271,8 +272,10 @@
271272
<section id="result">
272273

273274
<details>
274-
<summary>Result</summary>
275-
<p>Thank you for using our system</p>
275+
<summary><h2>Result</h2></summary>
276+
<ul>
277+
<li><h3>Commits must be atomic!</h3></li>
278+
</ul>
276279
</details>
277280

278281
<form>
@@ -308,12 +311,14 @@
308311

309312
<footer>
310313

311-
<h3>commits must be atomic!</h3>
314+
<header>
315+
<a href="https://github.com/JadsonLucena/semantic-commit-generator" target="_blank"><h1>Semantic Commit Generator</h1></a>
316+
</header>
312317

313-
<div>
318+
<aside>
314319
<a href="https://www.conventionalcommits.org" target="_blank">Conventional Commits</a>
315320
<a href="https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-format" target="_blank">Contributing to Angular</a>
316-
</div>
321+
</aside>
317322

318323
</footer>
319324

styles/index.css

Lines changed: 33 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,15 @@ main {
4747

4848
z-index: 2;
4949
}
50+
main > section > details h2 {
51+
display: inline;
52+
font-size: 16px;
53+
}
54+
main > section > details h3 {
55+
display: inline;
56+
font-size: 14px;
57+
font-weight: normal;
58+
}
5059
main > section > details > summary {
5160
cursor: pointer;
5261
}
@@ -253,15 +262,33 @@ footer {
253262

254263
z-index: 3;
255264
}
256-
footer > h3 {
257-
display: block;
265+
footer > header {
258266
width: 100%;
259267
height: 40%;
260268
text-align: center;
261-
font-weight: normal;
262-
color: #fff;
269+
270+
display: flex;
271+
justify-content: center;
272+
align-items: center;
273+
gap: 10px;
263274
}
264-
footer > div {
275+
footer > header > a {
276+
display: inline-block;
277+
width: max-content;
278+
height: max-content;
279+
text-decoration: none;
280+
}
281+
footer > header > a > h1 {
282+
display: inline;
283+
font-size: 18px;
284+
color: #fff;
285+
white-space: nowrap;
286+
}
287+
footer > header > a > img {
288+
float: left;
289+
width: 100%;
290+
}
291+
footer > aside {
265292
width: 100%;
266293
height: 60%;
267294
text-align: center;
@@ -271,7 +298,7 @@ footer {
271298
justify-content: space-between;
272299
align-items: center;
273300
}
274-
footer > div > a {
301+
footer > aside > a {
275302
padding: 0 5px 0 10px;
276303
color: #fff;
277304
}

0 commit comments

Comments
 (0)