fix code expecting cached members

Author: danthe1st

src/main/java/net/discordjug/javabot/systems/moderation/server_lock/ServerLockManager.java

@@ -16,6 +16,7 @@
 import net.dv8tion.jda.api.entities.Member;
 import net.dv8tion.jda.api.entities.MessageEmbed;
 import net.dv8tion.jda.api.entities.User;
+import net.dv8tion.jda.api.entities.UserSnowflake;
 import net.dv8tion.jda.api.events.guild.member.GuildMemberJoinEvent;
 import net.dv8tion.jda.api.hooks.ListenerAdapter;
 
@@ -94,7 +95,7 @@ public ServerLockManager(JDA jda, NotificationService notificationService, BotCo
 				.setColor(Responses.Type.DEFAULT.getColor())
 				.setDescription(String.format("""
 						Unfortunately, this server is currently locked. Please try to join again later.
-						Contact the server owner, %s, for more info.""", guild.getOwner().getAsMention())
+						Contact the server owner, %s, for more info.""", UserSnowflake.fromId(guild.getOwnerIdLong()).getAsMention())
 				).build();
 	}
 

src/main/java/net/discordjug/javabot/systems/user_commands/ServerInfoCommand.java

@@ -5,6 +5,7 @@
 import net.discordjug.javabot.util.Responses;
 import net.dv8tion.jda.api.EmbedBuilder;
 import net.dv8tion.jda.api.entities.Guild;
+import net.dv8tion.jda.api.entities.Member;
 import net.dv8tion.jda.api.entities.MessageEmbed;
 import net.dv8tion.jda.api.events.interaction.command.SlashCommandInteractionEvent;
 import net.dv8tion.jda.api.interactions.commands.build.Commands;
@@ -33,19 +34,26 @@ public void execute(@NotNull SlashCommandInteractionEvent event) {
 			Responses.replyGuildOnly(event).queue();
 			return;
 		}
-		event.replyEmbeds(buildServerInfoEmbed(event.getGuild()))
-				.addActionRow(Button.link(Constants.WEBSITE_LINK, "Website")).queue();
+		event.deferReply().queue();
+		event.getGuild().retrieveOwner().queue(owner -> 
+			event
+				.getHook()
+				.sendMessageEmbeds(
+					buildServerInfoEmbed(event.getGuild(), owner))
+						.addActionRow(Button.link(Constants.WEBSITE_LINK, "Website")
+				).queue()
+		);
 	}
 
-	private @NotNull MessageEmbed buildServerInfoEmbed(@NotNull Guild guild) {
+	private @NotNull MessageEmbed buildServerInfoEmbed(@NotNull Guild guild, Member owner) {
 		long categories = guild.getCategories().size();
 		long channels = guild.getChannels().size() - categories;
 		return new EmbedBuilder()
 				.setColor(Responses.Type.DEFAULT.getColor())
 				.setThumbnail(guild.getIconUrl())
 				.setAuthor(guild.getName(), null, guild.getIconUrl())
 				.setTitle("Server Information")
-				.addField("Owner", guild.getOwner().getAsMention(), true)
+				.addField("Owner", owner.getAsMention(), true)
 				.addField("Member Count", guild.getMemberCount() + " members", true)
 				.addField("Roles", String.format("%s Roles", guild.getRoles().size() - 1L), true)
 				.addField("ID", String.format("```%s```", guild.getIdLong()), false)

src/main/java/net/discordjug/javabot/util/WebhookUtil.java

@@ -91,12 +91,17 @@ public static void ensureWebhookExists(@NotNull IWebhookContainer channel, @NotN
 	 * the message
 	 */
 	public static CompletableFuture<ReadonlyMessage> mirrorMessageToWebhook(@NotNull Webhook webhook, @NotNull Message originalMessage, String newMessageContent, long threadId, @Nullable List<LayoutComponent> components, @Nullable List<MessageEmbed> embeds) {
-		JDAWebhookClient client = new WebhookClientBuilder(webhook.getIdLong(), webhook.getToken()).setThreadId(threadId)
-				.buildJDA();
+		return originalMessage.getGuild().retrieveMember(originalMessage.getAuthor()).submit().thenCompose(member -> mirrorMessageToWebhook(webhook, originalMessage, newMessageContent, threadId, components, embeds, member));
+	}
+
+	private static CompletableFuture<ReadonlyMessage> mirrorMessageToWebhook(@NotNull Webhook webhook, Message originalMessage, String newMessageContent, long threadId,
+			List<LayoutComponent> components, List<MessageEmbed> embeds, Member member) {
 		WebhookMessageBuilder message = new WebhookMessageBuilder().setContent(newMessageContent)
 				.setAllowedMentions(AllowedMentions.none())
-				.setAvatarUrl(transformOrNull(originalMessage.getMember(), Member::getEffectiveAvatarUrl))
-				.setUsername(transformOrNull(originalMessage.getMember(), Member::getEffectiveName));
+				.setAvatarUrl(transformOrNull(member, Member::getEffectiveAvatarUrl))
+				.setUsername(transformOrNull(member, Member::getEffectiveName));
+		JDAWebhookClient client = new WebhookClientBuilder(webhook.getIdLong(), webhook.getToken()).setThreadId(threadId)
+				.buildJDA();
 		if (components != null && !components.isEmpty()) {
 			message.addComponents(components);
 		}