Skip to content

Commit 1c3360a

Browse files
committed
fix QOTW for unranked users
1 parent 9c504a1 commit 1c3360a

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/main/java/net/javadiscord/javabot/systems/qotw/QOTWPointsService.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ public List<Pair<QOTWAccount, Member>> getTopMembers(int n, Guild guild) {
9191
List<QOTWAccount> accounts = pointsRepository.sortByPoints();
9292
return accounts.stream()
9393
.map(s -> new Pair<>(s, guild.getMemberById(s.getUserId())))
94+
.filter(p->p.first().getPoints() > 0)
9495
.filter(p -> p.second() != null)
9596
.limit(n)
9697
.toList();

src/main/java/net/javadiscord/javabot/systems/user_commands/leaderboard/QOTWLeaderboardSubcommand.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,8 @@ private MessageEmbed buildLeaderboardRankEmbed(Member member) {
106106
return new EmbedBuilder()
107107
.setAuthor(member.getUser().getAsTag(), null, member.getEffectiveAvatarUrl())
108108
.setTitle("Question of the Week Leaderboard")
109-
.setDescription(String.format("You're currently in `%s` place with `%s` %s.",
110-
rank + rankSuffix, points, pointsText))
109+
.setDescription(points == 0 ? "You are currently not ranked." :
110+
String.format("You're currently in `%s` place with `%s` %s.", rank + rankSuffix, points, pointsText))
111111
.setTimestamp(Instant.now())
112112
.build();
113113
}

0 commit comments

Comments
 (0)