Replaced some more things with NotificationServices and reduced code duplication

Author: jasonlessenich

src/main/java/net/javadiscord/javabot/systems/notification/QOTWNotificationService.java

@@ -9,6 +9,7 @@
 import net.javadiscord.javabot.systems.qotw.dao.QuestionPointsRepository;
 import net.javadiscord.javabot.systems.qotw.model.QOTWAccount;
 
+import javax.annotation.Nonnull;
 import java.sql.Connection;
 import java.sql.SQLException;
 import java.time.Instant;
@@ -51,30 +52,49 @@ public void sendAccountIncrementedNotification() {
 		this.sendDirectMessageNotification(user, this.buildAccountIncrementEmbed(account.getPoints()));
 	}
 
-	private MessageEmbed buildBestAnswerEmbed(long points) {
+	public void sendSubmissionDeclinedEmbed(@Nonnull String reason) {
+		this.sendDirectMessageNotification(user, this.buildSubmissionDeclinedEmbed(reason));
+	}
+
+	private EmbedBuilder buildQOTWNotificationEmbed() {
 		return new EmbedBuilder()
 				.setAuthor(user.getAsTag(), null, user.getEffectiveAvatarUrl())
 				.setTitle("QOTW Notification")
+				.setTimestamp(Instant.now());
+	}
+
+	private MessageEmbed buildBestAnswerEmbed(long points) {
+		return this.buildQOTWNotificationEmbed()
 				.setColor(Bot.config.get(guild).getSlashCommand().getSuccessColor())
 				.setDescription(String.format(
 						"""
 								Your submission was marked as the best answer!
 								You've been granted **`1 extra QOTW-Point`**! (total: %s)""", points))
-				.setTimestamp(Instant.now())
 				.build();
 	}
 
 	private MessageEmbed buildAccountIncrementEmbed(long points) {
-		return new EmbedBuilder()
-				.setAuthor(user.getAsTag(), null, user.getEffectiveAvatarUrl())
-				.setTitle("QOTW Notification")
+		return this.buildQOTWNotificationEmbed()
 				.setColor(Bot.config.get(guild).getSlashCommand().getSuccessColor())
 				.setDescription(String.format(
 						"""
 								Your submission was accepted! %s
 								You've been granted **`1 QOTW-Point`**! (total: %s)""",
 						Bot.config.get(guild).getEmote().getSuccessEmote().getAsMention(), points))
-				.setTimestamp(Instant.now())
 				.build();
 	}
+
+	private MessageEmbed buildSubmissionDeclinedEmbed(String reasons) {
+		return this.buildQOTWNotificationEmbed()
+				.setColor(Bot.config.get(guild).getSlashCommand().getErrorColor())
+				.setDescription(String.format("""
+								Hey %s,
+								Your QOTW-Submission was **declined** for the following reasons:
+								**`%s`**
+
+								However, you can try your luck again next week!""",
+						user.getAsMention(), reasons))
+				.build();
+	}
+
 }

src/main/java/net/javadiscord/javabot/systems/qotw/submissions/SubmissionControlsManager.java

@@ -137,7 +137,7 @@ protected void declineSelectSubmission(SelectMenuInteractionEvent event, ThreadC
 		DbHelper.doDaoAction(QOTWSubmissionRepository::new, dao -> dao.updateStatus(thread.getIdLong(), SubmissionStatus.DECLINED));
 		thread.getManager().setName(SUBMISSION_DECLINED + thread.getName().substring(1)).queue();
 		event.getJDA().retrieveUserById(submission.getAuthorId()).queue(user -> {
-				user.openPrivateChannel().queue(c -> c.sendMessageEmbeds(this.buildSubmissionDeclinedEmbed(user, reasons)).queue());
+				new QOTWNotificationService(user, event.getGuild()).sendSubmissionDeclinedEmbed(reasons);
 				Responses.success(event.getHook(), "Submission Declined",
 						String.format("Successfully declined submission by %s for the following reasons:\n`%s`", user.getAsMention(), reasons)).queue();
 				}
@@ -174,22 +174,6 @@ private void disableControls(String buttonLabel, Message message) {
 		message.editMessageComponents(ActionRow.of(Button.secondary("qotw-submission:controls:dummy", buttonLabel).asDisabled())).queue();
 	}
 
-	private MessageEmbed buildSubmissionDeclinedEmbed(User createdBy, String reasons) {
-		return new EmbedBuilder()
-				.setAuthor(createdBy.getAsTag(), null, createdBy.getEffectiveAvatarUrl())
-				.setTitle("QOTW Notification")
-				.setColor(Bot.config.get(config.getGuild()).getSlashCommand().getErrorColor())
-				.setDescription(String.format("""
-								Hey %s,
-								Your QOTW-Submission was **declined** for the following reasons:
-								**`%s`**
-
-								However, you can try your luck again next week!""",
-						createdBy.getAsMention(), reasons))
-				.setTimestamp(Instant.now())
-				.build();
-	}
-
 	private MessageEmbed buildLogEmbed(ThreadChannel thread, User threadOwner, User reviewedBy, SubmissionStatus status, @Nullable String reason) {
 		EmbedBuilder builder = new EmbedBuilder()
 				.setAuthor(reviewedBy.getAsTag(), null, reviewedBy.getEffectiveAvatarUrl())