Merge pull request #372 from danthe1st/fix-ban-msg

Author: jasonlessenich

src/main/java/net/javadiscord/javabot/Bot.java

@@ -51,7 +51,7 @@ public class Bot {
 	private final DIH4JDA dih4jda;
 	private final BotConfig config;
 	private final List<SlashCommand> commands;
-	private final List<ContextCommand> contextCommands;
+	private final List<ContextCommand<?>> contextCommands;
 	private final List<ListenerAdapter> listeners;
 	private final ApplicationContext ctx;
 

src/main/java/net/javadiscord/javabot/systems/moderation/ModerationService.java

@@ -208,8 +208,17 @@ public void removeTimeout(Member member, String reason, Member removedBy, Messag
 	 */
 	public void ban(User user, String reason, Member bannedBy, MessageChannel channel, boolean quiet) {
 		MessageEmbed banEmbed = buildBanEmbed(user, bannedBy, reason);
+		user.openPrivateChannel().flatMap(privateChannel -> privateChannel.sendMessageEmbeds(banEmbed)).queue(success -> {
+			banAndSendGuildNotifications(user, reason, bannedBy, channel, quiet, banEmbed);
+		}, err-> {
+			banAndSendGuildNotifications(user, reason, bannedBy, channel, quiet, banEmbed);
+			ExceptionLogger.capture(err, ModerationService.class.getName());
+		});
+	}
+
+	private void banAndSendGuildNotifications(User user, String reason, Member bannedBy, MessageChannel channel, boolean quiet,
+			MessageEmbed banEmbed) {
 		bannedBy.getGuild().ban(user, BAN_DELETE_DAYS, TimeUnit.DAYS).reason(reason).queue(s -> {
-			notificationService.withUser(user).sendDirectMessage(c -> c.sendMessageEmbeds(banEmbed));
 			notificationService.withGuild(bannedBy.getGuild()).sendToModerationLog(c -> c.sendMessageEmbeds(banEmbed));
 			if (!quiet) channel.sendMessageEmbeds(banEmbed).queue();
 		}, ExceptionLogger::capture);