Skip to content

Commit 76b986f

Browse files
Removed another unused connection
1 parent c7e052b commit 76b986f

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

src/main/java/net/javadiscord/javabot/systems/qotw/QOTWCloseSubmissionsJob.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,15 @@
1010
import net.javadiscord.javabot.data.config.BotConfig;
1111
import net.javadiscord.javabot.data.config.GuildConfig;
1212
import net.javadiscord.javabot.data.config.guild.QOTWConfig;
13-
import net.javadiscord.javabot.data.h2db.DbHelper;
1413
import net.javadiscord.javabot.systems.notification.NotificationService;
1514
import net.javadiscord.javabot.systems.qotw.submissions.SubmissionControlsManager;
1615
import net.javadiscord.javabot.systems.qotw.submissions.dao.QOTWSubmissionRepository;
1716
import net.javadiscord.javabot.systems.qotw.submissions.model.QOTWSubmission;
18-
import net.javadiscord.javabot.util.ExceptionLogger;
1917
import org.springframework.scheduling.annotation.Scheduled;
2018
import org.springframework.stereotype.Service;
2119

2220
import lombok.RequiredArgsConstructor;
2321

24-
import java.sql.Connection;
2522
import java.sql.SQLException;
2623
import java.util.Collections;
2724
import java.util.List;
@@ -37,7 +34,6 @@ public class QOTWCloseSubmissionsJob {
3734
private final QOTWPointsService pointsService;
3835
private final NotificationService notificationService;
3936
private final BotConfig botConfig;
40-
private final DbHelper dbHelper;
4137
private final QOTWSubmissionRepository qotwSubmissionRepository;
4238

4339
/**
@@ -59,14 +55,9 @@ public void execute() throws SQLException {
5955
if (message == null) continue;
6056
message.editMessageComponents(ActionRow.of(Button.secondary("qotw-submission:closed", "Submissions closed").asDisabled())).queue();
6157
for (ThreadChannel thread : qotwConfig.getSubmissionChannel().getThreadChannels()) {
62-
try (Connection con = dbHelper.getDataSource().getConnection()) {
63-
Optional<QOTWSubmission> optionalSubmission = qotwSubmissionRepository.getSubmissionByThreadId(thread.getIdLong());
64-
if (optionalSubmission.isEmpty()) continue;
65-
new SubmissionControlsManager(botConfig.get(guild), optionalSubmission.get(), pointsService, notificationService).sendControls();
66-
} catch (SQLException e) {
67-
ExceptionLogger.capture(e, getClass().getSimpleName());
68-
throw e;
69-
}
58+
Optional<QOTWSubmission> optionalSubmission = qotwSubmissionRepository.getSubmissionByThreadId(thread.getIdLong());
59+
if (optionalSubmission.isEmpty()) continue;
60+
new SubmissionControlsManager(botConfig.get(guild), optionalSubmission.get(), pointsService, notificationService).sendControls();
7061
}
7162
}
7263
}

0 commit comments

Comments
 (0)