add reason size limit to command

Author: danthe1st

src/main/java/net/discordjug/javabot/systems/help/commands/UnreserveCommand.java

@@ -39,6 +39,7 @@
 @AutoDetectableComponentHandler(UnreserveCommand.UNRESERVE_ID)
 public class UnreserveCommand extends SlashCommand implements ModalHandler {
 	static final String UNRESERVE_ID = "unreserve";
+	private static final int MINIMUM_REASON_LENGTH = 11;
 	private static final String REASON_ID = "reason";
 	private final BotConfig botConfig;
 	private final DbActions dbActions;
@@ -72,9 +73,9 @@ public void execute(@NotNull SlashCommandInteractionEvent event) {
 		onCloseRequest(event, event, event.getChannel(), reason, ()->{
 			TextInput reasonInput = TextInput
 				.create(REASON_ID, "Reason", TextInputStyle.SHORT)
-				.setRequiredRange(11, 100)
+				.setRequiredRange(MINIMUM_REASON_LENGTH, 100)
 				.setRequired(true)
-				.setPlaceholder("Please enter the reason you are closing this post here")
+				.setPlaceholder(reason == null ? "Please enter the reason you are closing this post here" : reason)
 				.build();
 			Modal modal = Modal
 					.create(ComponentIdBuilder.build(UNRESERVE_ID), "Close post")
@@ -91,13 +92,14 @@ public void handleModal(ModalInteractionEvent event, List<ModalMapping> values)
 			.stream()
 			.filter(mapping -> REASON_ID.equals(mapping.getId()))
 			.map(mapping -> mapping.getAsString())
+			.filter(reason -> !isReasonInvalid(reason))
 			.findAny()
 			.ifPresentOrElse(reason -> {
 				onCloseRequest(event, event, event.getChannel(), reason, ()->{
-					Responses.error(event, "An error occured - The reason field is missing.").queue();
+					Responses.error(event, "The provided reason is missing or not valid").queue();
 					ExceptionLogger.capture(new IllegalStateException("A reason was expected but not present"), getClass().getName());
 				});
-			}, () -> Responses.warning(event, "A reason must be provided").queue());
+			}, () -> Responses.warning(event, "A valid reason must be provided").queue());
 
 	}
 
@@ -115,7 +117,7 @@ private void onCloseRequest(Interaction interaction, IReplyCallback replyCallbac
 		}
 		HelpManager manager = new HelpManager(postThread, dbActions, botConfig, helpAccountRepository, helpTransactionRepository, preferenceService);
 		if (manager.isForumEligibleToBeUnreserved(interaction)) {
-			if (replyCallback.getUser().getIdLong() != postThread.getOwnerIdLong() && reason == null) {
+			if (replyCallback.getUser().getIdLong() != postThread.getOwnerIdLong() && isReasonInvalid(reason)) {
 				noReasonHandler.run();
 				return;
 			}
@@ -127,6 +129,10 @@ private void onCloseRequest(Interaction interaction, IReplyCallback replyCallbac
 		}
 	}
 
+	private boolean isReasonInvalid(String reason) {
+		return reason == null || reason.length() < MINIMUM_REASON_LENGTH;
+	}
+
 	private void replyInvalidChannel(IReplyCallback replyCallback) {
 		Responses.warning(replyCallback, "Invalid Channel",
 						"This command may only be used in either the text-channel-based help system, or in our new forum help system.")