Merge pull request #368 from Java-Discord/dynxsty/fix-qotw

Fixed non-`final` ExecutorService

Author: jasonlessenich

src/main/java/net/javadiscord/javabot/systems/qotw/QOTWUserReminderJob.java

@@ -20,6 +20,7 @@
 import lombok.RequiredArgsConstructor;
 
 import java.util.List;
+import java.util.concurrent.ExecutorService;
 
 /**
  * Checks that there's a question in the QOTW queue ready for posting soon.
@@ -33,6 +34,7 @@ public class QOTWUserReminderJob {
 	private final DbHelper dbHelper;
 	private final QOTWSubmissionRepository qotwSubmissionRepository;
 	private final QuestionQueueRepository questionQueueRepository;
+	private final ExecutorService asyncPool;
 
 	/**
 	 * Checks that there's a question in the QOTW queue ready for posting soon.
@@ -41,7 +43,7 @@ public class QOTWUserReminderJob {
 	public void execute() {
 		for (Guild guild : jda.getGuilds()) {
 			QOTWConfig config = botConfig.get(guild).getQotwConfig();
-			List<QOTWSubmission> submissions = new SubmissionManager(config, dbHelper, qotwSubmissionRepository, questionQueueRepository).getActiveSubmissionThreads(guild.getIdLong());
+			List<QOTWSubmission> submissions = new SubmissionManager(config, dbHelper, qotwSubmissionRepository, questionQueueRepository, asyncPool).getActiveSubmissionThreads(guild.getIdLong());
 			for (QOTWSubmission submission : submissions) {
 				UserPreference preference = userPreferenceService.getOrCreate(submission.getAuthorId(), Preference.QOTW_REMINDER);
 				if (Boolean.parseBoolean(preference.getState())) {

src/main/java/net/javadiscord/javabot/systems/qotw/submissions/SubmissionInteractionManager.java

@@ -42,7 +42,7 @@ public class SubmissionInteractionManager implements ButtonHandler, SelectMenuHa
 
 	@Override
 	public void handleButton(@NotNull ButtonInteractionEvent event, Button button) {
-		SubmissionManager manager = new SubmissionManager(botConfig.get(event.getGuild()).getQotwConfig(), dbHelper, qotwSubmissionRepository, questionQueueRepository);
+		SubmissionManager manager = new SubmissionManager(botConfig.get(event.getGuild()).getQotwConfig(), dbHelper, qotwSubmissionRepository, questionQueueRepository, asyncPool);
 		String[] id = ComponentIdBuilder.split(event.getComponentId());
 		switch (id[1]) {
 			case "controls" -> handleControlButtons(id, event);

src/main/java/net/javadiscord/javabot/systems/qotw/submissions/SubmissionManager.java

@@ -44,7 +44,7 @@ public class SubmissionManager {
 	private final DbHelper dbHelper;
 	private final QOTWSubmissionRepository qotwSubmissionRepository;
 	private final QuestionQueueRepository questionQueueRepository;
-	private ExecutorService asyncPool;
+	private final ExecutorService asyncPool;
 
 	/**
 	 * Handles the "Submit your Answer" Button interaction.