Cleaned up for-loop in QOTWLeaderboardSubcommand

Author: jasonlessenich

src/main/java/net/javadiscord/javabot/systems/user_commands/leaderboard/ExperienceLeaderboardSubcommand.java

@@ -42,7 +42,7 @@ public ExperienceLeaderboardSubcommand() {
 	}
 
 	@Override
-	public void handleButton(ButtonInteractionEvent event, Button button) {
+	public void handleButton(@NotNull ButtonInteractionEvent event, Button button) {
 		event.deferEdit().queue();
 		String[] id = ComponentIdBuilder.split(event.getComponentId());
 		DbHelper.doDaoAction(HelpAccountRepository::new, dao -> {

src/main/java/net/javadiscord/javabot/systems/user_commands/leaderboard/QOTWLeaderboardSubcommand.java

@@ -161,12 +161,11 @@ private void drawUserCard(@NotNull Graphics2D g2d, @NotNull Member member, QOTWP
 
 			boolean left = true;
 			int y = logo.getHeight() + 3 * MARGIN;
-			for (Member m : topMembers.stream().map(Pair::second).toList()) {
-				drawUserCard(g2d, m, service, y, left);
+			for (Pair<QOTWAccount, Member> pair : topMembers) {
+				drawUserCard(g2d, pair.second(), service, y, left);
 				left = !left;
 				if (left) y = y + card.getHeight() + MARGIN;
 			}
-
 			ImageCache.removeCachedImagesByKeyword("qotw_leaderboard");
 			ImageCache.cacheImage(getCacheName(), image);
 			return getOutputStreamFromImage(image);
@@ -203,7 +202,7 @@ private void drawUserCard(@NotNull Graphics2D g2d, @NotNull Member member, QOTWP
 	 * @return The image's {@link ByteArrayOutputStream}.
 	 * @throws IOException If an error occurs.
 	 */
-	private ByteArrayOutputStream getOutputStreamFromImage(BufferedImage image) throws IOException {
+	private @NotNull ByteArrayOutputStream getOutputStreamFromImage(BufferedImage image) throws IOException {
 		ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
 		ImageIO.write(image, "png", outputStream);
 		return outputStream;