(test) improve coverage on editor

Author: JeanBaptisteWATENBERG

.vscode/launch.json

@@ -0,0 +1,31 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "Debug Dev Server",
+            "request": "launch",
+            "sourceMapPathOverrides": {
+              "webpack:///src/*": "${webRoot}/*"
+            },
+            "type": "chrome",
+            "url": "http://localhost:3000",
+            "runtimeExecutable": "/usr/bin/chromium",
+            "webRoot": "${workspaceRoot}/src",
+          },
+          {
+            "name": "Debug Karma Tests",
+            "request": "launch",
+            "runtimeArgs": ["--headless"],
+            "sourceMapPathOverrides": {
+              "webpack:///src/*": "${workspaceRoot}/src/*",
+              "webpack:///tests/*": "${workspaceRoot}/tests/*"
+            },
+            "type": "chrome",
+            "runtimeExecutable": "/usr/bin/chromium",
+            "url": "http://localhost:9876/debug.html",
+          }
+    ]
+}

tests/Editor-test.js

@@ -33,16 +33,79 @@ describe('Editor component', () => {
     });
 
     it ('should dispatch selected suggestion', () =>  {
+        //S
         const spy = expect.createSpy();
         const wraper = mount(<Editor input={document.createElement('input')} onJsonPathChanged={spy} jsonpath='abc' position={{x: 0, y:0}} json={{type: 'string'}} />);
+        //E
         wraper.instance().onSelectSuggestion({value: 'test', description: 'test'});
+        //V
         expect(spy).toHaveBeenCalledWith('test');
     });
 
     it ('should dispatch selected suggestion when suggestion has setCarretAt', () =>  {
+        //S
         const spy = expect.createSpy();
         const wraper = mount(<Editor input={document.createElement('input')} onJsonPathChanged={spy} jsonpath='abc' position={{x: 0, y:0}} json={{type: 'string'}} />);
+        //E
         wraper.instance().onSelectSuggestion({value: 'test', description: 'test', setCarretAt: 1});
+        //V
         expect(spy).toHaveBeenCalledWith('test');
     });
+
+    it ('should set json path with suggestion value correctly when jsonpath ends with a part of the suggestion', () =>  {
+        //S
+        const spy = expect.createSpy();
+        const jsonPath = '$.te.es'; // es is included in 'test' which is the value of the suggestion
+        const input = document.createElement('input');
+        input.value = jsonPath;
+        const wraper = mount(<Editor input={input} onJsonPathChanged={spy} jsonpath={jsonPath} position={{x: 0, y:0}} json={{type: 'string'}} />);
+        //E
+        wraper.instance().onSelectSuggestion({value: 'test', description: 'test', setCarretAt: 1});
+        //V
+        expect(spy).toHaveBeenCalledWith('$.te.test');
+    });
+
+    it ('should set json path with suggestion value correctly when jsonpath doesn\'t ends with a part of the suggestion', () =>  {
+        //S
+        const spy = expect.createSpy();
+        const jsonPath = '$.te.re';
+        const input = document.createElement('input');
+        input.value = jsonPath;
+        const wraper = mount(<Editor input={input} onJsonPathChanged={spy} jsonpath={jsonPath} position={{x: 0, y:0}} json={{type: 'string'}} />);
+        //E
+        wraper.instance().onSelectSuggestion({value: 'test', description: 'test', setCarretAt: 1});
+        //V
+        expect(spy).toHaveBeenCalledWith('$.te.retest');
+    });
+
+    it ('should evaluate suggestions when caret position is updated', () => {
+        //S
+        const wraper = mount(<Editor input={document.createElement('input')} position={{x: 0, y:0}} json={{type: 'string'}} />);
+        const spy = expect.spyOn(wraper.instance(), 'evalPathAndSuggestions');
+        //E
+        wraper.instance().onCaretChanged({code: 'ArrowLeft'});
+        //V
+        expect(spy).toHaveBeenCalled();
+    });
+
+
+    it ('should not evaluate suggestions when caret position is updated due to up arrow', () => {
+        //S
+        const wraper = mount(<Editor input={document.createElement('input')} position={{x: 0, y:0}} json={{type: 'string'}} />);
+        const spy = expect.spyOn(wraper.instance(), 'evalPathAndSuggestions');
+        //E
+        wraper.instance().onCaretChanged({code: 'ArrowUp'});
+        //V
+        expect(spy).toNotHaveBeenCalled();
+    });
+
+    it ('should not evaluate suggestions when caret position is updated due to down arrow', () => {
+        //S
+        const wraper = mount(<Editor input={document.createElement('input')} position={{x: 0, y:0}} json={{type: 'string'}} />);
+        const spy = expect.spyOn(wraper.instance(), 'evalPathAndSuggestions');
+        //E
+        wraper.instance().onCaretChanged({code: 'ArrowDown'});
+        //V
+        expect(spy).toNotHaveBeenCalled(); 
+    });
 });