Skip to content

Commit a68993d

Browse files
committed
Enable submodule stripping for minsize
Since this now seems like a valid option reducing the size quite a bit. See also https://discussions.unity.com/t/unity-web-stripping-tool-feedback/1667902/4
1 parent c700784 commit a68993d

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

Assets/Scripts/Editor/BuildScript.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,20 +40,20 @@ public static class BuildScript
4040
private static bool LogVerboseInEditor = false;
4141
private static readonly string CodeOptimizationSpeed =
4242
#if UNITY_2021_3_OR_NEWER
43-
CodeOptimizationWebGL.RuntimeSpeedLTO.ToString();
43+
nameof(CodeOptimizationWebGL.RuntimeSpeedLTO);
4444
#else
4545
"speed";
4646
#endif
4747
private static readonly string CodeOptimizationSize =
4848
#if UNITY_2021_3_OR_NEWER
49-
CodeOptimizationWebGL.DiskSizeLTO.ToString();
49+
nameof(CodeOptimizationWebGL.DiskSizeLTO);
5050
#else
5151
"size";
5252
#endif
5353

5454
private static readonly string CodeOptimizationBuildTimes =
5555
#if UNITY_2021_3_OR_NEWER
56-
CodeOptimizationWebGL.BuildTimes.ToString();
56+
nameof(CodeOptimizationWebGL.BuildTimes);
5757
#else
5858
"size";
5959
#endif
@@ -215,7 +215,8 @@ private static void HandleTagParameters(string tagVersion, NamedBuildTarget name
215215
private static void HandleSubmoduleStrippingParameters(string[] tagParameters)
216216
{
217217
#if UNITY_6000_1_OR_NEWER
218-
isSubmoduleStrippingEnabled = tagParameters.Contains("stripping");
218+
isSubmoduleStrippingEnabled = !tagParameters.Contains("nostripping")
219+
&& (tagParameters.Contains("stripping") || tagParameters.Contains("minsize"));
219220
PlayerSettings.WebGL.enableSubmoduleStrippingCompatibility = isSubmoduleStrippingEnabled;
220221

221222
if (isSubmoduleStrippingEnabled)

Assets/Scripts/Editor/BuildSettingsData.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
using System.Linq;
22
using NUnit.Framework;
3+
#if UNITY_6000_1_OR_NEWER
34
using Unity.Web.Stripping.Editor;
5+
#endif
46
using UnityEditor;
57
using UnityEngine;
68

79
namespace UnityBuilderAction
810
{
911

10-
[CreateAssetMenu(menuName = "Create BuildSettingsData", fileName = "BuildSettingsData", order = 0)]
12+
[CreateAssetMenu(menuName = "BuildSettingsData", fileName = "BuildSettingsData", order = 0)]
1113
public class BuildSettingsData : ScriptableObject
1214
{
1315
private static BuildSettingsData _instance;
@@ -27,9 +29,11 @@ public static BuildSettingsData Instance
2729
}
2830
}
2931

32+
#if UNITY_6000_1_OR_NEWER
3033
[SerializeField]
3134
private SubmoduleStrippingSettings webSubmoduleStrippingSettings;
3235

3336
public SubmoduleStrippingSettings WebSubmoduleStrippingSettings => webSubmoduleStrippingSettings;
37+
#endif
3438
}
3539
}

0 commit comments

Comments
 (0)