Skip to content

Commit 022c87c

Browse files
authored
chore: Added PR template and removed husky (#447)
1 parent b5dd302 commit 022c87c

File tree

7 files changed

+341
-177
lines changed

7 files changed

+341
-177
lines changed

.appveyor.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ install:
2020
- npm install --no-audit
2121

2222
before_test:
23+
- npm run style-check
24+
- npm run lint
2325
- npm run build
2426
# For coverage
2527
- ps: (get-content package.json) | %{$_ -replace '"\*"',''} | set-content package.json

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
**IMPORTANT: Please do not create a Pull Request without creating an issue first.**
2+
3+
*Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.*
4+
<!---
5+
The above should be deleted
6+
-->
7+
8+
Fixes #(issue)
9+
10+
# Description
11+
12+
<!---
13+
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
14+
-->
15+
16+
## Type of change
17+
<!---
18+
Please delete options that are not relevant.
19+
-->
20+
[ ] Bug fix (non-breaking change which fixes an issue)
21+
[ ] New feature (non-breaking change which adds functionality)
22+
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
23+
[ ] This change requires a documentation update
24+
25+
# How Has This Been Tested?
26+
<!---
27+
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
28+
-->
29+
30+
# Checklist:
31+
[ ] My code follows the style guidelines of this project
32+
[ ] I have performed a self-review of my own code
33+
[ ] I have commented my code, particularly in hard-to-understand areas
34+
[ ] I have made corresponding changes to the documentation
35+
[ ] My changes generate no new warnings
36+
[ ] I have added tests that prove my fix is effective or that my feature works
37+
[ ] New and existing unit tests pass locally with my changes

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ install:
3030
- sed -i.bak 's/"\*"//g' package.json
3131

3232
script:
33+
- npm run style-check
3334
- npm test --silent
3435

3536
after_success:

0 commit comments

Comments
 (0)