refactor: Removed check active editor from model (#443) (#517)

Author: edgardmessias

src/contexts/checkActiveEditor.ts

@@ -0,0 +1,76 @@
+import { commands, Disposable, window } from "vscode";
+import { Status } from "../common/types";
+import { debounce } from "../decorators";
+import { Model } from "../model";
+import { IDisposable } from "../util";
+
+export class CheckActiveEditor implements IDisposable {
+  private disposables: Disposable[] = [];
+
+  constructor(private model: Model) {
+    // When repository update, like update
+    model.onDidChangeStatusRepository(
+      this.checkHasChangesOnActiveEditor,
+      this,
+      this.disposables
+    );
+
+    window.onDidChangeActiveTextEditor(
+      () => this.checkHasChangesOnActiveEditor(),
+      this,
+      this.disposables
+    );
+  }
+
+  @debounce(100)
+  private checkHasChangesOnActiveEditor() {
+    commands.executeCommand(
+      "setContext",
+      "svnActiveEditorHasChanges",
+      this.hasChangesOnActiveEditor()
+    );
+  }
+
+  private hasChangesOnActiveEditor(): boolean {
+    if (!window.activeTextEditor) {
+      return false;
+    }
+    const uri = window.activeTextEditor.document.uri;
+
+    const repository = this.model.getRepository(uri);
+    if (!repository) {
+      return false;
+    }
+
+    const resource = repository.getResourceFromFile(uri);
+    if (!resource) {
+      return false;
+    }
+
+    switch (resource.type) {
+      case Status.ADDED:
+      case Status.DELETED:
+      case Status.EXTERNAL:
+      case Status.IGNORED:
+      case Status.NONE:
+      case Status.NORMAL:
+      case Status.UNVERSIONED:
+        return false;
+      case Status.CONFLICTED:
+      case Status.INCOMPLETE:
+      case Status.MERGED:
+      case Status.MISSING:
+      case Status.MODIFIED:
+      case Status.OBSTRUCTED:
+      case Status.REPLACED:
+        return true;
+    }
+
+    // Show if not match
+    return true;
+  }
+
+  public dispose(): void {
+    this.disposables.forEach(d => d.dispose());
+  }
+}

src/extension.ts

@@ -9,6 +9,7 @@ import {
 } from "vscode";
 import { registerCommands } from "./commands";
 import { ConstructorPolicy } from "./common/types";
+import { CheckActiveEditor } from "./contexts/checkActiveEditor";
 import SvnDecorations from "./decorations/svnDecorations";
 import { configuration } from "./helpers/configuration";
 import { ItemLogProvider } from "./historyView/itemLogProvider";
@@ -55,6 +56,8 @@ async function init(
   disposables.push(itemLogProvider);
   window.registerTreeDataProvider("itemlog", itemLogProvider);
 
+  disposables.push(new CheckActiveEditor(model));
+
   // First, check the vscode has support to DecorationProvider
   if (hasSupportToDecorationProvider()) {
     const decoration = new SvnDecorations(model);

src/model.ts

@@ -49,6 +49,10 @@ export class Model implements IDisposable {
   public readonly onDidChangeRepository: Event<IModelChangeEvent> = this
     ._onDidChangeRepository.event;
 
+  private _onDidChangeStatusRepository = new EventEmitter<Repository>();
+  public readonly onDidChangeStatusRepository: Event<Repository> = this
+    ._onDidChangeStatusRepository.event;
+
   public openRepositories: IOpenRepository[] = [];
   private disposables: Disposable[] = [];
   private enabled = false;
@@ -139,12 +143,6 @@ export class Model implements IDisposable {
       this.disposables
     );
 
-    window.onDidChangeActiveTextEditor(
-      () => this.checkHasChangesOnActiveEditor(),
-      this,
-      this.disposables
-    );
-
     await this.scanWorkspaceFolders();
   }
 
@@ -180,54 +178,6 @@ export class Model implements IDisposable {
       .forEach(p => this.eventuallyScanPossibleSvnRepository(p));
   }
 
-  private hasChangesOnActiveEditor(): boolean {
-    if (!window.activeTextEditor) {
-      return false;
-    }
-    const uri = window.activeTextEditor.document.uri;
-
-    const repository = this.getRepository(uri);
-    if (!repository) {
-      return false;
-    }
-
-    const resource = repository.getResourceFromFile(uri);
-    if (!resource) {
-      return false;
-    }
-
-    switch (resource.type) {
-      case Status.ADDED:
-      case Status.DELETED:
-      case Status.EXTERNAL:
-      case Status.IGNORED:
-      case Status.NONE:
-      case Status.NORMAL:
-      case Status.UNVERSIONED:
-        return false;
-      case Status.CONFLICTED:
-      case Status.INCOMPLETE:
-      case Status.MERGED:
-      case Status.MISSING:
-      case Status.MODIFIED:
-      case Status.OBSTRUCTED:
-      case Status.REPLACED:
-        return true;
-    }
-
-    // Show if not match
-    return true;
-  }
-
-  @debounce(100)
-  private checkHasChangesOnActiveEditor() {
-    commands.executeCommand(
-      "setContext",
-      "svnActiveEditorHasChanges",
-      this.hasChangesOnActiveEditor()
-    );
-  }
-
   private disable(): void {
     this.repositories.forEach(repository => repository.dispose());
     this.openRepositories = [];
@@ -456,15 +406,19 @@ export class Model implements IDisposable {
       this._onDidChangeRepository.fire({ repository, uri })
     );
 
+    const changeStatus = repository.onDidChangeStatus(() => {
+      this._onDidChangeStatusRepository.fire(repository);
+    });
+
     const statusListener = repository.onDidChangeStatus(() => {
       this.scanExternals(repository);
-      this.checkHasChangesOnActiveEditor();
     });
     this.scanExternals(repository);
 
     const dispose = () => {
       disappearListener.dispose();
       changeListener.dispose();
+      changeStatus.dispose();
       statusListener.dispose();
       repository.dispose();