refactor: using stricter tsconfig settings (#582)

Author: JohnstonCode

package-lock.json

@@ -13,7 +13,7 @@ export function getChangelistPickOptions(
   const picks: QuickPickItem[] = [];
 
   picks.push(new NewChangeListItem());
-  repository.changelists.forEach((group, changelist) => {
+  repository.changelists.forEach((group, _changelist) => {
     if (group.resourceStates.length) {
       picks.push(new ChangeListItem(group));
     }
@@ -119,7 +119,7 @@ export async function inputCommitChangelist(repository: Repository) {
 export function patchChangelistOptions(repository: Repository) {
   const picks: QuickPickItem[] = [];
 
-  repository.changelists.forEach((group, changelist) => {
+  repository.changelists.forEach((group, _changelist) => {
     if (group.resourceStates.length) {
       picks.push(new ChangeListItem(group));
     }

src/changelistItems.ts

@@ -6,7 +6,7 @@ export class AddToIgnoreExplorer extends Command {
     super("svn.addToIgnoreExplorer");
   }
 
-  public async execute(mainUri?: Uri, allUris?: Uri[]) {
+  public async execute(_mainUri?: Uri, allUris?: Uri[]) {
     if (!allUris || allUris.length === 0) {
       return;
     }

src/commands/addToIgnoreExplorer.ts

@@ -1,4 +1,4 @@
-import { commands, SourceControlResourceState, Uri, window } from "vscode";
+import { commands, Uri, window } from "vscode";
 import { inputSwitchChangelist } from "../changelistItems";
 import { Model } from "../model";
 import { Resource } from "../resource";
@@ -64,7 +64,7 @@ export class ChangeList extends Command {
     const paths = uris.map(uri => uri.fsPath);
     let canRemove = false;
 
-    repository.changelists.forEach((group, changelist) => {
+    repository.changelists.forEach((group, _changelist) => {
       if (
         group.resourceStates.some(state => {
           return paths.some(path => {
@@ -77,6 +77,8 @@ export class ChangeList extends Command {
         canRemove = true;
         return false;
       }
+
+      return;
     });
 
     const changelistName = await inputSwitchChangelist(repository, canRemove);

src/commands/changeList.ts

@@ -1,4 +1,3 @@
-import { Model } from "../model";
 import { Repository } from "../repository";
 import { Command } from "./command";
 

src/commands/cleanup.ts

@@ -185,6 +185,8 @@ export abstract class Command implements Disposable {
 
       return repository.getResourceFromFile(uri);
     }
+
+    return;
   }
 
   protected async _openResource(
@@ -286,6 +288,8 @@ export abstract class Command implements Disposable {
           ref: against
         });
     }
+
+    return;
   }
 
   protected getRightResource(
@@ -312,6 +316,8 @@ export abstract class Command implements Disposable {
           ref: against
         });
     }
+
+    return;
   }
 
   private getTitle(resource: Resource, against?: string): string {

src/commands/command.ts

@@ -1,6 +1,5 @@
 import { window } from "vscode";
 import { IAuth } from "../common/types";
-import { Repository } from "../repository";
 import { Command } from "./command";
 
 export class PromptAuth extends Command {

src/commands/promptAuth.ts

@@ -9,7 +9,11 @@ export class RenameExplorer extends Command {
     super("svn.renameExplorer", { repository: true });
   }
 
-  public async execute(repository: Repository, mainUri?: Uri, allUris?: Uri[]) {
+  public async execute(
+    repository: Repository,
+    mainUri?: Uri,
+    _allUris?: Uri[]
+  ) {
     if (!mainUri) {
       return;
     }

src/commands/renameExplorer.ts

@@ -31,19 +31,19 @@ export default class SvnDecorationProvider implements DecorationProvider {
     this.collectDecorationData(this.repository.unversioned, newDecorations);
     this.collectDecorationData(this.repository.conflicts, newDecorations);
 
-    this.repository.changelists.forEach((group, changelist) => {
+    this.repository.changelists.forEach((group, _changelist) => {
       this.collectDecorationData(group, newDecorations);
     });
 
     const uris: Uri[] = [];
-    newDecorations.forEach((value, uriString) => {
+    newDecorations.forEach((_value, uriString) => {
       if (this.decorations.has(uriString)) {
         this.decorations.delete(uriString);
       } else {
         uris.push(Uri.parse(uriString));
       }
     });
-    this.decorations.forEach((value, uriString) => {
+    this.decorations.forEach((_value, uriString) => {
       uris.push(Uri.parse(uriString));
     });
     this.decorations = newDecorations;

src/decorations/svnDecorationProvider.ts

@@ -47,6 +47,7 @@ export default class SvnIgnoreDecorationProvider implements DecorationProvider {
           color: new ThemeColor("gitDecoration.ignoredResourceForeground")
         } as DecorationData;
       }
+      return;
     });
   }