feat: Added config option to show previous commits by user (#1023)

Author: JohnstonCode

package.json

@@ -1274,6 +1274,11 @@
                     "type": "boolean",
                     "description": "Set to ignore externals definitions on update (add --ignore-externals)",
                     "default": true
+                },
+                "svn.previousCommitsUser": {
+                    "type": "string",
+                    "description": "Only show previous commits for a given user. Requires svn >= 1.8",
+                    "default": null
                 }
             }
         }

src/commands.ts

@@ -91,7 +91,7 @@ export function registerCommands(
   disposables.push(new OpenChangeHead());
   disposables.push(new OpenHeadFile());
   disposables.push(new RevertAll());
-  disposables.push(new PickCommitMessage());
+  disposables.push(new PickCommitMessage(sourceControlManager.svn.version));
   disposables.push(new RevertExplorer());
   disposables.push(new SearchLogByRevision());
   disposables.push(new SearchLogByText());

src/commands/pickCommitMessage.ts

@@ -1,14 +1,24 @@
 import { QuickPickItem, window } from "vscode";
 import { Repository } from "../repository";
 import { Command } from "./command";
+import { configuration } from "../helpers/configuration";
+import * as semver from "semver";
+import { ISvnLogEntry } from "../common/types";
 
 export class PickCommitMessage extends Command {
-  constructor() {
+  constructor(private svnVersion: string) {
     super("svn.pickCommitMessage", { repository: true });
   }
 
   public async execute(repository: Repository) {
-    const logs = await repository.log("HEAD", "0", 20);
+    const is18orGreater = semver.satisfies(this.svnVersion, ">= 1.8");
+    let logs: ISvnLogEntry[] = [];
+    const user = configuration.get("previousCommitsUser", null);
+    if (user && is18orGreater) {
+      logs = await repository.logByUser(user);
+    } else {
+      logs = await repository.log("HEAD", "0", 20);
+    }
 
     if (!logs.length) {
       return;

src/repository.ts

@@ -876,6 +876,10 @@ export class Repository implements IRemoteRepository {
     );
   }
 
+  public async logByUser(user: string) {
+    return this.run(Operation.Log, () => this.repository.logByUser(user));
+  }
+
   public async cleanup() {
     return this.run(Operation.CleanUp, () => this.repository.cleanup());
   }

src/svn.ts

@@ -59,6 +59,8 @@ export function cpErrorHandler(
 }
 
 export class Svn {
+  public version: string;
+
   private svnPath: string;
   private lastCwd: string = "";
 
@@ -69,6 +71,7 @@ export class Svn {
 
   constructor(options: ISvnOptions) {
     this.svnPath = options.svnPath;
+    this.version = options.version;
   }
 
   public logOutput(output: string): void {

src/svnRepository.ts

@@ -702,6 +702,12 @@ export class Repository {
     return parseSvnLog(result.stdout);
   }
 
+  public async logByUser(user: string) {
+    const result = await this.exec(["log", "--xml", "-v", "--search", user]);
+
+    return parseSvnLog(result.stdout);
+  }
+
   public async countNewCommit(revision: string = "BASE:HEAD") {
     const result = await this.exec(["log", "-r", revision, "-q", "--xml"]);