Refactor code to say newCommits

Author: johnjacobkenny

package.json

@@ -360,11 +360,10 @@
             "How frequently (in minutes) to check branch changes. Set to `0` to avoid periodic checks.",
           "default": 5
         },
-        "svn.newsCommits.update": {
+        "svn.newCommits.update": {
           "type": "number",
           "minimum": 0,
-          "description":
-            "How frequently (in minutes) to check news commits. Set to `0` to avoid periodic checks.",
+          "description": "How frequently (in minutes) to check for new commits. Set to `0` to avoid periodic checks.",
           "default": 5
         },
         "svn.multipleFolders.enabled": {

src/repository.ts

@@ -40,7 +40,7 @@ export class Repository {
   public isUpdatingRevision: boolean = false;
   public branches: any[] = [];
   public branchesTimer: NodeJS.Timer;
-  public newsCommit: number = 0;
+  public newCommits: number = 0;
 
   private _onDidChangeRepository = new EventEmitter<Uri>();
   readonly onDidChangeRepository: Event<Uri> = this._onDidChangeRepository
@@ -52,8 +52,8 @@ export class Repository {
   private _onDidChangeBranch = new EventEmitter<void>();
   readonly onDidChangeBranch: Event<void> = this._onDidChangeBranch.event;
 
-  private _onDidChangeNewsCommit = new EventEmitter<void>();
-  readonly onDidChangeNewsCommit: Event<void> = this._onDidChangeNewsCommit
+  private _onDidChangeNewCommits = new EventEmitter<void>();
+  readonly onDidChangeNewCommits: Event<void> = this._onDidChangeNewCommits
     .event;
 
   get root(): string {
@@ -171,15 +171,15 @@ export class Repository {
       }, 1000 * 60 * updateFreq);
     }
 
-    const updateFreqNews = svnConfig.get<number>("svn.newsCommits.update");
-    if (updateFreqNews) {
+    const updateFreqNewCommits = svnConfig.get<number>("svn.newCommits.update");
+    if (updateFreqNewCommits) {
       setInterval(() => {
-        this.updateNewsCommits();
-      }, 1000 * 60 * updateFreqNews);
+        this.updateNewCommits();
+      }, 1000 * 60 * updateFreqNewCommits);
     }
 
     this.updateBranches();
-    this.updateNewsCommits();
+    this.updateNewCommits();
     this.update();
   }
 
@@ -193,11 +193,11 @@ export class Repository {
   }
 
   @debounce(1000)
-  async updateNewsCommits() {
-    const newsCommit = await this.repository.countNewsCommit();
-    if (newsCommit !== this.newsCommit) {
-      this.newsCommit = newsCommit;
-      this._onDidChangeNewsCommit.fire();
+  async updateNewCommits() {
+    const newCommits = await this.repository.countNewCommits();
+    if (newCommits !== this.newCommits) {
+      this.newCommits = newCommits;
+      this._onDidChangeNewCommits.fire();
     }
   }
 
@@ -385,7 +385,7 @@ export class Repository {
     this.isSwitchingBranch = false;
     this.updateBranches();
     this._onDidChangeBranch.fire();
-    this.updateNewsCommits()
+    this.updateNewCommits()
     return response;
   }
 
@@ -410,15 +410,15 @@ export class Repository {
       this.isSwitchingBranch = false;
       this.updateBranches();
       this._onDidChangeBranch.fire();
-      this.updateNewsCommits()
+      this.updateNewCommits()
     }
   }
 
   async updateRevision() {
     this.isUpdatingRevision = true;
     const response = await this.repository.update();
     this.isUpdatingRevision = false;
-    this.updateNewsCommits();
+    this.updateNewCommits();
     return response;
   }
 

src/statusBar.ts

@@ -31,7 +31,7 @@ export class SvnStatusBar {
       null,
       this.disposables
     );
-    repository.onDidChangeNewsCommit(
+    repository.onDidChangeNewCommits(
       this._onDidChange.fire,
       this._onDidChange,
       this.disposables
@@ -55,9 +55,9 @@ export class SvnStatusBar {
 
     const icon = this.repository.isUpdatingRevision ? "sync~spin" : "sync";
     const title =
-      this.repository.newsCommit > 0
-        ? `${this.repository.newsCommit} news commits`
-        : "Updated";
+      this.repository.newCommits > 0
+        ? `${this.repository.newCommits} new commits`
+        : "No new commits";
 
     result.push({
       command: "svn.update",

src/svnRepository.ts

@@ -323,7 +323,7 @@ export class Repository {
     return result.stdout;
   }
 
-  async countNewsCommit(revision: string = "BASE:HEAD") {
+  async countNewCommits(revision: string = "BASE:HEAD") {
     const result = await this.svn.exec(this.workspaceRoot, [
       "log",
       "-r",