don't specialize greater than (#154)

* don't specialize greater than

* remove omitted method

* version bump to v0.6.8

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "ApproxFunBase"
 uuid = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"
-version = "0.6.7"
+version = "0.6.8"
 
 [deps]
 AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"

src/Domain.jl

@@ -167,7 +167,7 @@ invfromcanonicalD(d::Domain,x...) = 1/fromcanonicalD(d,x...)
 ## sorting
 # we sort spaces lexigraphically by default
 
-for OP in (:<,:(<=),:>,:(>=),:(isless))
+for OP in (:<,:(<=),:(isless))
     @eval $OP(a::Domain,b::Domain)=$OP(string(a),string(b))
 end
 

src/Space.jl

@@ -439,7 +439,7 @@ end
 ## sorting
 # we sort spaces lexigraphically by default
 
-for OP in (:<,:(<=),:>,:(>=),:(isless))
+for OP in (:<,:(<=),:(isless))
     @eval $OP(a::Space,b::Space)=$OP(string(a),string(b))
 end
 

src/specialfunctions.jl

@@ -312,7 +312,7 @@ end
 
 ## <,≤,>,≥
 
-for op in (:<,:>)
+for op in (:<,)
     @eval begin
         function $op(f::Fun,c::Number)
             if length(roots(f-c))==0
@@ -333,7 +333,7 @@ end
 
 
 
-for op in (:(<=),:(>=))
+for op in (:(<=),)
     @eval begin
         function $op(f::Fun,c::Number)
             rts=roots(f-c)
@@ -429,7 +429,7 @@ for SP in (:ConstantSpace,:PointSpace)
     end
 end
 
-for OP in (:<,:(Base.isless),:(<=),:>,:(>=))
+for OP in (:<,:(Base.isless),:(<=))
     @eval begin
         $OP(a::Fun{CS},b::Fun{CS}) where {CS<:ConstantSpace} = $OP(convert(Number,a),Number(b))
         $OP(a::Fun{CS},b::Number) where {CS<:ConstantSpace} = $OP(convert(Number,a),b)

test/SpacesTest.jl

@@ -160,6 +160,14 @@ using ApproxFunOrthogonalPolynomials
         @test (@inferred convert(Fun, 2)) == Fun(2)
         f = Fun(2)
         @test (@inferred convert(Fun{typeof(space(f))}, 2)) == f
+
+        f = Fun(2, ConstantSpace(0..1))
+        g = Fun(3, ConstantSpace(0..1))
+        @test f < g
+        @test f <= g
+        @test g > f
+        @test g >= f
+        @test 1 < f < 3
     end
 
     @testset "promotion" begin
@@ -172,6 +180,10 @@ using ApproxFunOrthogonalPolynomials
         end
     end
 
+    @testset "Comparison" begin
+        @test PointSpace(1:3) > ConstantSpace(0..1)
+    end
+
     @testset "union and AmbiguousSpace" begin
         a = PointSpace(1:3)
         @test (@inferred union(a, a)) == a

test/runtests.jl

@@ -81,6 +81,15 @@ end
             @test union(1..2, d) == 1..2
         end
     end
+
+    @testset "comparison" begin
+        # Lexicographic comparison
+        @test ApproxFunBase.AnyDomain() < ApproxFunBase.EmptyDomain()
+        @test 1..2 < 1..3
+        @test 1..2 <= 1..2
+        @test 1..2 >= 1..2
+        @test 1..3 >= 1..2
+    end
 end
 
 @time include("MatrixTest.jl")