Merge pull request #463 from JuliaDebug/teh/run_compiled_revise

Push a few ccalling methods onto compiled_methods

Author: pfitzseb

src/optimize.jl

@@ -183,14 +183,16 @@ function optimize!(code::CodeInfo, scope)
                 arg1 = stmt.args[1]
                 if (arg1 === :llvmcall || lookup_stmt(code.code, arg1) === Base.llvmcall) && isempty(sparams) && scope isa Method
                     nargs = length(stmt.args)-4
-                    delete_idx = build_compiled_call!(stmt, Base.llvmcall, code, idx, nargs, sparams, evalmod)
+                    # Call via `invokelatest` to avoid compiling it until we need it
+                    delete_idx = Base.invokelatest(build_compiled_call!, stmt, Base.llvmcall, code, idx, nargs, sparams, evalmod)
                     delete_idx === nothing && error("llvmcall must be compiled, but exited early from build_compiled_call!")
                     push!(foreigncalls_idx, idx)
                     append!(delete_idxs, delete_idx)
                 end
             elseif stmt.head === :foreigncall && scope isa Method
                 nargs = foreigncall_version == 0 ? stmt.args[5]::Int : length(stmt.args[3]::SimpleVector)
-                delete_idx = build_compiled_call!(stmt, :ccall, code, idx, nargs, sparams, evalmod)
+                # Call via `invokelatest` to avoid compiling it until we need it
+                delete_idx = Base.invokelatest(build_compiled_call!, stmt, :ccall, code, idx, nargs, sparams, evalmod)
                 if delete_idx !== nothing
                     push!(foreigncalls_idx, idx)
                     append!(delete_idxs, delete_idx)

src/packagedef.jl

@@ -106,6 +106,13 @@ function set_compiled_methods()
         end
     end
 
+    # This is about performance, not safety (issue #462)
+    push!(compiled_methods, which(nameof, (Module,)))
+    push!(compiled_methods, which(Base.binding_module, (Module, Symbol)))
+    push!(compiled_methods, which(Base.unsafe_pointer_to_objref, (Ptr,)))
+    push!(compiled_methods, which(Vector{Int}, (UndefInitializer, Int)))
+    push!(compiled_methods, which(fill!, (Vector{Int8}, Int)))
+
     ###########
     # Modules #
     ###########