fix broadcast regression

Author: rayegun

src/operations/broadcasts.jl

@@ -103,22 +103,14 @@ modifying(::typeof(emul)) = emul!
         # for many operations. But for non-builtins we'd need an API of sorts.
         # To get around this for now we will require that Vectors be on the left
         # and transposed vectors be on the right.
-        if left isa AbstractGBVector && right isa GBMatrixOrTranspose
+        if left isa AbstractVector && right isa GBMatrixOrTranspose && 
+            !(size(left, 1) == size(right, 1) && size(left, 2) == size(right, 2))
             return *(Diagonal(left), right, (any, f))
         end
-        if left isa GBMatrixOrTranspose && right isa Transpose{<:Any, <:AbstractGBVector}
+        if left isa GBMatrixOrTranspose && right isa Transpose{<:Any, <:AbstractVector} && 
+            !(size(left, 1) == size(right, 1) && size(left, 2) == size(right, 2))
             return *(left, Diagonal(right), (any, f))
         end
-        if left isa GBMatrixOrTranspose && right isa AbstractGBVector
-            throw(ArgumentError(
-                "Broadcasting a GBVector into a GBMatrix is only currently " *
-                "supported with the GBVector on the left."))
-        end
-        if right isa GBMatrixOrTranspose && left isa Transpose{<:Any, <:AbstractGBVector}
-            throw(ArgumentError(
-                "Broadcasting a Transpose{<:Any, <:AbstractGBVector} into a GBMatrix" *
-                " is only currently supported with the GBVector on the right."))
-        end
         if left isa GBArrayOrTranspose && right isa GBArrayOrTranspose
             add = defaultadd(f)
             return add(left, right, f)
@@ -184,11 +176,19 @@ mutatingop(::typeof(apply)) = apply!
                     # If they're further nested broadcasts we can't fuse them, so just copy.
                     subargleft isa Broadcast.Broadcasted && (subargleft = copy(subargleft))
                     subargright isa Broadcast.Broadcasted && (subargright = copy(subargright))
+                    if left isa AbstractVector && right isa GBMatrixOrTranspose && 
+                        !(size(left, 1) == size(right, 1) && size(left, 2) == size(right, 2))
+                        return *(Diagonal(left), right, (any, f); accum)
+                    end
+                    if left isa GBMatrixOrTranspose && right isa Transpose{<:Any, <:AbstractVector} && 
+                        !(size(left, 1) == size(right, 1) && size(left, 2) == size(right, 2))
+                        return *(left, Diagonal(right), (any, f); accum)
+                    end
                     if subargleft isa StridedArray
-                        subargleft = pack(subargleft; fill = subargright isa GBArrayOrTranspose ? getfill(right) : nothing)
+                        subargleft = pack(subargleft; fill = subargright isa GBArrayOrTranspose ? getfill(right) : 0)
                     end
                     if subargright isa StridedArray
-                        subargright = pack(subargright; fill = subargleft isa GBArrayOrTranspose ? getfill(subargleft) : nothing)
+                        subargright = pack(subargright; fill = subargleft isa GBArrayOrTranspose ? getfill(subargleft) : 0)
                     end
                     if subargleft isa GBArrayOrTranspose && subargright isa GBArrayOrTranspose
                         add = mutatingop(defaultadd(f))
@@ -208,10 +208,10 @@ mutatingop(::typeof(apply)) = apply!
                 right = copy(right)
             end
             if left isa StridedArray
-                left = pack(left; fill = right isa GBArrayOrTranspose ? getfill(right) : nothing)
+                left = pack(left; fill = right isa GBArrayOrTranspose ? getfill(right) : 0)
             end
             if right isa StridedArray
-                right = pack(right; fill = left isa GBArrayOrTranspose ? getfill(left) : nothing)
+                right = pack(right; fill = left isa GBArrayOrTranspose ? getfill(left) : 0)
             end
             if left isa GBArrayOrTranspose && right isa GBArrayOrTranspose
                 add = mutatingop(defaultadd(f))