fix indexing

Author: rayegun

benchmarks/Manifest.toml

@@ -17,9 +17,9 @@ uuid = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
 
 [[BenchmarkTools]]
 deps = ["JSON", "Logging", "Printf", "Profile", "Statistics", "UUIDs"]
-git-tree-sha1 = "940001114a0147b6e4d10624276d56d531dd9b49"
+git-tree-sha1 = "4c10eee4af024676200bc7752e536f858c6b8f93"
 uuid = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf"
-version = "1.2.2"
+version = "1.3.1"
 
 [[BitTwiddlingConvenienceFunctions]]
 deps = ["Static"]
@@ -295,9 +295,9 @@ version = "1.4.1"
 
 [[Parsers]]
 deps = ["Dates"]
-git-tree-sha1 = "85b5da0fa43588c75bb1ff986493443f821c70b7"
+git-tree-sha1 = "621f4f3b4977325b9128d5fae7a8b4829a0c2222"
 uuid = "69de0a69-1ddd-5017-9359-2bf0b02dc9f0"
-version = "2.2.3"
+version = "2.2.4"
 
 [[Pkg]]
 deps = ["Artifacts", "Dates", "Downloads", "LibGit2", "Libdl", "Logging", "Markdown", "Printf", "REPL", "Random", "SHA", "Serialization", "TOML", "Tar", "UUIDs", "p7zip_jll"]
@@ -423,21 +423,21 @@ version = "0.2.0"
 
 [[StrideArraysCore]]
 deps = ["ArrayInterface", "CloseOpenIntervals", "IfElse", "LayoutPointers", "ManualMemory", "Requires", "SIMDTypes", "Static", "ThreadingUtilities"]
-git-tree-sha1 = "28debdcb4371020f89ffce06af4f7f68905a5fec"
+git-tree-sha1 = "c7e0392560f15771003cce388fe8471d17941374"
 uuid = "7792a7ef-975c-4747-a70f-980b88e8d1da"
-version = "0.2.15"
+version = "0.2.19"
 
 [[SuiteSparse]]
 deps = ["Libdl", "LinearAlgebra", "Serialization", "SparseArrays"]
 uuid = "4607b0f0-06f3-5cda-b6b1-a6196a1729e9"
 
 [[SuiteSparseGraphBLAS]]
 deps = ["ChainRulesCore", "HyperSparseMatrices", "Libdl", "LinearAlgebra", "MacroTools", "Preferences", "Random", "SSGraphBLAS_jll", "Serialization", "SparseArrays", "SpecialFunctions", "StorageOrders", "SuiteSparse"]
-git-tree-sha1 = "c826a940f860b8cdf6c4c25b09f6bb08260d8783"
+git-tree-sha1 = "33576d2926608fdfe958334400eac5b73c58c7d1"
 repo-rev = "master"
 repo-url = "https://github.com/JuliaSparse/SuiteSparseGraphBLAS.jl.git"
 uuid = "c2e53296-7b14-11e9-1210-bddfa8111e1d"
-version = "0.5.0"
+version = "0.6.1"
 
 [[SuiteSparseMatrixCollection]]
 deps = ["DataFrames", "JLD2", "Pkg"]

src/libutils.jl

@@ -64,13 +64,14 @@ end
 end
 
 @inline function decrement!(I)
-    I isa Vector && (return I .-= 1)
     I isa Number && (return I - 1)
+    parent(I) isa Vector && (return I .-= 1)
     return I # don't need to modify here, likely an AllType.
 end
+
 @inline function increment!(I)
-    I isa Vector && (return I .+= 1)
     I isa Number && (return I + 1)
+    parent(I) isa Vector && (return I .+= 1)
     return I # don't need to modify here, likely an AllType.
 end
 

test/gbarray.jl

@@ -23,6 +23,9 @@
             @test m[1:2:5, 1:2] == GBMatrix(x[1:2:5, 1:2])
             @test m[1:2:5, :] == GBMatrix(x[1:2:5, :])
 
+            A = GBMatrix([[1,2] [3,4]])
+            @test A[[1,2], [1,1]] == [[1,2] [1,2]]
+
         end
         @testset "sparse" begin
             #Construction and indexing correct for sparse matrices