From 8c0e6be673040c7d252404100d89a9ec394981c6 Mon Sep 17 00:00:00 2001 From: Kai Ninomiya Date: Tue, 25 Sep 2018 23:37:19 -0700 Subject: [PATCH] Bikeshedding on WEBGL_video_texture This is a placeholder PR for bikeshedding on WEBGL_video_texture. I've suggested a rename here, because I think the old one was confusing. I like something like this because it retains the "texImage2D" heritage. Without it, it's not clear that this behaves much like an upload call. However I'm open to other ideas. --- extensions/proposals/WEBGL_video_texture/extension.xml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/extensions/proposals/WEBGL_video_texture/extension.xml b/extensions/proposals/WEBGL_video_texture/extension.xml index 764e6044af..33eac6230e 100644 --- a/extensions/proposals/WEBGL_video_texture/extension.xml +++ b/extensions/proposals/WEBGL_video_texture/extension.xml @@ -56,7 +56,7 @@ interface WEBGL_video_texture { const GLenum TEXTURE_VIDEO_IMAGE = 0x851D; const GLenum SAMPLER_VIDEO_IMAGE = 0x8B61; - [RaisesException] WebGLVideoFrameInfo VideoElementTargetVideoTexture( + [RaisesException] WebGLVideoFrameInfo videoTexImage2D( GLenum target, HTMLVideoElement video); }; @@ -85,7 +85,7 @@ interface WEBGL_video_texture { var ext = gl.getExtension('WEBGL_video_texture'); if(ext !=== null){ gl.bindTexture(ext.TEXTURE_VIDEO_IMAGE, videoTexture); - ext.VideoElementTargetVideoTexture(ext.TEXTURE_VIDEO_IMAGE, videoElement); + ext.videoTexImage2D(ext.TEXTURE_VIDEO_IMAGE, videoElement); gl.bindTexture(ext.TEXTURE_VIDEO_IMAGE, null); } } @@ -135,5 +135,8 @@ interface WEBGL_video_texture { Define new sampler and texture type, TEXTURE_VIDEO_IMAGE and SAMPLER_VIDEO_IMAGE. Change EGLImageTargetTexture2DOES to VideoElementTargetVideoTexture. + + Rename VideoElementTargetVideoTexture to videoTexImage2D. +