@@ -213,10 +213,10 @@ impl HashJoin {
213213#[ cfg( test) ]
214214mod test {
215215 use std:: sync:: Arc ;
216- use itertools:: Itertools ;
217216 use crate :: catalog:: { ColumnCatalog , ColumnDesc } ;
218217 use crate :: execution:: executor:: { BoxedExecutor , Executor , try_collect} ;
219218 use crate :: execution:: executor:: dql:: join:: hash_join:: HashJoin ;
219+ use crate :: execution:: executor:: dql:: test:: build_integers;
220220 use crate :: execution:: executor:: dql:: values:: Values ;
221221 use crate :: execution:: ExecutorError ;
222222 use crate :: expression:: ScalarExpression ;
@@ -226,7 +226,7 @@ mod test {
226226 use crate :: storage:: Storage ;
227227 use crate :: types:: LogicalType ;
228228 use crate :: types:: tuple:: create_table;
229- use crate :: types:: value:: { DataValue , ValueRef } ;
229+ use crate :: types:: value:: DataValue ;
230230
231231 fn build_join_values < S : Storage > ( _s : & S ) -> ( Vec < ( ScalarExpression , ScalarExpression ) > , BoxedExecutor , BoxedExecutor ) {
232232 let desc = ColumnDesc :: new ( LogicalType :: Integer , false ) ;
@@ -299,12 +299,6 @@ mod test {
299299 ( on_keys, values_t1. execute ( _s) , values_t2. execute ( _s) )
300300 }
301301
302- fn build_integers ( ints : Vec < Option < i32 > > ) -> Vec < ValueRef > {
303- ints. into_iter ( )
304- . map ( |i| Arc :: new ( DataValue :: Int32 ( i) ) )
305- . collect_vec ( )
306- }
307-
308302 #[ tokio:: test]
309303 async fn test_inner_join ( ) -> Result < ( ) , ExecutorError > {
310304 let mem_storage = MemStorage :: new ( ) ;
@@ -319,6 +313,8 @@ mod test {
319313
320314 println ! ( "inner_test: \n {}" , create_table( & tuples) ) ;
321315
316+ assert_eq ! ( tuples. len( ) , 3 ) ;
317+
322318 assert_eq ! ( tuples[ 0 ] . values, build_integers( vec![ Some ( 0 ) , Some ( 2 ) , Some ( 4 ) , Some ( 0 ) , Some ( 2 ) , Some ( 4 ) ] ) ) ;
323319 assert_eq ! ( tuples[ 1 ] . values, build_integers( vec![ Some ( 1 ) , Some ( 3 ) , Some ( 5 ) , Some ( 1 ) , Some ( 3 ) , Some ( 5 ) ] ) ) ;
324320 assert_eq ! ( tuples[ 2 ] . values, build_integers( vec![ Some ( 1 ) , Some ( 3 ) , Some ( 5 ) , Some ( 1 ) , Some ( 1 ) , Some ( 1 ) ] ) ) ;
@@ -340,6 +336,8 @@ mod test {
340336
341337 println ! ( "left_test: \n {}" , create_table( & tuples) ) ;
342338
339+ assert_eq ! ( tuples. len( ) , 4 ) ;
340+
343341 assert_eq ! ( tuples[ 0 ] . values, build_integers( vec![ Some ( 0 ) , Some ( 2 ) , Some ( 4 ) , Some ( 0 ) , Some ( 2 ) , Some ( 4 ) ] ) ) ;
344342 assert_eq ! ( tuples[ 1 ] . values, build_integers( vec![ Some ( 1 ) , Some ( 3 ) , Some ( 5 ) , Some ( 1 ) , Some ( 3 ) , Some ( 5 ) ] ) ) ;
345343 assert_eq ! ( tuples[ 2 ] . values, build_integers( vec![ Some ( 1 ) , Some ( 3 ) , Some ( 5 ) , Some ( 1 ) , Some ( 1 ) , Some ( 1 ) ] ) ) ;
@@ -362,6 +360,8 @@ mod test {
362360
363361 println ! ( "right_test: \n {}" , create_table( & tuples) ) ;
364362
363+ assert_eq ! ( tuples. len( ) , 4 ) ;
364+
365365 assert_eq ! ( tuples[ 0 ] . values, build_integers( vec![ Some ( 0 ) , Some ( 2 ) , Some ( 4 ) , Some ( 0 ) , Some ( 2 ) , Some ( 4 ) ] ) ) ;
366366 assert_eq ! ( tuples[ 1 ] . values, build_integers( vec![ Some ( 1 ) , Some ( 3 ) , Some ( 5 ) , Some ( 1 ) , Some ( 3 ) , Some ( 5 ) ] ) ) ;
367367 assert_eq ! ( tuples[ 2 ] . values, build_integers( vec![ None , None , None , Some ( 4 ) , Some ( 6 ) , Some ( 8 ) ] ) ) ;
@@ -384,6 +384,8 @@ mod test {
384384
385385 println ! ( "full_test: \n {}" , create_table( & tuples) ) ;
386386
387+ assert_eq ! ( tuples. len( ) , 5 ) ;
388+
387389 assert_eq ! ( tuples[ 0 ] . values, build_integers( vec![ Some ( 0 ) , Some ( 2 ) , Some ( 4 ) , Some ( 0 ) , Some ( 2 ) , Some ( 4 ) ] ) ) ;
388390 assert_eq ! ( tuples[ 1 ] . values, build_integers( vec![ Some ( 1 ) , Some ( 3 ) , Some ( 5 ) , Some ( 1 ) , Some ( 3 ) , Some ( 5 ) ] ) ) ;
389391 assert_eq ! ( tuples[ 2 ] . values, build_integers( vec![ None , None , None , Some ( 4 ) , Some ( 6 ) , Some ( 8 ) ] ) ) ;
0 commit comments