From 380e2b9c7fd9aa0f95b446df1bf97884b3ce21d7 Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Sun, 25 Jan 2026 10:36:09 +0545 Subject: [PATCH 1/6] build(deps): update macOS version in CI workflows to 14 --- .github/workflows/ci-cloud.yml | 2 +- .github/workflows/ci-testing.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-cloud.yml b/.github/workflows/ci-cloud.yml index c236f93..dbd315b 100644 --- a/.github/workflows/ci-cloud.yml +++ b/.github/workflows/ci-cloud.yml @@ -37,7 +37,7 @@ jobs: strategy: fail-fast: false matrix: - os: ["ubuntu-22.04", "macOS-13", "windows-2022"] + os: ["ubuntu-22.04", "macOS-14", "windows-2022"] python-version: ["3.10"] requires: ["latest"] include: diff --git a/.github/workflows/ci-testing.yml b/.github/workflows/ci-testing.yml index 2647a5a..67a882c 100644 --- a/.github/workflows/ci-testing.yml +++ b/.github/workflows/ci-testing.yml @@ -18,7 +18,7 @@ jobs: strategy: fail-fast: false matrix: - os: ["ubuntu-24.04", "macOS-13", "windows-2022"] + os: ["ubuntu-24.04", "macOS-14", "windows-2022"] python-version: ["3.9", "3.12"] requires: ["latest"] dependency: ["lightning"] @@ -26,7 +26,7 @@ jobs: - { os: "ubuntu-22.04", python-version: "3.9", requires: "oldest", dependency: "lightning" } - { os: "ubuntu-24.04", python-version: "3.12", requires: "latest", dependency: "pytorch_lightning" } - { os: "windows-2022", python-version: "3.12", requires: "latest", dependency: "pytorch_lightning" } - - { os: "macOS-13", python-version: "3.12", requires: "latest", dependency: "pytorch_lightning" } + - { os: "macOS-14", python-version: "3.12", requires: "latest", dependency: "pytorch_lightning" } # Timeout: https://stackoverflow.com/a/59076067/4521646 timeout-minutes: 35 From d6bfcc6177a4862df5b04febad56442c1ac2729e Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Fri, 30 Jan 2026 21:01:52 +0545 Subject: [PATCH 2/6] trigger ci From 314891cd582aa162a40e975250a81238d2830bf1 Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Fri, 30 Jan 2026 21:27:17 +0545 Subject: [PATCH 3/6] fix: suppress FutureWarning for deprecated isinstance check in filterwarnings --- pyproject.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/pyproject.toml b/pyproject.toml index a7e7ee3..fcf41ba 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -36,6 +36,7 @@ markers = [ ] filterwarnings = [ "error::FutureWarning", + "ignore:`isinstance\\(treespec, LeafSpec\\)` is deprecated.*:FutureWarning", ] xfail_strict = true junit_duration_report = "call" From dee17e4cabb7c47dca893490bfd2e91efb7fc0c4 Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Fri, 30 Jan 2026 21:28:41 +0545 Subject: [PATCH 4/6] chore: add concurrency settings to CI workflow for better management of pull requests --- .github/workflows/ci-testing.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci-testing.yml b/.github/workflows/ci-testing.yml index 67a882c..aee1597 100644 --- a/.github/workflows/ci-testing.yml +++ b/.github/workflows/ci-testing.yml @@ -8,6 +8,10 @@ on: # Trigger the workflow on push or pull request, but only for the main branch schedule: - cron: "0 0 * * *" # every day at midnight UTC +concurrency: + group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref }} + cancel-in-progress: ${{ github.event_name == 'pull_request' }} + defaults: run: shell: bash From a7afbd403bd321cf272a752ff9a07cd854e55e3f Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Fri, 30 Jan 2026 21:37:54 +0545 Subject: [PATCH 5/6] fix: add missing mock patch to test_upload_wrong_model_name for proper isolation --- tests/test_io_cloud.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test_io_cloud.py b/tests/test_io_cloud.py index 62c3779..09ed4b0 100644 --- a/tests/test_io_cloud.py +++ b/tests/test_io_cloud.py @@ -18,7 +18,8 @@ @pytest.mark.parametrize("name", ["/too/many/slashes", "org/model", "model-name"]) @pytest.mark.parametrize("in_studio", [True, False]) -def test_upload_wrong_model_name(name, in_studio, monkeypatch): +@mock.patch("litmodels.io.cloud.sdk_upload_model") +def test_upload_wrong_model_name(mock_sdk_upload, name, in_studio, monkeypatch): if in_studio: # mock env variables as it would run in studio monkeypatch.setenv("LIGHTNING_ORG", LIT_ORG) From 1ac85f1ecab8d4a37ec2b7133be8ac4a8e40c80c Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Fri, 30 Jan 2026 21:43:43 +0545 Subject: [PATCH 6/6] fix: add DISABLE_MPS environment variable for macOS-14 in CI workflow --- .github/workflows/ci-testing.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci-testing.yml b/.github/workflows/ci-testing.yml index aee1597..0c42d93 100644 --- a/.github/workflows/ci-testing.yml +++ b/.github/workflows/ci-testing.yml @@ -36,6 +36,7 @@ jobs: timeout-minutes: 35 env: TORCH_URL: "https://download.pytorch.org/whl/cpu/torch_stable.html" + DISABLE_MPS: ${{ matrix.os == 'macOS-14' && '1' || '0' }} steps: - uses: actions/checkout@v5