do not pass a flag to the Contructor, but create a dedicated function

Author: Murmele

include/libdbc/dbc.hpp

@@ -24,7 +24,7 @@ namespace libdbc {
 
 	class DbcParser : public Parser {
 	public:
-        DbcParser(bool sortSignals = false);
+        DbcParser();
 
 		virtual ~DbcParser() = default;
 
@@ -37,6 +37,8 @@ namespace libdbc {
         bool parseMessage(const uint32_t id, const std::vector<uint8_t>& data, std::vector<double>& out_values);
         bool parseMessage(const uint32_t id, const std::array<uint8_t, 8>& data, std::vector<double>& out_values);
 
+        void sortSignals();
+
 	private:
 		std::string version;
 		std::vector<std::string> nodes;
@@ -49,8 +51,6 @@ namespace libdbc {
 		const std::regex message_re;
 		const std::regex signal_re;
 
-        bool sortSignals{false};
-
 		void parse_dbc_header(std::istream& file_stream);
 		void parse_dbc_nodes(std::istream& file_stream);
 		void parse_dbc_messages(const std::vector<std::string>& lines);

src/dbc.cpp

@@ -29,7 +29,7 @@ const auto whiteSpace = "\\s";
 
 namespace libdbc {
 
-    DbcParser::DbcParser(bool sortSignals) : version(""), nodes(),
+    DbcParser::DbcParser() : version(""), nodes(),
 				version_re("^(VERSION)\\s\"(.*)\""), bit_timing_re("^(BS_:)"),
 				name_space_re("^(NS_)\\s\\:"), node_re("^(BU_:)\\s((?:[\\w]+?\\s?)*)"),
 				message_re("^(BO_)\\s(\\d+)\\s(\\w+)\\:\\s(\\d+)\\s(\\w+|Vector__XXX)"),
@@ -54,8 +54,7 @@ namespace libdbc {
                           whiteSpace +
                           unitPattern +
                           whiteSpace +
-                          receiverPattern),
-						  sortSignals(sortSignals) {
+                          receiverPattern) {
 
 	}
 
@@ -75,14 +74,14 @@ namespace libdbc {
 			lines.push_back(line);
 		}
 
-		parse_dbc_messages(lines);
+		parse_dbc_messages(lines);       
+	}
 
-        if (sortSignals) {
-            for (auto& message: messages) {
-                message.prepareMessage();
-            }
+    void DbcParser::sortSignals() {
+        for (auto& message: messages) {
+            message.prepareMessage();
         }
-	}
+    }
 
 	std::string DbcParser::get_version() const {
 		return version;