refactor: changed value of a config key

LuXDAmore · LuXDAmore · commit 914c4eb367d5 · 2021-02-08T13:20:32.000+01:00
diff --git a/lib/config.defaults.js b/lib/config.defaults.js
@@ -12,7 +12,7 @@ export default {
         'link[rel="preload"][as="script"]',
         'script:not([type="application/ld+json"])',
     ],
-    classesToKeep: null, // disallow pruning of scripts with this class (could be an array of classes), N.B.: each `classesToKeep` will be appended to every `selectors`, ex.: `script:not([type="application/ld+json"]):not(__classesToKeep__)`
+    classesSelectorsToKeep: [], // disallow pruning of scripts with this class (could be an array of classes), N.B.: each `classesToKeep` will be appended to every `selectors`, ex.: `script:not([type="application/ld+json"]):not(__classesToKeep__)`
     link: [], // Inject custom links, only if pruned
     script: [], // Inject custom scripts, only if pruned
     htmlElementClass: null, // this is a string added as a class to the <html> element
diff --git a/lib/config.deprecated.js b/lib/config.deprecated.js
@@ -6,5 +6,5 @@ export default {
     isLighthouse: '@deprecated since version 2.0.0, use `isAudit` instead',
     ignoreBotOrLighthouse: '@deprecated since version 2.0.0, use `isAudit` instead',
     lighthouseUserAgent: '@deprecated since version 2.0.0, use `auditUserAgent` instead',
-    selectorToKeep: '@deprecated since version 2.0.0, use `classesToKeep` instead',
+    selectorToKeep: '@deprecated since version 2.0.0, use `classesSelectorsToKeep` instead',
 };
diff --git a/lib/module.js b/lib/module.js
@@ -88,9 +88,8 @@ export default function nuxtPruneHtml(
         if( isOldOrInvalidConfig ) {
 
             logAnError(
-                'please, upgrade your configuration, there are some deprecation warnings',
+                'please, upgrade your configuration, there are some deprecation warnings, the plugin will stop its execution',
                 deprecatedConfig,
-                true
             );
 
             return;
@@ -107,7 +106,7 @@ export default function nuxtPruneHtml(
         {
             cheerio: cheerioConfig = {},
             selectors = [],
-            classesToKeep = [],
+            classesSelectorsToKeep = [],
             script = [],
             link = [],
             types = [],
@@ -119,7 +118,7 @@ export default function nuxtPruneHtml(
             return '';
 
         // Selector to selectors (in case of array)
-        const classesToKeepToArray = stringToArray( classesToKeep );
+        const classesSelectorsToKeepToArray = stringToArray( classesSelectorsToKeep );
 
         // Let's prune
         try {
@@ -133,8 +132,8 @@ export default function nuxtPruneHtml(
             // Selector to prune/keep
             for( const s of selectors ) {
 
-                if( classesToKeepToArray.length )
-                    classesToKeepToArray.forEach( keepMe => $( `${ s }:not(${ keepMe })` ).remove() );
+                if( classesSelectorsToKeepToArray.length )
+                    classesSelectorsToKeepToArray.forEach( keepMe => $( `${ s }:not(${ keepMe })` ).remove() );
                  else
                     $( s ).remove();
 
