Remove curl_close() as it does nothing and is deprecated in PHP 8.5 (#17)

alexpott · web-flow · commit c43074946d26 · 2025-08-13T15:47:39.000+01:00
diff --git a/lib/WebDriver/Service/CurlService.php b/lib/WebDriver/Service/CurlService.php
@@ -114,8 +114,6 @@ public function execute($requestMethod, $url, $parameters = null, $extraOptions
             CURLE_GOT_NOTHING !== ($errno = curl_errno($curl)) &&
             $error = curl_error($curl)
         ) {
-            curl_close($curl);
-
             $e = new CurlExecException(
                 sprintf(
                     "Curl error thrown for http %s to %s%s\n\n%s",
@@ -132,8 +130,6 @@ public function execute($requestMethod, $url, $parameters = null, $extraOptions
             throw $e;
         }
 
-        curl_close($curl);
-
         return array($rawResult, $info);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -114,8 +114,6 @@ public function execute($requestMethod, $url, $parameters = null, $extraOptions`
`114`	`114`	`CURLE_GOT_NOTHING !== ($errno = curl_errno($curl)) &&`
`115`	`115`	`$error = curl_error($curl)`
`116`	`116`	`) {`
`117`		`- curl_close($curl);`
`118`		`-`
`119`	`117`	`$e = new CurlExecException(`
`120`	`118`	`sprintf(`
`121`	`119`	`"Curl error thrown for http %s to %s%s\n\n%s",`
`@@ -132,8 +130,6 @@ public function execute($requestMethod, $url, $parameters = null, $extraOptions`
`132`	`130`	`throw $e;`
`133`	`131`	`}`
`134`	`132`
`135`		`- curl_close($curl);`
`136`		`-`
`137`	`133`	`return array($rawResult, $info);`
`138`	`134`	`}`
`139`	`135`	`}`