Test on PHP 8.4 (#19)

* Test on PHP 8.4

* Better fix for test fails than previous PR

Author: alexpott

.ddev/config.yaml

@@ -1,7 +1,7 @@
 name: php-webdriver
 type: php
 docroot: ""
-php_version: "8.3"
+php_version: "8.4"
 webserver_type: nginx-fpm
 xdebug_enabled: false
 additional_hostnames: []
@@ -17,7 +17,7 @@ nodejs_version: "18"
 corepack_enable: false
 web_extra_daemons:
     - name: chromedriver
-      command: /usr/bin/chromedriver --verbose
+      command: /usr/bin/chromedriver --port=9515 --verbose
       directory: /usr/bin
     - name: geckodriver
       command: /usr/local/bin/geckodriver -b /usr/bin/firefox

.github/workflows/Tests.yml

@@ -17,7 +17,8 @@ jobs:
 
     strategy:
       matrix:
-        php: [ '8.0', '8.3' ]
+        # Changes here might also require changes to .ddev/config.yaml.
+        php: [ '8.0', '8.4' ]
       fail-fast: false
 
     steps:

test/Test/WebDriver/ChromeDriverNonW3CTest.php

@@ -32,6 +32,5 @@
 class ChromeDriverNonW3CTest extends ChromeDriverTest
 {
     protected $w3c = false;
-    protected $testWebDriverRootUrl = 'http://oldchrome:4444';
 
 }

test/Test/WebDriver/ChromeDriverTest.php

@@ -35,7 +35,7 @@
  */
 class ChromeDriverTest extends WebDriverTestBase
 {
-    protected $testWebDriverRootUrl = 'http://chrome:4444';
+    protected $testWebDriverRootUrl = 'http://localhost:9515';
     protected $testWebDriverName    = 'chromedriver';
     protected $w3c = true;
     protected $status = null;
@@ -71,7 +71,8 @@ protected function setUp(): void
     public function testStatus()
     {
         $this->assertEquals(1, $this->status['ready'], 'Chromedriver is not ready');
-        $this->assertEquals('Selenium Grid ready.', $this->status['message'], 'Chromedriver is not ready');
+        $this->assertEquals('ChromeDriver ready for new sessions.', $this->status['message'], 'Chromedriver is not ready');
+        $this->assertNotEmpty($this->status['os'], 'OS info not detected');
         $this->assertSame($this->w3c, $this->session->isW3c());
     }
 }