Bump min Node version to 18.18; use LTS for dev

mcmire · mcmire · commit a978a067a0aa · 2023-12-01T16:03:16.000-07:00
Now that both extension and mobile are using Node 18, we can follow
suit.
diff --git a/.github/workflows/lint-build-test.yml b/.github/workflows/lint-build-test.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16.x, 18.x, 20.x]
+        node-version: [18.x, 20.x]
     outputs:
       child-workspace-package-names: ${{ steps.workspace-package-names.outputs.child-workspace-package-names }}
     steps:
@@ -105,7 +105,7 @@ jobs:
     needs: prepare
     strategy:
       matrix:
-        node-version: [16.x, 18.x, 20.x]
+        node-version: [18.x, 20.x]
         package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }}
     steps:
       - uses: actions/checkout@v3
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v16
+lts/*
diff --git a/constraints.pro b/constraints.pro
@@ -336,8 +336,8 @@ gen_enforced_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, 'peerDep
   DependencyIdent \= '@metamask/polling-controller',
   is_controller(DependencyIdent).
 
-% All packages must specify a minimum Node version of 16.
-gen_enforced_field(WorkspaceCwd, 'engines.node', '>=16.0.0').
+% All packages must specify a minimum Node version of 18.
+gen_enforced_field(WorkspaceCwd, 'engines.node', '>=18.18 || >=20').
 
 % All published packages are public.
 gen_enforced_field(WorkspaceCwd, 'publishConfig.access', 'public') :-
diff --git a/docs/contributing.md b/docs/contributing.md
@@ -2,8 +2,8 @@
 
 ## Getting started
 
-- Install [Node.js](https://nodejs.org) version 16.
-  - If you're using [NVM](https://github.com/creationix/nvm#installation) (recommended), `nvm use` will ensure that the right version is installed.
+- Install the current LTS version of [Node.js](https://nodejs.org)
+  - If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm install` will install the latest version and running `nvm use` will automatically choose the right node version for you.
 - Install [Yarn v3](https://yarnpkg.com/getting-started/install).
 - Run `yarn install` to install dependencies and run any required post-install scripts.
 - Run `yarn simple-git-hooks` to add a [Git hook](https://github.com/toplenboren/simple-git-hooks#what-is-a-git-hook) to your local development environment which will ensure that all files pass linting before you push a branch.
diff --git a/package.json b/package.json
@@ -75,7 +75,7 @@
   },
   "packageManager": "yarn@3.3.0",
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "lavamoat": {
     "allowScripts": {
diff --git a/packages/accounts-controller/CHANGELOG.md b/packages/accounts-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [6.0.0]
 ### Changed
diff --git a/packages/accounts-controller/package.json b/packages/accounts-controller/package.json
@@ -56,7 +56,7 @@
     "@metamask/keyring-controller": "^10.0.0"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/address-book-controller/CHANGELOG.md b/packages/address-book-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [3.1.5]
 ### Changed
diff --git a/packages/address-book-controller/package.json b/packages/address-book-controller/package.json
@@ -45,7 +45,7 @@
     "typescript": "~4.8.4"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/announcement-controller/CHANGELOG.md b/packages/announcement-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [5.0.0]
 ### Changed
diff --git a/packages/announcement-controller/package.json b/packages/announcement-controller/package.json
@@ -43,7 +43,7 @@
     "typescript": "~4.8.4"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/approval-controller/CHANGELOG.md b/packages/approval-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [5.0.0]
 ### Changed
diff --git a/packages/approval-controller/package.json b/packages/approval-controller/package.json
@@ -47,7 +47,7 @@
     "typescript": "~4.8.4"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/assets-controllers/CHANGELOG.md b/packages/assets-controllers/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [20.0.0]
 ### Added
diff --git a/packages/assets-controllers/package.json b/packages/assets-controllers/package.json
@@ -74,7 +74,7 @@
     "@metamask/preferences-controller": "^5.0.0"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/base-controller/CHANGELOG.md b/packages/base-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [4.0.0]
 ### Added
diff --git a/packages/base-controller/package.json b/packages/base-controller/package.json
@@ -46,7 +46,7 @@
     "typescript": "~4.8.4"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/build-utils/CHANGELOG.md b/packages/build-utils/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [1.0.0]
 ### Added
diff --git a/packages/build-utils/package.json b/packages/build-utils/package.json
@@ -45,7 +45,7 @@
     "typescript": "~4.8.4"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/composable-controller/CHANGELOG.md b/packages/composable-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [4.0.0]
 ### Changed
diff --git a/packages/composable-controller/package.json b/packages/composable-controller/package.json
@@ -45,7 +45,7 @@
     "typescript": "~4.8.4"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/controller-utils/CHANGELOG.md b/packages/controller-utils/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [6.1.0]
 ### Added
diff --git a/packages/controller-utils/package.json b/packages/controller-utils/package.json
@@ -51,7 +51,7 @@
     "typescript": "~4.8.4"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/ens-controller/CHANGELOG.md b/packages/ens-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [7.0.0]
 ### Changed
diff --git a/packages/ens-controller/package.json b/packages/ens-controller/package.json
@@ -52,7 +52,7 @@
     "@metamask/network-controller": "^17.0.0"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/eth-json-rpc-provider/CHANGELOG.md b/packages/eth-json-rpc-provider/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [2.3.0]
 ### Added
diff --git a/packages/eth-json-rpc-provider/package.json b/packages/eth-json-rpc-provider/package.json
@@ -54,7 +54,7 @@
   },
   "packageManager": "yarn@3.3.0",
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/gas-fee-controller/CHANGELOG.md b/packages/gas-fee-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [11.0.0]
 ### Changed
diff --git a/packages/gas-fee-controller/package.json b/packages/gas-fee-controller/package.json
@@ -59,7 +59,7 @@
     "@metamask/network-controller": "^17.0.0"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/json-rpc-engine/CHANGELOG.md b/packages/json-rpc-engine/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [7.3.0]
 ### Added
diff --git a/packages/json-rpc-engine/package.json b/packages/json-rpc-engine/package.json
@@ -59,7 +59,7 @@
   },
   "packageManager": "yarn@3.3.0",
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/json-rpc-middleware-stream/CHANGELOG.md b/packages/json-rpc-middleware-stream/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [6.0.0]
 ### Added
diff --git a/packages/json-rpc-middleware-stream/package.json b/packages/json-rpc-middleware-stream/package.json
@@ -50,7 +50,7 @@
     "webextension-polyfill-ts": "^0.26.0"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/keyring-controller/CHANGELOG.md b/packages/keyring-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [10.0.0]
 ### Changed
diff --git a/packages/keyring-controller/package.json b/packages/keyring-controller/package.json
@@ -63,7 +63,7 @@
     "@metamask/preferences-controller": "^5.0.0"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/logging-controller/CHANGELOG.md b/packages/logging-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [2.0.0]
 ### Changed
diff --git a/packages/logging-controller/package.json b/packages/logging-controller/package.json
@@ -45,7 +45,7 @@
     "typescript": "~4.8.4"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/message-manager/CHANGELOG.md b/packages/message-manager/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [7.3.6]
 ### Changed
diff --git a/packages/message-manager/package.json b/packages/message-manager/package.json
@@ -50,7 +50,7 @@
     "typescript": "~4.8.4"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/name-controller/CHANGELOG.md b/packages/name-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
 
 ## [4.0.0]
 ### Changed
diff --git a/packages/name-controller/package.json b/packages/name-controller/package.json
@@ -46,7 +46,7 @@
     "typescript": "~4.8.4"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/network-controller/CHANGELOG.md b/packages/network-controller/CHANGELOG.md
@@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Add `getNetworkConfigurationByNetworkClientId` method which can be used to retrieve details for both custom and built-in networks (using the network configuration object shape) ([#2055](https://github.com/MetaMask/core/pull/2055))
 - Add `NetworkController:getNetworkConfigurationByNetworkClientId` messenger action for the previous method ([#2055](https://github.com/MetaMask/core/pull/2055))
 
+### Changed
+- **BREAKING:** Bump minimum Node version to 18.18
+
 ## [17.0.0]
 ### Changed
 - **BREAKING:** Bump `@metamask/base-controller` to ^4.0.0 ([#2063](https://github.com/MetaMask/core/pull/2063))
diff --git a/packages/network-controller/package.json b/packages/network-controller/package.json
@@ -63,7 +63,7 @@
     "typescript": "~4.8.4"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.18 || >=20"
   },
   "publishConfig": {
     "access": "public",
diff --git a/packages/notification-controller/CHANGELOG.md b/packages/notification-controller/CHANGELOG.md
diff --git a/packages/notification-controller/package.json b/packages/notification-controller/package.json
diff --git a/packages/permission-controller/CHANGELOG.md b/packages/permission-controller/CHANGELOG.md
diff --git a/packages/permission-controller/package.json b/packages/permission-controller/package.json
diff --git a/packages/permission-log-controller/package.json b/packages/permission-log-controller/package.json
diff --git a/packages/phishing-controller/CHANGELOG.md b/packages/phishing-controller/CHANGELOG.md
diff --git a/packages/phishing-controller/package.json b/packages/phishing-controller/package.json
diff --git a/packages/polling-controller/CHANGELOG.md b/packages/polling-controller/CHANGELOG.md
diff --git a/packages/polling-controller/package.json b/packages/polling-controller/package.json
diff --git a/packages/preferences-controller/CHANGELOG.md b/packages/preferences-controller/CHANGELOG.md
diff --git a/packages/preferences-controller/package.json b/packages/preferences-controller/package.json
diff --git a/packages/queued-request-controller/CHANGELOG.md b/packages/queued-request-controller/CHANGELOG.md
diff --git a/packages/queued-request-controller/package.json b/packages/queued-request-controller/package.json
diff --git a/packages/rate-limit-controller/CHANGELOG.md b/packages/rate-limit-controller/CHANGELOG.md
diff --git a/packages/rate-limit-controller/package.json b/packages/rate-limit-controller/package.json
diff --git a/packages/selected-network-controller/CHANGELOG.md b/packages/selected-network-controller/CHANGELOG.md
diff --git a/packages/selected-network-controller/package.json b/packages/selected-network-controller/package.json
diff --git a/packages/signature-controller/CHANGELOG.md b/packages/signature-controller/CHANGELOG.md
diff --git a/packages/signature-controller/package.json b/packages/signature-controller/package.json
diff --git a/packages/transaction-controller/CHANGELOG.md b/packages/transaction-controller/CHANGELOG.md
diff --git a/packages/transaction-controller/package.json b/packages/transaction-controller/package.json
