defect #868049 : Multibranch job with branch that contains '/' in name - test results are not reported and job can not be triggered from octane.

In getJobByRefId - Decoding is removed as not relevant (it was relevant only if we try to send task by direct URL, therefore was need to decode job name, now this option is not possible and decoding cause to job not to be found, why? jenkins encode '/' with %2f in job name, and if we replace %2f by '/' - job is not found)

Author: Radislav Berkovich

src/main/java/com/microfocus/application/automation/tools/octane/CIJenkinsServicesImpl.java

@@ -685,26 +685,21 @@ private List<ParameterValue> createParameters(Job project, CIParameters ciParame
 	private Job getJobByRefId(String jobRefId) {
 		Job result = null;
 		if (jobRefId != null) {
-			try {
-				jobRefId = URLDecoder.decode(jobRefId, StandardCharsets.UTF_8.name());
-				TopLevelItem item = getTopLevelItem(jobRefId);
-				if (item instanceof Job) {
-					result = (Job) item;
-				} else if (jobRefId.contains("/") && item == null) {
-					String newJobRefId = jobRefId.substring(0, jobRefId.indexOf("/"));
-					item = getTopLevelItem(newJobRefId);
-					if (item != null) {
-						Collection<? extends Job> allJobs = item.getAllJobs();
-						for (Job job : allJobs) {
-							if (jobRefId.endsWith(job.getName())) {
-								result = job;
-								break;
-							}
+			TopLevelItem item = getTopLevelItem(jobRefId);
+			if (item instanceof Job) {
+				result = (Job) item;
+			} else if (jobRefId.contains("/") && item == null) {
+				String parentJobRefId = jobRefId.substring(0, jobRefId.indexOf("/"));
+				item = getTopLevelItem(parentJobRefId);
+				if (item != null) {
+					Collection<? extends Job> allJobs = item.getAllJobs();
+					for (Job job : allJobs) {
+						if (jobRefId.endsWith(job.getName())) {
+							result = job;
+							break;
 						}
 					}
 				}
-			} catch (UnsupportedEncodingException uee) {
-				logger.error("failed to decode job ref ID '" + jobRefId + "'", uee);
 			}
 		}
 		return result;

src/main/java/com/microfocus/application/automation/tools/octane/events/WorkflowListenerOctaneImpl.java

@@ -116,7 +116,7 @@ private void sendPipelineStartedEvent(FlowNode flowNode) {
 			event
 					.setParentCiId(parentRun.getParent().getParent().getFullName())
 					.setMultiBranchType(MultiBranchType.MULTI_BRANCH_CHILD)
-					.setProjectDisplayName(parentRun.getParent().getFullName());
+					.setProjectDisplayName(parentRun.getParent().getFullDisplayName().replaceAll(" » ", "/"));
 		}
 
 		CIJenkinsServicesImpl.publishEventToRelevantClients(event);