From f03fa1402ceabb46cbdf4fbb7c06fadc2ecc1fa5 Mon Sep 17 00:00:00 2001 From: Oliver Klee Date: Thu, 20 Feb 2025 21:21:51 +0100 Subject: [PATCH] [TASK] Extend and streamline `KeyFrameTest` - use a per-test subject similar to #963 - add a missing `@covers` annotation for the parent class - add tests for the line number Part of #757 --- tests/Unit/CSSList/KeyFrameTest.php | 39 +++++++++++++++++++++-------- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/tests/Unit/CSSList/KeyFrameTest.php b/tests/Unit/CSSList/KeyFrameTest.php index 7e9ebd8ae..89f969536 100644 --- a/tests/Unit/CSSList/KeyFrameTest.php +++ b/tests/Unit/CSSList/KeyFrameTest.php @@ -11,41 +11,60 @@ use Sabberworm\CSS\Renderable; /** + * @covers \Sabberworm\CSS\CSSList\CSSList * @covers \Sabberworm\CSS\CSSList\KeyFrame */ final class KeyFrameTest extends TestCase { /** - * @var KeyFrame + * @test */ - private $subject; + public function implementsAtRule(): void + { + $subject = new KeyFrame(); + + self::assertInstanceOf(AtRule::class, $subject); + } - protected function setUp(): void + /** + * @test + */ + public function implementsRenderable(): void { - $this->subject = new KeyFrame(); + $subject = new KeyFrame(); + + self::assertInstanceOf(Renderable::class, $subject); } /** * @test */ - public function implementsAtRule(): void + public function implementsCommentable(): void { - self::assertInstanceOf(AtRule::class, $this->subject); + $subject = new KeyFrame(); + + self::assertInstanceOf(Commentable::class, $subject); } /** * @test */ - public function implementsRenderable(): void + public function getLineNoByDefaultReturnsZero(): void { - self::assertInstanceOf(Renderable::class, $this->subject); + $subject = new KeyFrame(); + + self::assertSame(0, $subject->getLineNo()); } /** * @test */ - public function implementsCommentable(): void + public function getLineNoReturnsLineNumberProvidedToConstructor(): void { - self::assertInstanceOf(Commentable::class, $this->subject); + $lineNumber = 42; + + $subject = new KeyFrame($lineNumber); + + self::assertSame($lineNumber, $subject->getLineNo()); } }